From: Ilya Verbin <iverbin@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "Michael V. Zolotukhin" <michael.v.zolotukhin@gmail.com>,
Kirill Yukhin <kirill.yukhin@gmail.com>,
Richard Henderson <rth@redhat.com>,
GCC Development <gcc@gcc.gnu.org>,
triegel@redhat.com, Sergey Ostanevich <sergos.gnu@gmail.com>
Subject: Re: [RFC] Offloading Support in libgomp
Date: Fri, 31 Jan 2014 18:03:00 -0000 [thread overview]
Message-ID: <CADG=Z0FPFDTzc8PsFMjrU9pFPmzByE7FfqQwroyE2txRNjgPQQ@mail.gmail.com> (raw)
In-Reply-To: <20131029070331.GT30970@tucnak.zalov.cz>
Looks like there is a bug (in GOMP_target lowering? or in
gomp_map_vars_existing?)
The reproducer:
#define N 1000
void foo ()
{
int *a = malloc (N * sizeof (int));
printf ("1: %p\n", a);
#pragma omp target data map(tofrom: a[0:N])
{
printf ("2: %p\n", a);
#pragma omp target
{
int i;
for (i = 0; i < N; i++)
a[i] = i;
}
printf ("3: %p\n", a);
}
printf ("4: %p\n", a);
free (a);
}
Here GOMP_target believes that the pointer 'a' has a type TOFROM, so
it sets copy_from to true for the existing mapping of the pointer 'a',
that was mapped in GOMP_target_data. Therefore the output is
incorrect:
1: [host addr]
2: [host addr]
3: [host addr]
4: [target addr]
-- Ilya
next prev parent reply other threads:[~2014-01-31 17:18 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 22:37 Michael V. Zolotukhin
2013-08-23 0:22 ` Jakub Jelinek
2013-08-23 12:16 ` Michael V. Zolotukhin
2013-08-23 12:37 ` Jakub Jelinek
2013-08-24 6:17 ` Michael V. Zolotukhin
2013-08-25 16:24 ` Jakub Jelinek
2013-08-27 0:36 ` Michael V. Zolotukhin
2013-08-27 0:38 ` Jakub Jelinek
2013-08-27 6:16 ` Michael V. Zolotukhin
2013-08-27 8:06 ` Jakub Jelinek
2013-08-27 15:47 ` Michael V. Zolotukhin
2013-08-27 16:22 ` Jakub Jelinek
2013-08-27 19:54 ` Michael V. Zolotukhin
2013-08-28 11:21 ` Jakub Jelinek
2013-08-29 10:44 ` Michael V. Zolotukhin
2013-09-10 15:02 ` Michael V. Zolotukhin
2013-09-10 15:15 ` Jakub Jelinek
2013-09-10 15:31 ` Michael V. Zolotukhin
2013-09-10 15:36 ` Jakub Jelinek
2013-09-10 15:38 ` Michael V. Zolotukhin
2013-09-13 11:30 ` Michael V. Zolotukhin
2013-09-13 12:36 ` Jakub Jelinek
2013-09-13 13:11 ` Michael V. Zolotukhin
2013-09-13 13:16 ` Jakub Jelinek
2013-09-13 15:09 ` Ilya Tocar
2013-09-13 15:34 ` Jakub Jelinek
2014-07-17 7:52 ` Thomas Schwinge
2014-07-17 12:30 ` Ilya Verbin
2014-07-17 12:37 ` Jakub Jelinek
2014-07-17 12:58 ` Thomas Schwinge
2014-07-17 13:09 ` Thomas Schwinge
2014-07-17 13:35 ` Jakub Jelinek
2014-07-17 14:37 ` Thomas Schwinge
2013-09-13 9:35 ` Michael Zolotukhin
2013-09-13 10:52 ` Kirill Yukhin
2013-09-13 11:04 ` Nathan Sidwell
2013-09-13 11:21 ` Michael V. Zolotukhin
2013-09-16 9:35 ` Jakub Jelinek
2013-09-17 12:05 ` Michael V. Zolotukhin
2013-09-17 12:30 ` Jakub Jelinek
2013-10-28 10:43 ` Ilya Verbin
2013-10-29 8:04 ` Jakub Jelinek
2014-01-31 18:03 ` Ilya Verbin [this message]
2014-01-31 19:43 ` Jakub Jelinek
2014-02-14 15:24 ` Ilya Verbin
2014-02-14 15:43 ` Jakub Jelinek
2014-02-14 18:54 ` Richard Henderson
2014-02-17 15:59 ` Ilya Verbin
2014-02-17 16:03 ` Jakub Jelinek
2013-08-28 12:56 ` Richard Biener
2013-08-28 15:26 ` Jakub Jelinek
2013-08-28 17:03 ` Richard Biener
2013-08-28 17:15 ` Jakub Jelinek
2013-08-29 21:09 ` Richard Biener
2013-08-28 18:54 ` Torvald Riegel
2013-08-28 18:43 ` Torvald Riegel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADG=Z0FPFDTzc8PsFMjrU9pFPmzByE7FfqQwroyE2txRNjgPQQ@mail.gmail.com' \
--to=iverbin@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kirill.yukhin@gmail.com \
--cc=michael.v.zolotukhin@gmail.com \
--cc=rth@redhat.com \
--cc=sergos.gnu@gmail.com \
--cc=triegel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).