build error in libgcc

build error in libgcc

[Mike Stump]

A make clean followed by a make in the libgcc directory results in:

../../../../gcc/libgcc/config/i386/cpuinfo.c:23:25: fatal error: auto-target.h: No such file or directory
 #include "auto-target.h"

Oh, the the old days, we'd just add a dependancy… If someone knows where to add just the right one…  I ask, because there doesn't seem to be a single .h dependency anywhere…

Re: build error in libgcc

[Andreas Schwab]

Mike Stump <mikestump@comcast.net> writes:

> A make clean followed by a make in the libgcc directory results in:
>
> ../../../../gcc/libgcc/config/i386/cpuinfo.c:23:25: fatal error: auto-target.h: No such file or directory
>  #include "auto-target.h"
>
> Oh, the the old days, we'd just add a dependancy… If someone knows where to add just the right one…  I ask, because there doesn't seem to be a single .h dependency anywhere…

The right way is to let the compiler do it.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: build error in libgcc

[Ian Lance Taylor]

On Thu, Jun 20, 2013 at 6:25 PM, Mike Stump <mikestump@comcast.net> wrote:
> A make clean followed by a make in the libgcc directory results in:
>
> ../../../../gcc/libgcc/config/i386/cpuinfo.c:23:25: fatal error: auto-target.h: No such file or directory
>  #include "auto-target.h"
>
> Oh, the the old days, we'd just add a dependancy… If someone knows where to add just the right one…  I ask, because there doesn't seem to be a single .h dependency anywhere…

auto-target.h is created by the configure script.

It's a bug that it is removed by "make clean".  It should only be
removed by "make distclean".

Ian

Re: build error in libgcc

[Chung-Ju Wu]

2013/6/22 Ian Lance Taylor <iant@google.com>:
> On Thu, Jun 20, 2013 at 6:25 PM, Mike Stump <mikestump@comcast.net> wrote:
>> A make clean followed by a make in the libgcc directory results in:
>>
>> ../../../../gcc/libgcc/config/i386/cpuinfo.c:23:25: fatal error: auto-target.h: No such file or directory
>>  #include "auto-target.h"
>>
>> Oh, the the old days, we'd just add a dependancy… If someone knows where to add just the right one…  I ask, because there doesn't seem to be a single .h dependency anywhere…
>
> auto-target.h is created by the configure script.
>
> It's a bug that it is removed by "make clean".  It should only be
> removed by "make distclean".
>
> Ian

Well... in that case, how about this patch??

Index: libgcc/Makefile.in
===================================================================
--- libgcc/Makefile.in  (revision 200306)
+++ libgcc/Makefile.in  (working copy)
@@ -121,7 +121,7 @@
 .PHONY: all clean

 clean:
-       -rm -f auto-target.h libgcc_tm.h libgcc.map
+       -rm -f libgcc_tm.h libgcc.map
        -rm -f libgcc_tm.stamp stamp-h stmp-ldirs
        -rm -f *$(objext)
        -rm -f *.dep
@@ -131,6 +131,7 @@
        @$(MULTICLEAN) multi-clean DO=clean
 distclean: clean
        @$(MULTICLEAN) multi-clean DO=distclean
+       -rm -f auto-target.h
        -rm -f *~ Makefile config.cache config.status multilib.out
        -rm -f config.log
 maintainer-clean realclean: distclean


Hi, Mike, would you try it to see if it fixes the problem?
If it does, I will post the patch on gcc-patches@gcc.gnu.org
to acquire Ian's approval. :)


Best regards,
jasonwucj

Re: build error in libgcc

[Andreas Schwab]

Chung-Ju Wu <jasonwucj@gmail.com> writes:

>  clean:
> -       -rm -f auto-target.h libgcc_tm.h libgcc.map
> +       -rm -f libgcc_tm.h libgcc.map
>         -rm -f libgcc_tm.stamp stamp-h stmp-ldirs

Same for stamp-h.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: build error in libgcc

[Chung-Ju Wu]

2013/6/22 Andreas Schwab <schwab@linux-m68k.org>:
> Chung-Ju Wu <jasonwucj@gmail.com> writes:
>
>>  clean:
>> -       -rm -f auto-target.h libgcc_tm.h libgcc.map
>> +       -rm -f libgcc_tm.h libgcc.map
>>         -rm -f libgcc_tm.stamp stamp-h stmp-ldirs
>
> Same for stamp-h.
>

Like this?

===================================================================
--- libgcc/Makefile.in  (revision 200306)
+++ libgcc/Makefile.in  (working copy)
@@ -121,8 +121,8 @@
 .PHONY: all clean

 clean:
-       -rm -f auto-target.h libgcc_tm.h libgcc.map
-       -rm -f libgcc_tm.stamp stamp-h stmp-ldirs
+       -rm -f libgcc_tm.h libgcc.map
+       -rm -f libgcc_tm.stamp stmp-ldirs
        -rm -f *$(objext)
        -rm -f *.dep
        -rm -f *.a
@@ -131,6 +131,8 @@
        @$(MULTICLEAN) multi-clean DO=clean
 distclean: clean
        @$(MULTICLEAN) multi-clean DO=distclean
+       -rm -f auto-target.h
+       -rm -f stamp-h
        -rm -f *~ Makefile config.cache config.status multilib.out
        -rm -f config.log
 maintainer-clean realclean: distclean


Hi, Mike, would you try this revised one? :)


Best regards,
jasonwucj

Re: build error in libgcc

[Ian Lance Taylor]

On Sat, Jun 22, 2013 at 12:17 AM, Chung-Ju Wu <jasonwucj@gmail.com> wrote:
> Like this?
>
> ===================================================================
> --- libgcc/Makefile.in  (revision 200306)
> +++ libgcc/Makefile.in  (working copy)
> @@ -121,8 +121,8 @@
>  .PHONY: all clean
>
>  clean:
> -       -rm -f auto-target.h libgcc_tm.h libgcc.map
> -       -rm -f libgcc_tm.stamp stamp-h stmp-ldirs
> +       -rm -f libgcc_tm.h libgcc.map
> +       -rm -f libgcc_tm.stamp stmp-ldirs
>         -rm -f *$(objext)
>         -rm -f *.dep
>         -rm -f *.a
> @@ -131,6 +131,8 @@
>         @$(MULTICLEAN) multi-clean DO=clean
>  distclean: clean
>         @$(MULTICLEAN) multi-clean DO=distclean
> +       -rm -f auto-target.h
> +       -rm -f stamp-h
>         -rm -f *~ Makefile config.cache config.status multilib.out
>         -rm -f config.log
>  maintainer-clean realclean: distclean
>
>
> Hi, Mike, would you try this revised one? :)

This patch is OK with a ChangeLog entry.

Thanks.

Ian

Re: build error in libgcc

[Chung-Ju Wu]

2013/6/22 Ian Lance Taylor <iant@google.com>:
> On Sat, Jun 22, 2013 at 12:17 AM, Chung-Ju Wu <jasonwucj@gmail.com> wrote:
>> Like this?
>>
>> ===================================================================
>> --- libgcc/Makefile.in  (revision 200306)
>> +++ libgcc/Makefile.in  (working copy)
>> @@ -121,8 +121,8 @@
>>  .PHONY: all clean
>>
>>  clean:
>> -       -rm -f auto-target.h libgcc_tm.h libgcc.map
>> -       -rm -f libgcc_tm.stamp stamp-h stmp-ldirs
>> +       -rm -f libgcc_tm.h libgcc.map
>> +       -rm -f libgcc_tm.stamp stmp-ldirs
>>         -rm -f *$(objext)
>>         -rm -f *.dep
>>         -rm -f *.a
>> @@ -131,6 +131,8 @@
>>         @$(MULTICLEAN) multi-clean DO=clean
>>  distclean: clean
>>         @$(MULTICLEAN) multi-clean DO=distclean
>> +       -rm -f auto-target.h
>> +       -rm -f stamp-h
>>         -rm -f *~ Makefile config.cache config.status multilib.out
>>         -rm -f config.log
>>  maintainer-clean realclean: distclean
>>
>>
>> Hi, Mike, would you try this revised one? :)
>
> This patch is OK with a ChangeLog entry.
>
> Thanks.
>
> Ian

Thanks for the review and approval.

The patch and a ChangeLog has been posted on:
http://gcc.gnu.org/ml/gcc-patches/2013-06/msg01420.html


Best regards,
jasonwucj