From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B039C3858D1E for ; Tue, 30 Apr 2024 19:10:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B039C3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B039C3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714504208; cv=none; b=i+5X+ZO5eU9vuOSAG5+m1Nxt23WPF6DHJaSTIGDQYcQbl0+qpO+jbIsUUWSioT/XmeyncmJ7+k8+w681OFc/ihuSxwWWref0vDXr7rfV8NVtTPeCJPsjRv65vyrfdrYzGdy9LWQ/NKSSwXstDHRNjpHjJD/WMlKgmIi+qK/4hc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714504208; c=relaxed/simple; bh=szEDeiKjZPTMJEa7wxbMYOBgJdFSAqzzOyiL1zMYBPM=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ogg0otMZZ00Jzuaf7SKuy0QuNhSTi687pkHDs/5NdU5v0eunI0DxqlsxC1bnKoorWU6uHKGHCamIElfFhH1F8TJ15rIYycGi8rdGKDyp/pafGRu5BzefLTtHJaJDrak2ZDMjuR3aP1BXEvS+zYC3ey94pGyhcukN0xgzXtOc55c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714504205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bNTl9VL65t/YyqMOlxZSLtaM/x7IrmxfXnhWGRbHbh4=; b=J7f7IuQxCabFSGvyTltwEyXFAQLoOHm48m/tEvhKCrlbT36rCMy1wOKhYutqTHGDIiC5T+ eBuAPidaOwDwI8FX2kez1O+ybM++a63kM9nFZOFEbp4SFsiZKQEdNmaOwU3r+OrWzcqvPJ B3bhfIOKKz372Eu54S3VxlV3BmzqR+A= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-426-Of2ngMrXOsC3wLebvbY00g-1; Tue, 30 Apr 2024 15:10:03 -0400 X-MC-Unique: Of2ngMrXOsC3wLebvbY00g-1 Received: by mail-il1-f197.google.com with SMTP id e9e14a558f8ab-36b2eee85edso68728615ab.0 for ; Tue, 30 Apr 2024 12:10:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714504203; x=1715109003; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bNTl9VL65t/YyqMOlxZSLtaM/x7IrmxfXnhWGRbHbh4=; b=BAEbp5c80iyq8NuqHZkCAwmf4YP7Y61SzwFfZG+PPuJ0tIC2vImUoNHTskJxlYWEs9 FZ+heO1sxuFRpUohQGbvBvcNUJvkRWSp9qLh4sCpcbtfGU7AZGOgD203LNX+d9CVFms8 3MKj+UiZ04nSpLB+6Cp9UcduMO4qKwDxkSSvxwR1pkTSahUJ9QtQFgQeojpofeWkLnys mfpMloP5OJDvVGLtCXsQRlMEJP0zE5f+eob1D5196f0XX6rPL0vfSzxNxVwOLYPm3Yw6 C9xVYgAynfi4puA9S6CRkI+YsJmEJDM3pecUYi8lsgovehBSNaJZJjhvvTDzIBJn80Zu ewMQ== X-Gm-Message-State: AOJu0YzIGl1xDix0SqVsWjPvzhaVevnzOgN2cp8OtLIB/KbrEm74gjpX lB7H4uEBTBo3/FpPRL8p8Je4pLQiSZuWnusS0LDpcN89wL3HNqNKl5pabSEdpI8+EziSagCUzb1 UwxHZ5cbLiOUIiSQGAMxAOzQp0DPdfX5XdMwAmgLCqVfSarx8t0kVMacnWWcKgO6W/hTAqBSS5p 2iOsvkLP3eDdwevRCO1SA= X-Received: by 2002:a05:6e02:2167:b0:36a:1132:8c0d with SMTP id s7-20020a056e02216700b0036a11328c0dmr725213ilv.17.1714504202959; Tue, 30 Apr 2024 12:10:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGB7yzluJGADrc/dfmlBWj3mUcWzzwsy7Yl0/0rvkdDB2HmLKBkyInQjXNiTTdd425NmbB94jykfz3N82tk/g0= X-Received: by 2002:a05:6e02:2167:b0:36a:1132:8c0d with SMTP id s7-20020a056e02216700b0036a11328c0dmr725190ilv.17.1714504202695; Tue, 30 Apr 2024 12:10:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jason Merrill Date: Tue, 30 Apr 2024 15:09:51 -0400 Message-ID: Subject: Re: 1.76% performance loss in VRP due to inlining To: Aldy Hernandez Cc: GCC Mailing List , "MacLeod, Andrew" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Apr 26, 2024 at 5:44=E2=80=AFAM Aldy Hernandez via Gcc wrote: > > In implementing prange (pointer ranges), I have found a 1.74% slowdown > in VRP, even without any code path actually using the code. I have > tracked this down to irange::get_bitmask() being compiled differently > with and without the bare bones patch. With the patch, > irange::get_bitmask() has a lot of code inlined into it, particularly > get_bitmask_from_range() and consequently the wide_int_storage code. ... > +static irange_bitmask > +get_bitmask_from_range (tree type, > + const wide_int &min, const wide_int &max) ... > -irange_bitmask > -irange::get_bitmask_from_range () const My guess is that this is the relevant change: the old function has external linkage, and is therefore interposable, which inhibits inlining. The new function has internal linkage, which allows inlining. Relatedly, I wonder if we want to build GCC with -fno-semantic-interpositio= n? Jason