From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 618643858C41 for ; Wed, 20 Dec 2023 16:41:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 618643858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 618643858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703090466; cv=none; b=ZUfulQTCbaZqZtRXNvkkxPucnRJ39xwAlxZs6BqpQc5Utnuh+mY4cp13SapTHgvgqPbM5Tfijs/j0DW1Bjr2n15JNCawatF49GsbpBTmuRF3Ibfo3AIJA44OueLanGqUDwDF/DkZIpVC40t+NuMz7D72801fnn2NzihTXtLX+Cw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703090466; c=relaxed/simple; bh=3lr4xrl2nn1DJBtG3r/dMWrzVDw/llfYbSXK7lh/g0Q=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=x6nKodPDH0B/HZkcrDo5mCVP4bUw7l/D/wVRkGJlW7uuAv4PkmQs5fOd9ShnQPzPJpli8bKj7fKOkOPU/ytw9fFmDgo63Di9GSpNYqZasy+yj8DxBHZ3T86UBmTm2FowDDBFWNb5W2f+qXiaoVShZGHuwPnWJALxN6A9iucAUrM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703090464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fdbf0UkttyB3wtyuhfu4hkTmNVUjucqvrCYoH5IdRTI=; b=YUJJ4U2DE8XQjQrqS/1+41UVO5fq6GjQIMpicDFgh/v8EH0Gupvvj3P4ruFNgWP4hsHAMg neG39bjHH1VNWYj8RpTwIwrI9Fpp+4ILrAW/Wq6B7xFVcwJTSQodtqoXLpR3tV8dzY+481 Jkia0fZTpsFrCGgSamT+dByLhyNM2Bk= Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-VIUKYVPGOwe_rLqVcl9hlg-1; Wed, 20 Dec 2023 11:41:02 -0500 X-MC-Unique: VIUKYVPGOwe_rLqVcl9hlg-1 Received: by mail-io1-f69.google.com with SMTP id ca18e2360f4ac-7b7f4024988so191588139f.2 for ; Wed, 20 Dec 2023 08:41:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703090462; x=1703695262; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fdbf0UkttyB3wtyuhfu4hkTmNVUjucqvrCYoH5IdRTI=; b=BqkM5KAaHFATsSjwv80zdI8OwM82V8OE6Q0yf3+mzDVTA3iVRiv479Cn9/aR4uWToD mnlOVAlWKNybLQXkLahC/j49ZwIaMHihjh0Rlps83h5VkDklLffl2HJMBPjT3QGgfe8o A9pd5ndaFWA0WM+lOBD0RGszKtkhGZ6MOcFY8WQI/enG5gE4lfQC0WdSMXeo3u9uMZQC rgqQj72WGQcjlNZMwVTyUI/CuNHSUZGmsI9l1G9RQMM0LG20TgCcV8sUSdD8Y0iRDS2V 0ecmZJx5+ANbyt0h6PNcDEtogPPfXe8zRGJWY9qNgE0FLQHBfUFp63WgFJ9Hyru7zOLY 7VAA== X-Gm-Message-State: AOJu0YygBOaFD51xi3w06ndtUPLt89+za1MzCnEpLWPEMHE1SEdQ1o5g 0ctAtjYIXN4kyFbOVAVeKGR6+vaDQMRhYOgysVVnKnmMd3Y4z5/suItAOsAZvM22Oo664tsC6iZ jfvPZVdgNf2mvlsDV7ojIHCk= X-Received: by 2002:a05:6602:2982:b0:7b7:fca6:f7d5 with SMTP id o2-20020a056602298200b007b7fca6f7d5mr2345774ior.37.1703090462172; Wed, 20 Dec 2023 08:41:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzVNHj242kdbqr5np/Tq2I9vdYnIZ3AR852HJkZjVZnQdGaklgm6fyzpn+qR9zssLFLyeKaHeJcB1soow1PpY= X-Received: by 2002:a05:6602:2982:b0:7b7:fca6:f7d5 with SMTP id o2-20020a056602298200b007b7fca6f7d5mr2345764ior.37.1703090461930; Wed, 20 Dec 2023 08:41:01 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jason Merrill Date: Wed, 20 Dec 2023 11:40:50 -0500 Message-ID: Subject: Re: Deprecating -fgnu-tm support for GCC 14 and removing it for GCC 15 To: Richard Biener Cc: Andrew Pinski , Eric Gallager , GCC Mailing List X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000010d63060cf3a6f7" X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000010d63060cf3a6f7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 18, 2023 at 3:04=E2=80=AFAM Richard Biener via Gcc wrote: > On Mon, Dec 18, 2023 at 2:35=E2=80=AFAM Andrew Pinski via Gcc > wrote: > > > > On Sun, Dec 17, 2023 at 1:20=E2=80=AFPM Eric Gallager > wrote: > > > > > > On Sat, Dec 16, 2023 at 3:16=E2=80=AFPM Andrew Pinski via Gcc > wrote: > > > > > > > > -fgnu-tm support has not been improved since GCC 5 or earlier. It is > > > > not even supported with LTO. Does it make sense to deprecate the > > > > support for GCC 14 and remove it in GCC 15? > > > > > > > > Thanks, > > > > Andrew Pinski > > > > > > Personally, since GCC is in stage 3 now, I would push that schedule > > > back a release and move deprecation to GCC 15, and then only remove it > > > for GCC 16 if no one objects, but then again I don't actually use > > > -fgnu-tm myself, so I wouldn't be too upset if the faster schedule is > > > chosen instead. > > > > Considering -fgnu-tm has been broken for LTO ever since LTO was > > introduced, and broken with -fsanitize=3Dundefined and broken with many > > code that might use internal functions (known since 2015), I suspect > > nobody is using this option in production nor even trying it out. If > > this was stage1, I might even just recommend removing the support. But > > deprecating it during stage 3 seems like a fair compromise. > > Btw, I'm OK with deprecating it for GCC 14. Can you please propose a > patch for changes.html and add a diagnostic message when -fgnu-tm is used > (disabled with -Wno-deprecated)? > Deprecation makes sense to me. But keep in mind that transactional memory is still the subject of research and standardization efforts, though the current proposal (wg21.link/n4923) is significantly simpler than the earlier TS that GCC implemented. I don't know how much of the current implementation would carry over, but I'd be cautious about tearing everything out just yet. Jason --000000000000010d63060cf3a6f7--