From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 504B73858D33 for ; Tue, 10 Jan 2023 19:29:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 504B73858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673378970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rY8zAlQ09yBrA61bVXyHK0EDh6FpDPb5NOjVIzNAdyk=; b=Oaujo+DWeTwaCYMmcpKKdr+OltXncYeyD7GwnfEet36MJ5NsKuR3tD0LGCQ+oBQfu/Kpka cxTrK/rC+99TjOv0Q536eTtDOEkEGtVGQLdnf8gCa0nab/fDe0qKrvX4fZJZtS9UQbU2cT TKr2EhQAze9kRcGXrgVtsEXRFQLTVKE= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-141-NghSLb-fMaG-8PHiKIHE8Q-1; Tue, 10 Jan 2023 14:29:29 -0500 X-MC-Unique: NghSLb-fMaG-8PHiKIHE8Q-1 Received: by mail-il1-f200.google.com with SMTP id i20-20020a056e021d1400b0030c306598c6so9085770ila.9 for ; Tue, 10 Jan 2023 11:29:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rY8zAlQ09yBrA61bVXyHK0EDh6FpDPb5NOjVIzNAdyk=; b=3oujchZaDeult+nZZuKovSLB89mXG4omDbvxymKl6WhCFF244rBxJlDEovGG3eqTzf eePWo0eKe8doskbNM+Np/+7Rq1Iu3/KtyChmcVw6xdKSwy47l1HErTAsd+Cvpbxiym/0 BpoOwP7tjv5dxaHHshAqOp3fopP8bXFNcwfGsM4tzMElH13DJcW7MST75JRZw7+Ma9NC 5d5ZcQT3F8kaDvFfqO+J/OocnGzWOS+bG4at3bl0rl5MzGrzjwU815r56kZ921+n0atl n3CH8ZdXBzyr1OPzQ+bHtw9tRxbaVkKQSeBqvw7XZXCKPVQ3xWJVO0xJJnquqBBFmAoa lKiQ== X-Gm-Message-State: AFqh2kqVARCteh2+SVCVPRbwKnPPvMhlo/YYLkePwTQSftqNCgru45kw YZ2/I0GqHNHgAJmJ0H2ukFSlr9PNXLdnRtCixlbz9wrsq3P3YeRdMZZVlFVXn9XZuHLXw8LiUzK uiv0DBORlT/kiBmGe/MHEWHI= X-Received: by 2002:a02:b157:0:b0:375:b32f:7c75 with SMTP id s23-20020a02b157000000b00375b32f7c75mr6682861jah.162.1673378968576; Tue, 10 Jan 2023 11:29:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXu0ETG9rKg8nTWBh8c74LYWbx99As7RYx5qnxnI7QV+CroSQoNyMBkmoyWXDBQMCOcxhWhGUycYYh4C3ARTq6g= X-Received: by 2002:a02:b157:0:b0:375:b32f:7c75 with SMTP id s23-20020a02b157000000b00375b32f7c75mr6682859jah.162.1673378968293; Tue, 10 Jan 2023 11:29:28 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jason Merrill Date: Tue, 10 Jan 2023 14:29:17 -0500 Message-ID: Subject: Re: struct vs. class in GCC source To: Paul Koning Cc: GCC Development X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000faec0c05f1ede625" X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000faec0c05f1ede625 Content-Type: text/plain; charset="UTF-8" On Tue, Jan 10, 2023 at 9:51 AM Paul Koning via Gcc wrote: > Building on Mac with Clang I get warnings like this: > > ../../../gcc/gcc/cgraph.h:2629:28: warning: struct 'cgraph_edge' was > previously declared as a class; this is valid, but may result in linker > errors under the Microsoft C++ ABI [-Wmismatched-tags] > > It seems to be talking about a MS bug (since C++ says struct and class > mean the same thing other than the default access). Still, I wonder if it > would be worth changing the code to use just one of "struct" or "class" for > any given type. (And then the convention would presumably be that a POD > type is called "struct" and other types are "class".) > Yes, it might be worth adding -Wmismatched-tags to STRICT_WARN. Is bootstrapping with VC++ is supported? Jason --000000000000faec0c05f1ede625--