From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C3A90384604F for ; Wed, 3 Apr 2024 12:59:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C3A90384604F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C3A90384604F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712149185; cv=none; b=FC6lDBtDhgwjAScfU8Ufj9ReBqy+WNIvRT318FBvoCu5Hb+2GwG8Lu69UrZTovwoSZvfpqDcOtAEIr6c5jCUCqmHXPAC+vQLNT07pT8J7jjKgO1NVscnns+LoedjynGVSKzrwg9D3jeKaZCeMGE7dv1+m+4Ue5jd4tEGv+ky1DA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712149185; c=relaxed/simple; bh=mxpLLb5V946aqvcRkxeE1WKdjF4LDC3gop3xDfONUag=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=g6ge1Cf9gvyCFOMksoFPts3nMBabHkMDm/u//3PDkKQxKluV/9cDBZZFoWl33ds2FHyNiu+72mitZe9qdMr8DXWbWPGRNNzYAH2PIA1hsl+qDPKgEMjgJr9KRzhA2KZqs01nEfNc8W40umlwXEia03s4zbs/bzHfHzJktd6rDQo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712149180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RHufejlbDq45g+E6SFmi+mWTiC/SZ8D6yCJF14UyndA=; b=W6dPNtC4YR2XLM0DdvDoBjajUR8iHOGPdiWaPUfGkqgf6B5f2b3H0ntIygDBlX7eUcPGRv /gUVxc85lRPdv0l677jgqt7hQEuR7qnj8TYj4JQf8rvCxCigvoyQrwhVFBQv9sihm3nlbz ZmvHBA2Qx365j5t7qjVpqAC/o4qTfUg= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-xNZRqb5YN7izpf2G2Wkq6g-1; Wed, 03 Apr 2024 08:59:38 -0400 X-MC-Unique: xNZRqb5YN7izpf2G2Wkq6g-1 Received: by mail-il1-f199.google.com with SMTP id e9e14a558f8ab-369fbbb2043so703985ab.1 for ; Wed, 03 Apr 2024 05:59:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712149178; x=1712753978; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RHufejlbDq45g+E6SFmi+mWTiC/SZ8D6yCJF14UyndA=; b=tgN0AtYz2r/hn4HXvehG+5QMcpMcc74iuWMSQaUYtItBDs+/KuZcf+XC5HknLXmOyH 7yWcxg8t9MDenZkANOtyPNcwm0mPXO2KvHMtgM3KU4bH7E9zssWnmjWAQ+RH99sPdPVN /G3yXCiZHzmydpjKNfwVQKnkDq8NoaiOzZVgHnAOTRIYBDtHGUnBAsjT80Vwx2/dP3a3 1Wn63XpRlM84XMG6xz1Jbx1QaYIirdLkkL/A6SUu6BOPAWYqhnIShoTOXYZAgxMI7mXn gd92NbsRer2rYrjVrf06okrOCjngNT8TjhTmGbhNUe7eqevUAzRWKzL2yr1hBSEL2xTI jWsw== X-Forwarded-Encrypted: i=1; AJvYcCW8Bw6sbZwYnJ6ufe8DQJXNE4yVKjrU8nN/bRG4fEWaBSF50R8E+LUuLWAbUjMoBv/2hOmin+IZ4x05dEbcpVA= X-Gm-Message-State: AOJu0YwT/xGaU7J8vFiNP4TJrXXY14q6nXXgxLDD5y6QvJ6vi4xvqxmr KiHC12vloxwi40RSIfwB2ks5mNgJzulIEtQJCyn3m09KMP/SxoqqA6d38pB1qpf+uRanzK5fQc7 4NoUFtuiOJ3DFFQYAkebsVzBhyyXO1NPVYm7a2SLvYyifolUPw4Q5kC+uN2AV7gLhGusMatZKGY KhUYt2wLOWE2YW3jfq1vk= X-Received: by 2002:a05:6e02:214a:b0:369:e460:8d5c with SMTP id d10-20020a056e02214a00b00369e4608d5cmr3030857ilv.30.1712149177922; Wed, 03 Apr 2024 05:59:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYnUFUuSpeFS3LBszkqdXboi7A3/1o6+ne+0ith2JgH1krT5laZbA/4zQTeMPkuzAukusVjuQ+Cfhv7uk5p/8= X-Received: by 2002:a05:6e02:214a:b0:369:e460:8d5c with SMTP id d10-20020a056e02214a00b00369e4608d5cmr3030839ilv.30.1712149177650; Wed, 03 Apr 2024 05:59:37 -0700 (PDT) MIME-Version: 1.0 References: <9o7ss477-q221-on04-4sor-151q11s7s99n@fhfr.qr> <8c4f8e79-67a2-4834-8b8b-d9223716ea89@suse.com> In-Reply-To: <8c4f8e79-67a2-4834-8b8b-d9223716ea89@suse.com> From: Jason Merrill Date: Wed, 3 Apr 2024 08:59:26 -0400 Message-ID: Subject: Re: Patches submission policy change To: Jan Beulich Cc: Richard Biener , Jakub Jelinek , Christophe Lyon , binutils@sourceware.org, GCC Mailing List , gdb@sourceware.org, Nick Clifton , Joel Brobecker , "Carlos O'Donell" , Maxim Kuvyrkov , Thiago Bauermann , Adhemerval Zanella X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000896a12061530cba7" X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000896a12061530cba7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Apr 3, 2024 at 6:23=E2=80=AFAM Jan Beulich via Gcc wrote: > On 03.04.2024 10:57, Richard Biener wrote: > > On Wed, 3 Apr 2024, Jan Beulich wrote: > >> On 03.04.2024 10:45, Jakub Jelinek wrote: > >>> On Wed, Apr 03, 2024 at 10:22:24AM +0200, Christophe Lyon wrote: > >>>> Any concerns/objections? > >>> > >>> I'm all for it, in fact I've been sending it like that myself for yea= rs > >>> even when the policy said not to. In most cases, the diff for the > >>> regenerated files is very small and it helps even in patch review to > >>> actually check if the configure.ac/m4 etc. changes result just in the > >>> expected changes and not some unrelated ones (e.g. caused by user usi= ng > >>> wrong version of autoconf/automake etc.). > >>> There can be exceptions, e.g. when in GCC we update from a new version > >>> of Unicode, the regenerated ucnid.h diff can be large and > >>> uname2c.h can be huge, such that it can trigger the mailing list size > >>> limits even when the patch is compressed, see e.g. > >>> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636427.html > >>> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/636426.html > >>> But I think most configure or Makefile changes should be pretty small, > >>> usual changes shouldn't rewrite everything in those files. > >> > >> Which may then call for a policy saying "include generate script diff-= s, > >> but don't include generated data file ones"? At least on the binutils > >> side, dealing (for CI) with what e.g. opcodes/*-gen produce ought to be > >> possible by having something along the lines of "maintainer mode light= ". > > > > I'd say we should send generated files when it fits the mailing list > > limits (and possibly simply lift those limits?). > > Well, that would allow patches making it through, but it would still > severely increase overall size. I'm afraid more people than not also > fail to cut down reply context, so we'd further see (needlessly) huge > replies to patches as well. > > Additionally - how does one up front determine "fits the mailing list > limits"? My mail UI (Thunderbird) doesn't show me the size of a message > until I've actually sent it. > > > As a last resort > > do a series splitting the re-generation out (but I guess this would > > confuse the CI as well and of course for the push you want to squash > > again). > > Yeah, unless the CI would only ever test full series, this wouldn't help. > It's also imo even more cumbersome than simply stripping the generated > file parts from emails. > Massive patches need special handling either way; I wouldn't lift the mailing list limits because of this change. I'm in favor of this change for typical patches. Jason --000000000000896a12061530cba7--