From: David Blaikie <dblaikie@gmail.com>
To: Iain Sandoe <iain@sandoe.co.uk>
Cc: GCC Development <gcc@gcc.gnu.org>,
Nathan Sidwell <nathanmsidwell@gmail.com>,
Jonathan Wakely <jwakely.gcc@gmail.com>,
"ben.boeckel" <ben.boeckel@kitware.com>,
"chuanqi.xcq" <yedeng.yd@linux.alibaba.com>
Subject: Re: Naming flag for specifying the output file name for Binary Module Interface files
Date: Fri, 9 Dec 2022 09:43:23 -0800 [thread overview]
Message-ID: <CAENS6EswYDJ0HgZef+AiGdq20ZTCbSWhaQCw+=tjw-44WaeCEQ@mail.gmail.com> (raw)
In-Reply-To: <F8B613A8-68B9-49F4-8E59-F274754F5587@sandoe.co.uk>
Thanks Iain for the summary/thanks everyone for the discussion!
On Fri, Dec 9, 2022 at 9:33 AM Iain Sandoe <iain@sandoe.co.uk> wrote:
>
> Hello all.
>
> > On 9 Dec 2022, at 01:58, chuanqi.xcq <yedeng.yd@linux.alibaba.com> wrote:
> >
> > It looks like `-fmodule-file` is better from the discussion. So let's take it. Thanks for everyone here
>
> So FAOD (after this discussion) Chuanqi's current patchset implements the following in clang:
>
> -fmodule-output
>
> - this causes the BMI to be saved in the CWG with the basename of the source file and a suffix of .pcm.
>
> -fmodule-output=<path>
>
> - this causes the BMI to be saved at the path specified.
>
> ===
>
> These facilities support build systems that do not use the P1184 interface to map between module names and paths.
>
> cheers
> Iain
>
> >
> > Thanks,
> > Chuanqi
> > ------------------------------------------------------------------
> > From:Nathan Sidwell <nathan@acm.org>
> > Send Time:2022年12月8日(星期四) 01:00
> > To:Iain Sandoe <iain@sandoe.co.uk>; GCC Development <gcc@gcc.gnu.org>
> > Cc:Jonathan Wakely <jwakely.gcc@gmail.com>; chuanqi.xcq <yedeng.yd@linux.alibaba.com>; David Blaikie <dblaikie@gmail.com>; ben.boeckel <ben.boeckel@kitware.com>
> > Subject:Re: Naming flag for specifying the output file name for Binary Module Interface files
> >
> > On 12/7/22 11:58, Iain Sandoe wrote:
> > >
> > >
> > >> On 7 Dec 2022, at 16:52, Nathan Sidwell via Gcc <gcc@gcc.gnu.org> wrote:
> > >>
> > >> On 12/7/22 11:18, Iain Sandoe wrote:
> > >>
> > >>> I think it is reasonable to include c++ in the spelling, since other languages supported by
> > >>> GCC (and clang in due course) have modules.
> > >>
> > >> I disagree (about the reasonableness part). Other languages have modules, true, but if they want to name the output file, why not have the same option spelling?
> > >>
> > >> I.e. why are we considering:
> > >>
> > >> $compiler -fc++-module-file=bob foo.cc
> > >> $compiler -ffortran-module-file=bob foo.f77
> > >>
> > >> The language is being selected implicitly by the file suffix (or explictly via -X$lang). There's no reason for some other option controlling an aspect of the compilation to rename the language. We don't do it for language-specific warning options, and similar. (i.e. no -f[no-]c++-type-aliasing vs -fc-type-aliasing, nor -Wc++-extra vs -Wc-extra[*]
> > >
> > > Fair points.
> > >
> > > Unfortunately (in case it has not already been mentioned in this thread) ‘-fmodule-file=‘ is already taken and it means an input, not an output. So, whatever we choose it needs to be distinct from that.
> >
> > Yes, that's why I suggested -fmodule-output=
> >
> > nathan
> >
> > --
> > Nathan Sidwell
>
next prev parent reply other threads:[~2022-12-09 17:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 21:03 David Blaikie
2022-12-07 0:35 ` Nathan Sidwell
2022-12-07 1:45 ` Jonathan Wakely
2022-12-07 2:30 ` chuanqi.xcq
2022-12-07 15:23 ` Jonathan Wakely
2022-12-07 15:45 ` ben.boeckel
2022-12-07 16:18 ` Iain Sandoe
2022-12-07 16:29 ` ben.boeckel
2022-12-07 16:52 ` Nathan Sidwell
2022-12-07 16:58 ` Iain Sandoe
2022-12-07 17:00 ` Nathan Sidwell
2022-12-09 1:58 ` chuanqi.xcq
2022-12-09 17:33 ` Iain Sandoe
2022-12-09 17:43 ` David Blaikie [this message]
2022-12-12 14:30 ` Nathan Sidwell
2022-12-13 3:10 ` chuanqi.xcq
2022-12-13 15:56 ` David Blaikie
2022-12-14 9:56 ` chuanqi.xcq
2022-12-14 18:39 ` David Blaikie
2022-12-14 22:29 ` Nathan Sidwell
2022-12-15 5:58 ` chuanqi.xcq
2022-12-15 7:37 ` Iain Sandoe
2022-12-15 13:21 ` ben.boeckel
2022-12-07 16:43 ` Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAENS6EswYDJ0HgZef+AiGdq20ZTCbSWhaQCw+=tjw-44WaeCEQ@mail.gmail.com' \
--to=dblaikie@gmail.com \
--cc=ben.boeckel@kitware.com \
--cc=gcc@gcc.gnu.org \
--cc=iain@sandoe.co.uk \
--cc=jwakely.gcc@gmail.com \
--cc=nathanmsidwell@gmail.com \
--cc=yedeng.yd@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).