From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by sourceware.org (Postfix) with ESMTPS id 46D523858425; Fri, 23 Dec 2022 10:36:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 46D523858425 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-1433ef3b61fso5514680fac.10; Fri, 23 Dec 2022 02:36:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2iyVhDsnxaHQ6uES/frA+/I3ve7UMnoMJH/FU/+Re2s=; b=SMVIKMbZQ6yIGtFY2QFrWjn4eFiJnYy7tG8Jgd2u0Qsv02VfWFo70t1U8FEZIuFsgB ta5fafS/AlzHZCjfJD5kybjrkYDpPkKBdw+dj+XSRAc/Iee7lXyztH43jMPNCRgEhwh6 09gIrAdzpyiYty+nqG3yZG1wDEN5HtzRa8uaRrRk+Amly1vf9rw3vOQhB3VmDHpCDvHp iC7ZLSg2sCw4rFNsb+I2PaF8sQ1aTRly5B2BZaHBu6pBjhTkTnO200Drxxtx9A+yJA/B QQgK2MrdTN1Kpzt5WHF0wL9pPzAvttA6jfD/Zl3m66b+iuyscIw9BNyWVQmnEeshtdQf 3Wog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2iyVhDsnxaHQ6uES/frA+/I3ve7UMnoMJH/FU/+Re2s=; b=YMF+ZeMSXRKoDg8ER42y6JfbMhqqaby2RR8edMcP2sIV6m/VA91L5HxYrLIyK70xya ieOdilODo0yf/QluhwwdshRiP03G8U5VsxEupmNP52mhPCvSU4YyPP3fNPqiftjlK1va E0UfK5YxGT8PcR3TJiFAILyBnOqncUeNZpn2fkX+7J6BRuzsVk6nfhZZ4YCr5W0GhQY+ VXJ45jN2IewIA2Qiq5+V3IFZtSFsKynYoy+ix+7QW6R4VJy5Q/C4bsR8iKl/HqQWLOzf m25haLDtRMPtifb4cptbNISSAUmxDAjPbBBU3JAvY1CSCovmAlOmcnOQSskwfeScgjM4 5oCQ== X-Gm-Message-State: AFqh2kpXUqLXhO564JtpzE36NTFTLDhpOXFheney4FqKxXS3VoQ8fWFa bU+NF4MTSBITuArVKQhcMe0X/PZTx1ts048g8Z8= X-Google-Smtp-Source: AMrXdXvEQBrKIl8aut10Yf8j+C1KBhMyNb5iZ4UiKhv3Y9u+/ePZGCMpaoV975SKyaifqsDWBadHpOpp4DOV/h97ds0= X-Received: by 2002:a05:6870:578f:b0:14f:ac78:ac7f with SMTP id i15-20020a056870578f00b0014fac78ac7fmr19180oap.112.1671791766885; Fri, 23 Dec 2022 02:36:06 -0800 (PST) MIME-Version: 1.0 References: <639FE88D.7090408@gmail.com> <7cb45ab2-cc6e-c502-5592-51ffabcbc6f8@codeweavers.com> <63A3DF0E.1050902@gmail.com> In-Reply-To: <63A3DF0E.1050902@gmail.com> From: NightStrike Date: Fri, 23 Dec 2022 05:36:03 -0500 Message-ID: Subject: Re: testsuite under wine To: jcb62281@gmail.com Cc: Jacek Caban , fortran@gcc.gnu.org, Eric Pouech , "gcc@gcc.gnu.org" , dejagnu@gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Dec 21, 2022 at 11:37 PM Jacob Bachmeyer wrote: > > NightStrike wrote: > > [...] > > Second, the problems with extra \r's still remain, but I think we've > > generally come to think that that part isn't Wine and is instead > > either the testsuite or deja. So I'll keep those replies to Jacob's > > previous message. > > > > Most likely, it is a combination of the MinGW libc (which emits "\r\n" > for end-of-line in accordance with Windows convention) and the kernel > terminal driver (which passes "\r" and translates "\n" to "\r\n" in > accordance with POSIX convention). Wine, short of trying to translate > "\r\n" back to "\n" in accordance with POSIX conventions (and likely > making an even bigger mess---does Wine know if a handle is supposed to > be text or binary?) cannot really fix this, so the testsuite needs to > handle non-POSIX-standard line endings. (The Rust tests probably have > an outright bug if the newlines are being duplicated.) You may be onto something here. I ran wine under script as `script -c "wine64 ./a.exe" out` (thanks, Arsen!), and it had the same extra \r prepended to the \r\n. I was making the mistake previously of running wine manually and capturing it to a file as `wine64 ./a.exe > out`, which as several have pointed out in this thread, that would disable the quirk, so of course it didn't reveal any problems. I'm behind, but I'll catch up to you guys eventually :) So at least we know for sure that this particular instance of extra characters is coming from Wine. Maybe Wine can be smart enough to only translate \n into \r\n instead of translating \r\n into \r\r\n. Jacek / Eric, comments here? I'm happy to try another patch, the first one was great. Rust is getting \r\r\n\n (as opposed to \r\n\r\n), so... yeah. Could be the rust test, could be the rust frontend, could be another weird Wine interaction.