From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by sourceware.org (Postfix) with ESMTPS id AE26B384475D for ; Mon, 20 Feb 2023 14:54:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE26B384475D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-f178.google.com with SMTP id s12so973507qtq.11 for ; Mon, 20 Feb 2023 06:54:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:reply-to:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IVfiffy0UZMeeA/BOxFzz7j6P5wM42lr0nzpyYt0ffk=; b=75WZk4AwZOiffcXFdGEgK4/Wr5j6lvHzCj06YrZFhMw7Z+VXyz7N9fj0L/uut6FE5q CFtOXpDrKddFhF8U5f83hVBh0mP+hFnApAYgY8Ih37yCymC15AZS+/uruKgb95pzfmpD g2DA8pnYiugEWD3XkAgzb1HbE2HprXPj0hUpH2hec0pzi5Q55Su8+3Fo1VoctOFmz4cd EEUGmGByjJEdlkgaQFlJke8vP06gbWvi/Ktg+n3hhIhf6TYWbH4T0d50B3OoWhkGvZI/ OO2TYkV+VUvL+mAXYorzRbrhvtdQ+OMdbw1u31kyOE1o2JGbNwiOxGlsSsYS5YRgV94t ytCw== X-Gm-Message-State: AO0yUKVTH49yhCdpHJpokqw3vMLE8/IBE8KA1Vq6t2Rqdo8Fyd1p4vzX K9hQmNUgnd0syjo0wqDbLkH4x6eo22M= X-Google-Smtp-Source: AK7set+zAKQrT1CQXsSttyNwwAAsda6LG0u4mLNJfJ3a7rkXt+fRPXbhkCNe0ny2q6i1xw7acWOEJQ== X-Received: by 2002:a05:622a:1a06:b0:3bd:1081:b939 with SMTP id f6-20020a05622a1a0600b003bd1081b939mr1838677qtb.0.1676904851470; Mon, 20 Feb 2023 06:54:11 -0800 (PST) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id 200-20020a3705d1000000b0073b929d0371sm8854089qkf.4.2023.02.20.06.54.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 06:54:11 -0800 (PST) Received: by mail-yb1-f177.google.com with SMTP id j67so1965568yba.10 for ; Mon, 20 Feb 2023 06:54:10 -0800 (PST) X-Received: by 2002:a5b:f8a:0:b0:900:c3fd:a075 with SMTP id q10-20020a5b0f8a000000b00900c3fda075mr454041ybh.654.1676904850494; Mon, 20 Feb 2023 06:54:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Reply-To: joel@rtems.org From: Joel Sherrill Date: Mon, 20 Feb 2023 08:54:00 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: MicroBlaze symver attribute support To: Vincent Fazio Cc: gcc@gcc.gnu.org, eager@eagercon.com Content-Type: multipart/alternative; boundary="000000000000ef9d5405f522d551" X-Spam-Status: No, score=-3031.4 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000ef9d5405f522d551 Content-Type: text/plain; charset="UTF-8" On Mon, Feb 20, 2023 at 7:56 AM Vincent Fazio via Gcc wrote: > Michael, all, > > Regarding: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101766 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102110 > > If I understand correctly, since the GCC MicroBlaze targets generate ELF > images, it would seem there's no technical reason why `__attribute__ > ((symver ...))` cannot be supported? > > The issue seems to be that the MicroBlaze targets in config.gcc do not > include elfos.h > https://github.com/gcc-mirror/gcc/blob/master/gcc/config.gcc#L2369 > > Which defines `ASM_OUTPUT_SYMVER_DIRECTIVE` > https://github.com/gcc-mirror/gcc/blob/master/gcc/config/elfos.h#L259 > > Which is necessary for > https://github.com/gcc-mirror/gcc/blob/master/gcc/varasm.cc#L6260 > > Changing the targets to include elfos.h leads to a number of conflicts with > the target specific header (config/microblaze/microblaze.h). > > Should `ASM_OUTPUT_SYMVER_DIRECTIVE` be copied into > config/microblaze/microblaze.h or should the MicroBlaze targets and header > be reworked to support elfos.h? > IMO reworked to include elfos.h. During the RTEMS port, we noticed that some quirks on the microblaze gcc because it isn't using elfos.h. This likely will mean it will be updated as a side-effect of normal GCC maintenance instead of being an odd singleton which doesn't share. > > I'm asking because I've seen a number of projects run into this issue (xz, > elfutils, libfuse, libkcapi, cryptsetup). > And RTEMS. --joel > > Thanks, > -Vincent > --000000000000ef9d5405f522d551--