From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 792D23858D33 for ; Thu, 16 Feb 2023 07:57:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 792D23858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x12f.google.com with SMTP id bi36so1739566lfb.8 for ; Wed, 15 Feb 2023 23:57:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QOUTnBu0HpX4Dd0sFjhCeh8UKocK0UBicnQVWONYPBo=; b=T4uDdzLpClxNpOSyw8Kd6A5vE++hIklNwPRhKWj+HKQMnXp6q4MFLk4q5anWtY++FF Vs/d0dEYyGlS7hzCAQghvK4Ny2Ik7pZA6jANOCEcz6wfDHzSfc3hKDJg5h3FLuy/uiGL +0WRRIuWaXM1xsW+OOyXiwbLaZOW983BiTyeDvz8U/Icjeyi/3308vbmgSngwvXmENCm RTlEHKhxhIRTqYy8I4P6NFV7rMA4znzd5yIrIIruYn0PDSLRHhwz0Cdct39EloWxfYrx +KtWbamPfuw6NTgum87Bhh+g6JJR7O9aDJGQHe3BucA5E9T0Ws9aiqLsWUJ6EWdzRPJX TDsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QOUTnBu0HpX4Dd0sFjhCeh8UKocK0UBicnQVWONYPBo=; b=LBHECtKnZ0Se4I2ocqYguLKdjj8Exov1dBxW1tmiWs5XNrXE2QhrLKMnhXYST+xLIW 6HlDdq6szreXjLoib28lTJauzI0X7Pg0HU5CNHwyeavoRs7ITQ+moMvBlKJeJ9uqJFa3 UFOfwSI+uOnxVcYyJKUUmmRAg/IjVwSe4iQrAjI+JNf78gsf/zgL/X67Z53wOxUBU5op EHv0SmA4rpM2DjBS9PajvsK/hhoBoZSmjH60Xiv6ow2jOJ76d9GxEtJtx2xQQSwH/vtZ vjZk7vGQwhzrJ0ISoHEmHSHlKMoPGduLaZQQWOdfvlDJcD9O8EXp+RIijM9VD1C0BP6p wTDg== X-Gm-Message-State: AO0yUKXh72tzx9T33ugoC4mnleR0UXCQUsumGN1q7rh0YzbZp3b5wi8o NPZaOolb+eA9+kfu5y1Vipz3IFiSXHPxjast+OY= X-Google-Smtp-Source: AK7set+g+Aast/o/O600bsOgILdGLD+nKXqr4SgtQSiPdJbZfUnzW/jMKycdleXwGg5Jh6r4WgVTsvPcLWPPxmR6lv0= X-Received: by 2002:a05:6512:3da9:b0:4d5:ca32:6ed2 with SMTP id k41-20020a0565123da900b004d5ca326ed2mr727539lfv.0.1676534277992; Wed, 15 Feb 2023 23:57:57 -0800 (PST) MIME-Version: 1.0 References: <009a0ac2-0626-c21c-c0f9-4d2e8daa66b3@redhat.com> In-Reply-To: <009a0ac2-0626-c21c-c0f9-4d2e8daa66b3@redhat.com> From: Richard Biener Date: Thu, 16 Feb 2023 08:57:45 +0100 Message-ID: Subject: Re: get_range_query vs NULL argument To: Andrew MacLeod Cc: Andrew Pinski , Aldy Hernandez , GCC Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Feb 15, 2023 at 11:31 PM Andrew MacLeod via Gcc wrote: > > > On 2/15/23 14:50, Andrew Pinski wrote: > > Hi, > > While fixing PR 108354, I came across that > > ssa_name_has_boolean_range calls get_range_query with cfun as the > > argument but sometimes while in IPA passes cfun is currently nullptr. > > The question should we check the argument before calling > > get_range_query or is it a valid thing to call it with a nullptr (and > > have it return global_ranges in that case)? > > That might be ok... personally I see nothing wrong with: > > diff --git a/gcc/value-query.h b/gcc/value-query.h > index 63878968118..2d7bf8fcf33 100644 > --- a/gcc/value-query.h > +++ b/gcc/value-query.h > @@ -140,7 +140,7 @@ get_global_range_query () > ATTRIBUTE_RETURNS_NONNULL inline range_query * > get_range_query (const struct function *fun) > { > - return fun->x_range_query ? fun->x_range_query : &global_ranges; > + return (fun && fun->x_range_query) ? fun->x_range_query : &global_ranges; > } > > // Query the global range of NAME in function F. Default to cfun. > > > The client is probably going to do that anyway. But if there's no 'fun', what is 'global_ranges' initialized for? Or is 'global_ranges' usable in IPA context? > Aldy? > >