public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Andrew Haley <aph@redhat.com>
Cc: Thomas Koenig <tkoenig@netcologne.de>,
	gcc mailing list <gcc@gcc.gnu.org>,
		"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Subject: Re: Putting an all-zero variable into BSS
Date: Mon, 08 Apr 2019 09:33:00 -0000	[thread overview]
Message-ID: <CAFiYyc0c+CeOZQQRi=uh-4tt4-u4ckq6vnMsz1wusxJnY=ft0Q@mail.gmail.com> (raw)
In-Reply-To: <db3a5e93-0400-6631-cbcd-af35a2aafd59@redhat.com>

On Mon, Apr 8, 2019 at 10:38 AM Andrew Haley <aph@redhat.com> wrote:
>
> On 4/7/19 5:03 PM, Thomas Koenig wrote:
> > Hi Richard,
> >
> >> I don't know without looking, but I'd start at assemble_variable in varasm.c.
> >
> > Thanks.  I've done that, and this is what a patch could look like.
> > However, I will not have time to formally submit this until next
> > weekend.
> >
> > In the meantime, comments are still welcome :-)
>
> Did you look at
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83100
>
> This was the change that caused this behaviour.

Actually that just changed the behavior for DECL_COMMONs
which may of course match the fortran case here in case you
bisected this.  OTOH DECL_COMMONs are tentative and
do not have an initializer (and not go to .rodata either).

Richard.

>
> --
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

  reply	other threads:[~2019-04-08  9:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02 22:02 Thomas Koenig
2019-04-02 22:11 ` Andreas Schwab
2019-04-03 16:45   ` Thomas Koenig
2019-04-03 21:02     ` Andreas Schwab
2019-04-04 19:53       ` Thomas Koenig
2019-04-05 10:15         ` Richard Biener
2019-04-06 13:59           ` Thomas Koenig
2019-04-07  9:26             ` Richard Biener
2019-04-07 16:03               ` Thomas Koenig
2019-04-08  8:38                 ` Andrew Haley
2019-04-08  9:33                   ` Richard Biener [this message]
2019-04-08  9:40                     ` Richard Biener
2019-04-17 15:14                       ` Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFiYyc0c+CeOZQQRi=uh-4tt4-u4ckq6vnMsz1wusxJnY=ft0Q@mail.gmail.com' \
    --to=richard.guenther@gmail.com \
    --cc=aph@redhat.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc@gcc.gnu.org \
    --cc=tkoenig@netcologne.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).