From: Richard Guenther <richard.guenther@gmail.com>
To: Basile Starynkevitch <basile@starynkevitch.net>
Cc: gcc@gcc.gnu.org
Subject: Re: adding destroyable objects into Ggc
Date: Sun, 23 Oct 2011 13:50:00 -0000 [thread overview]
Message-ID: <CAFiYyc1aNENv2X2-A86bpSG-9YoAooTUSCvmrJRxPUhV-uRfeg@mail.gmail.com> (raw)
In-Reply-To: <20111021225635.d0b5fe0b81daeb82a503dafd@starynkevitch.net>
On Fri, Oct 21, 2011 at 10:56 PM, Basile Starynkevitch
<basile@starynkevitch.net> wrote:
> On Fri, 21 Oct 2011 10:43:29 +0200
> Richard Guenther <richard.guenther@gmail.com> wrote:
>> So there is no inherent limitation with the GGC machinery.
>
> There are at least some annoyances:
>
> If a C++ class is GTY-ed, or is pointed by a field inside a GTY-ed struct, and if
> that class contains for example a PPL data (or simply if a GTY-ed struct contains a PPL
> data) we need to have the PPL destuctor invoked when Ggc release the struct.
Same as in C. If you have a pointer to malloc() memory in a GTY-ed
struct it will leak.
Which is why in the GTY world there is a dont-do-that rule, instead
you need to put
your malloc memory in GC space, too.
Thus, not a C++ limitation, but a general issue with mixing GC and
non-GC things.
Now complicated things more and make the malloc region point to GC memory again
and you'll see why generally mixing GC/non-GC things isn't the very best idea.
> To be more specific, if you want to associate trees with PPL coefficients (in a way
> visible to several passes, so using Ggc), you will declare in C
>
> struct GTY (()) treewithcoef_st {
> tree tr;
> ppl_Coefficient_t co;
> };
>
> it will leak, because <ppl_c.h> requires that when the field co is no more useful, it
> should be released with
> ppl_delete_Coefficient (p->co);
> [since actually ppl_Coefficient_t is an opaque non null pointer to some C++ class of PPL]
Don't do that then.
Richard.
next prev parent reply other threads:[~2011-10-23 10:30 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 16:35 Basile Starynkevitch
2011-10-18 16:43 ` Duncan Sands
2011-10-18 16:53 ` Basile Starynkevitch
2011-10-18 17:11 ` Ian Lance Taylor
2011-10-18 17:14 ` Gabriel Dos Reis
2011-10-18 17:20 ` Basile Starynkevitch
2011-10-18 17:36 ` Ian Lance Taylor
2011-10-18 17:41 ` Basile Starynkevitch
2011-10-18 17:50 ` Ian Lance Taylor
2011-10-18 17:53 ` Basile Starynkevitch
2011-10-18 18:03 ` Jonathan Wakely
2011-10-18 18:11 ` Ian Lance Taylor
2011-10-18 19:41 ` Basile Starynkevitch
2011-10-18 20:52 ` Gabriel Dos Reis
2011-10-18 19:50 ` Gabriel Dos Reis
2011-10-18 23:11 ` Basile Starynkevitch
2011-10-19 0:49 ` Jonathan Wakely
2011-10-18 19:46 ` Gabriel Dos Reis
2011-10-19 6:04 ` Chiheng Xu
2011-10-19 6:08 ` Basile Starynkevitch
2011-10-19 6:43 ` Chiheng Xu
2011-10-19 6:12 ` Gabriel Dos Reis
2011-10-19 6:17 ` Basile Starynkevitch
2011-10-19 6:22 ` Chiheng Xu
[not found] ` <20111019080021.4e1acb3687fc8ceacc2fd7a3@starynkevitch.net>
[not found] ` <CAAiZkiB-aXfE8MyY_S6YvecdxgsBnuBHp3JDWx4kirVkQx8w+A@mail.gmail.com>
2011-10-19 7:41 ` Gabriel Dos Reis
2011-10-19 7:43 ` Basile Starynkevitch
2011-10-19 12:14 ` Gabriel Dos Reis
2011-10-19 13:31 ` Duncan Sands
2011-10-19 22:19 ` Jonathan Wakely
2011-10-19 15:06 ` David Malcolm
2011-10-20 6:03 ` Lawrence Crowl
2011-10-20 8:29 ` Basile Starynkevitch
2011-10-20 8:37 ` Marc Glisse
2011-10-20 8:38 ` Basile Starynkevitch
2011-10-20 11:57 ` Marc Glisse
2011-10-20 12:10 ` Basile Starynkevitch
2011-10-20 15:34 ` Marc Glisse
2011-10-21 9:03 ` Basile Starynkevitch
2011-10-21 12:24 ` Marc Glisse
2011-10-21 12:28 ` Richard Guenther
2011-10-21 23:53 ` Basile Starynkevitch
2011-10-22 1:31 ` Gabriel Dos Reis
2011-10-22 11:20 ` Basile Starynkevitch
2011-10-23 13:50 ` Richard Guenther [this message]
2011-10-19 15:56 ` Laurynas Biveinis
2011-10-19 16:54 ` Basile Starynkevitch
2011-10-20 8:52 ` Laurynas Biveinis
2011-10-20 12:27 ` Basile Starynkevitch
2011-10-20 12:51 ` Andrew Haley
2011-10-20 14:07 ` Basile Starynkevitch
2011-10-20 13:10 ` Duncan Sands
2011-10-20 14:52 ` Torvald Riegel
2011-10-20 15:14 ` Jonathan Wakely
2011-10-20 15:26 ` Richard Guenther
2011-10-20 17:23 ` Basile Starynkevitch
2011-10-20 18:38 ` Jonathan Wakely
2011-10-18 18:39 ` Jonathan Wakely
2011-10-18 18:48 ` Basile Starynkevitch
2011-10-18 19:42 ` Jonathan Wakely
2011-10-18 19:45 ` Basile Starynkevitch
2011-10-18 22:43 ` Gabriel Dos Reis
2011-10-18 21:24 ` Gabriel Dos Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1aNENv2X2-A86bpSG-9YoAooTUSCvmrJRxPUhV-uRfeg@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=basile@starynkevitch.net \
--cc=gcc@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).