From: Richard Biener <richard.guenther@gmail.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: GCC Development <gcc@gcc.gnu.org>,
Joern Wolfgang Rennecke <gnu@amylaar.uk>,
Claudiu Zissulescu <claziss@synopsys.com>
Subject: Re: GCC arc port defaults to -fcommon
Date: Wed, 7 Jul 2021 11:56:12 +0200 [thread overview]
Message-ID: <CAFiYyc3Lcw5NbMiERTyGiLNMOXTvLAOnmtxtp1r-nz9TrWNjiA@mail.gmail.com> (raw)
In-Reply-To: <875yxmbiu3.fsf@oldenburg.str.redhat.com>
On Wed, Jul 7, 2021 at 11:00 AM Florian Weimer via Gcc <gcc@gcc.gnu.org> wrote:
>
> It seems to me that the arc port still defaults to -fcommon, presumably
> due to this in gcc/common/config/arc/arc-common.c:
>
> static void
> arc_option_init_struct (struct gcc_options *opts)
> {
> opts->x_flag_no_common = 255; /* Mark as not user-initialized. */
>
> /* Which cpu we're compiling for (ARC600, ARC601, ARC700, ARCv2). */
> arc_cpu = PROCESSOR_NONE;
> }
>
> Is that really necessary? Is -fno-common broken on arc?
It seems arc has -fcommon dependent on !TARGET_NO_SDATA_SET
but it should use global_options_set.x_flag_no_common instead of
such magic value.
> I plan to switch glibc to build with -fno-common unconditionally, for
> all GCC versions and architectures, and I wonder if that would be a
> blocker.
>
> Thanks,
> Florian
>
next prev parent reply other threads:[~2021-07-07 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 8:59 Florian Weimer
2021-07-07 9:56 ` Richard Biener [this message]
2021-07-07 9:58 ` Richard Biener
2021-07-07 10:06 ` Florian Weimer
2021-07-07 12:18 ` Claudiu Zissulescu
2021-07-07 10:06 ` Claudiu Zissulescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc3Lcw5NbMiERTyGiLNMOXTvLAOnmtxtp1r-nz9TrWNjiA@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=claziss@synopsys.com \
--cc=fweimer@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=gnu@amylaar.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).