From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com
 [IPv6:2a00:1450:4864:20::631])
 by sourceware.org (Postfix) with ESMTPS id 5E5423857C44
 for <gcc@gcc.gnu.org>; Wed,  7 Jul 2021 09:56:24 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E5423857C44
Received: by mail-ej1-x631.google.com with SMTP id ga42so2330576ejc.6
 for <gcc@gcc.gnu.org>; Wed, 07 Jul 2021 02:56:24 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=MaVfRD8LBthirGwrl0ODUmjRMpVSGJMC8rLSd8oWkHc=;
 b=OgCnxQb10o6WuJ1ZgFQ+evYzdRyHwHmhKsqU2iz5XkfT+iiDdGZBXeTW2E0Es0G1YS
 69kgQ1heNAP1AcNEHrSkxH80Eq9T/7yZpReqcPkmjtVW7HC4fLL8yXzir0cGYRZUnSyQ
 SZ6dW/kAVuNm/1lwJK5Qu4E1okdBy7uVbOnsBKRz8zGBGKih2I84ZO8vgsrvtEwXH+HV
 rELH05Yr2Z7Cd0srrajwWtylzQrxnrDhPSBIHgLsZffDHDOL4ZZArhrzE1KBi6/mF3uB
 ewGn8YNEvnkfCY7kFByPYtuOaHGagu0IpsuGu9FDUeMlHucsR6Z9Xd/OLyfUwZ+4K0MN
 a/SA==
X-Gm-Message-State: AOAM530ExG0IOI3N2roSqb8p6noDOrjPGKRONj/hTDGgCi75ahE8uPh5
 TQudCS3WqUDuSA+LPzw8QQ96KQs51Pl7KuAPeu8=
X-Google-Smtp-Source: ABdhPJxBM+/29D35Zdkw1x2O4U2Y69VG4A6lQVYSUO9NtMJtc+oeWC6dRLPQLUIKM2DwhsNcVAFqADxJfHC9z+y2kB0=
X-Received: by 2002:a17:907:3f96:: with SMTP id
 hr22mr15423633ejc.129.1625651783500; 
 Wed, 07 Jul 2021 02:56:23 -0700 (PDT)
MIME-Version: 1.0
References: <875yxmbiu3.fsf@oldenburg.str.redhat.com>
In-Reply-To: <875yxmbiu3.fsf@oldenburg.str.redhat.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Wed, 7 Jul 2021 11:56:12 +0200
Message-ID: <CAFiYyc3Lcw5NbMiERTyGiLNMOXTvLAOnmtxtp1r-nz9TrWNjiA@mail.gmail.com>
Subject: Re: GCC arc port defaults to -fcommon
To: Florian Weimer <fweimer@redhat.com>
Cc: GCC Development <gcc@gcc.gnu.org>, Joern Wolfgang Rennecke <gnu@amylaar.uk>,
 Claudiu Zissulescu <claziss@synopsys.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc mailing list <gcc.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc>,
 <mailto:gcc-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <mailto:gcc-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc>,
 <mailto:gcc-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Jul 2021 09:56:25 -0000

On Wed, Jul 7, 2021 at 11:00 AM Florian Weimer via Gcc <gcc@gcc.gnu.org> wrote:
>
> It seems to me that the arc port still defaults to -fcommon, presumably
> due to this in gcc/common/config/arc/arc-common.c:
>
> static void
> arc_option_init_struct (struct gcc_options *opts)
> {
>   opts->x_flag_no_common = 255; /* Mark as not user-initialized.  */
>
>   /* Which cpu we're compiling for (ARC600, ARC601, ARC700, ARCv2).  */
>   arc_cpu = PROCESSOR_NONE;
> }
>
> Is that really necessary?  Is -fno-common broken on arc?

It seems arc has -fcommon dependent on !TARGET_NO_SDATA_SET
but it should use global_options_set.x_flag_no_common instead of
such magic value.

> I plan to switch glibc to build with -fno-common unconditionally, for
> all GCC versions and architectures, and I wonder if that would be a
> blocker.
>
> Thanks,
> Florian
>