From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by sourceware.org (Postfix) with ESMTPS id 47F2B385780D; Fri, 27 Nov 2020 10:13:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 47F2B385780D Received: by mail-qk1-x729.google.com with SMTP id b144so3832571qkc.13; Fri, 27 Nov 2020 02:13:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uYRB0crGMIUUoKdfXscbPmPw7E5Cpv/h6ynnaC4+8fg=; b=o7SnJ5bwmOsy628JUqhyHX2qYrYkdaUGFLCvCo2qvR1KOtR5B7aIzo7omjjJvcf/hF IhqI3mRzeKp7zoh2nEmIENzAHm8j358alnhbjuKoe9OMjMGvgCDboXZNvNruTqZr4OQO za2mwPRscM2pQ90IjoCAYZEK6QQOGL1WhrUCLHDMIViypwM1QAkHe3+Fl+AbQ67dIDtL Azf3bJ6askCBMY4iCkmVFEBeBJnzCRcX7CprYUICtLkt53MtXXOORegZuydoMSmLOc4R P+LlnTFipoTNICNKj6sOroYRyn9r706Dmwz8WNfP6+J0k6wY5Nhh4mexAIDbVngQ56DD LpPQ== X-Gm-Message-State: AOAM530opEoPNq5R+lOu17Y0Zk1zdWh6WIhLRkIR6MJ1YCLULv+wDalh sRmH7nWclqHqiHqpaXBVMJiVHfktf2EXE59PFAk= X-Google-Smtp-Source: ABdhPJwS75gRz6mp8tP2sgCH/BsNO+csV5Ia8qHZ6TN93AqKCbBCvEehgkNptA4nQT+GZwMeZUmGMqUv+PqD+9lkkqA= X-Received: by 2002:a37:bf86:: with SMTP id p128mr7734158qkf.44.1606472024902; Fri, 27 Nov 2020 02:13:44 -0800 (PST) MIME-Version: 1.0 References: <20201126235057.GQ1312820@redhat.com> <0ab76443-a490-f0f7-9f1d-b7dec33cb9cc@126.com> In-Reply-To: <0ab76443-a490-f0f7-9f1d-b7dec33cb9cc@126.com> From: Ville Voutilainen Date: Fri, 27 Nov 2020 12:13:33 +0200 Message-ID: Subject: Re: [RFC] Increase libstdc++ line length to 100(?) columns To: Liu Hao Cc: Richard Biener , GCC Development , Jonathan Wakely , "libstdc++" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2020 10:13:46 -0000 On Fri, 27 Nov 2020 at 11:54, Liu Hao via Libstdc++ wrote: > As you can see, qualified names in C++ can grow up to ~100 characters quite frequently. This may > deteriorate when `typename` and `template` are sometimes required. I don't think there is > practically a set of rules which governs all cases. So, if something looks better, go for it, and > that's why I think a (suggested) 100-char limit is better than the conventional 80-char limit, which > forces another line break in front of `select_on_container_copy_construction`. I do have a general question/thought/rumination here, though. Shouldn't the paren-style and the line length of libstdc++ be mainly decided by those who develop and maintain it? It's already not written in the same style as gcc is, so tweaking that different style to better suit the need of a template-heavy C++ library perhaps should be more or less a slam dunk? :) Despite my sizable contributions to libstd++, I don't have a particularly strong opinion here. Except that, my somewhat strong opinion is "let's give Jonathan what he wants, because it helps his work". ;)