From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ville.voutilainen@gmail.com>
Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com
 [IPv6:2607:f8b0:4864:20::734])
 by sourceware.org (Postfix) with ESMTPS id AA34F3854804;
 Fri, 27 Nov 2020 08:21:49 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AA34F3854804
Received: by mail-qk1-x734.google.com with SMTP id n132so3713380qke.1;
 Fri, 27 Nov 2020 00:21:49 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=62lTnuGjInbWHHZsqCXSstKtET5hXwff5xQZOGodaLM=;
 b=Jz8eteMuk6smx5d9FOi2iJkNYEDd4CtzbQ0zmxY6sUri30HpUIJylWbqVHWwYrsTCp
 0EeJyF3Kk6LAtR/ENs/GUz6YunvZJvZ4HB3kV9oe2Mu2GtvO/gxGqSwYkOeSfAfZelFv
 bjquZWbf8t4oQd7sZbHaqN3DbPhbmNaibi1LDsEaGIM1uRAMjGgFGrqMlbes4uyfB+oo
 /fG8bbQQiqFFrHwmYwbGrpXNJvD/ju1gIibskagSwfFd2XNM6ra3H6b3jVV3q4XEsWL4
 xfuaz2mt9UePE2PcA9M6ZtHISca31AHiz+mltMAYfk7Cxjw+4cFchkbn6BJ77mZNUEWw
 J+5A==
X-Gm-Message-State: AOAM532NrIp/cZBJhwwzsLUzMNA4o45xU3c83TRs259jW0BMVBvWOTyu
 hpwr49JfeAvVaQOhvbPmRYg1lqBgYUjcbVGSvUI=
X-Google-Smtp-Source: ABdhPJwOl5LVlx8E+iYTw2Lg+KMYI/olzyPLwbkk6zinhTb6eWu9ywcuECsvRX7k1CygRvZCOgGPHyLzxu/5omFxFfE=
X-Received: by 2002:a37:9e16:: with SMTP id h22mr7214737qke.481.1606465309151; 
 Fri, 27 Nov 2020 00:21:49 -0800 (PST)
MIME-Version: 1.0
References: <20201126235057.GQ1312820@redhat.com>
 <fdab2f89-f8e5-1536-7849-0074707a78cc@126.com>
 <CAFiYyc0_hewxUWEmq9POzf5EOYNCWF_z532FtdByzm6uoVO47g@mail.gmail.com>
In-Reply-To: <CAFiYyc0_hewxUWEmq9POzf5EOYNCWF_z532FtdByzm6uoVO47g@mail.gmail.com>
From: Ville Voutilainen <ville.voutilainen@gmail.com>
Date: Fri, 27 Nov 2020 10:21:38 +0200
Message-ID: <CAFk2RUahgcmxLt-PsJ0C4hgopaV-tdEMS1JJQVFWODq_koHzuA@mail.gmail.com>
Subject: Re: [RFC] Increase libstdc++ line length to 100(?) columns
To: Richard Biener <richard.guenther@gmail.com>
Cc: Liu Hao <lh_mouse@126.com>, GCC Development <gcc@gcc.gnu.org>, 
 Jonathan Wakely <jwakely@redhat.com>, "libstdc++" <libstdc++@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc mailing list <gcc.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc>,
 <mailto:gcc-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <mailto:gcc-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc>,
 <mailto:gcc-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Nov 2020 08:21:51 -0000

On Fri, 27 Nov 2020 at 10:16, Richard Biener via Libstdc++
<libstdc++@gcc.gnu.org> wrote:
> > Why not change this to:
> >
> > >                       if (present)
> > >                         ptr = gfc_build_conditional_assign_expr (
> > >                             block, present, ptr, nullarg);
> > >
> >
> > I think it looks balanced and way more comfortable, and doesn't waste much leading space.
>
> Other places use
>
>        if (present)
>          ptr = gfc_build_conditional_assign_expr
>                                   (block, present, ptr, nullarg);
>
> I prefer the ( on the next line.  The argument list can be two spaces
> indented from
> the function name or "right justified" (I think the latter looks
> visually better).

I find it easier to grok the code when the opening paren is on the
first line, I know instantly that I'm
looking at a function call. That sort of style probably fits better
the C++ code in libstdc++ than the code
in gcc, because in libstdc++ code we don't have a space before the
argument list.