From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id 5DB0F383D010 for ; Thu, 22 Jul 2021 14:34:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5DB0F383D010 Received: by mail-lf1-x136.google.com with SMTP id s13so8819346lfi.12 for ; Thu, 22 Jul 2021 07:34:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0/ouRjv6qD+Q4PxAuKqiE+bpILgcmxzl3qD/lIyqGnI=; b=R/yNyFYzybPAPNCH1HGZ5hhW4K88OaUgsbnzvYk2UNtQwLzi1UELUzxiAOxMcCukhA 9+MpTP81Myweq9KfAezHiDAnl+c1BpyXaK6dauHDaVKUgyXkQKMgVDWGWwqINh954Uxm koKYvWyzfCfP1/MrYtL3NAIveGv7Fzi3AKXu/z2uMpoZ0ivJQmwCNybFIz6xO7AgsPrp FXEGUxG9rKbahAMaw+y6BT9079Fax43bDSYDcn5z9nTBp1+f4+KU6TS4DkJvXC44ihQR WopHeFcS9qa0VY4ALGDZpa8k7ZkAY+t2QaXHPXGHuadIUUmVA71BeRwUSbmzh9Z8tMHM BnjA== X-Gm-Message-State: AOAM530fgDnFLeQJMMo0r0XmbTAdV64f9HiygRAlRsD4s7JemKp2RcKM YSIaz1hXfpwQrnm9Z+K3k0RbijHmkwxW35i7gXA= X-Google-Smtp-Source: ABdhPJwGunwp3oe8hYnqO3/xgt56EUnhgQKTL+ItuYOkijgRC6Nc7tF9f24ivee5pP1tnpLrqn8g4QUAHFm6SZyC7Ek= X-Received: by 2002:a05:6512:3697:: with SMTP id d23mr29881508lfs.552.1626964481864; Thu, 22 Jul 2021 07:34:41 -0700 (PDT) MIME-Version: 1.0 References: <2edcb737-484b-41ed-f05d-4e005cf5759f@eagercon.com> In-Reply-To: From: David Edelsohn Date: Thu, 22 Jul 2021 10:34:30 -0400 Message-ID: Subject: Re: Proper Place for builtin_define(__ELF__) To: Jeff Law Cc: Michael Eager , Joel Sherrill , GCC Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jul 2021 14:34:45 -0000 On Wed, Jul 21, 2021 at 11:09 PM Jeff Law via Gcc wrote: > > > > On 7/21/2021 6:31 PM, Michael Eager wrote: > > > > > > On 7/21/21 5:22 PM, Joel Sherrill wrote: > >> > >> > >> On Wed, Jul 21, 2021, 7:12 PM Michael Eager >> > wrote: > >> > >> On 7/21/21 2:28 PM, Joel Sherrill wrote: > >> > Hi > >> > > >> > We are in the process of porting RTEMS to the Microblaze and > >> gcc does > >> > not have __ELF__ as a predefine. In looking around at where to > >> add it, > >> > it looks like there are multiple ways to do it. We see > >> variations on > >> > the following patterns: > >> > > >> > + dbxelf.h > >> > + OS specific header in config/ > >> > + Arch/OS specific header > >> > > >> > Integrating dbxelf.h into the microblaze seems risky for one > >> simple > >> > builtin_define(). Adding it to config/microblaze/rtems.h won't > >> address > >> > the microblaze-elf target. > >> > > >> > A suggestion on where to add the builtin_predefine is > >> appreciated. > >> > >> There are very few defines for __ELF__ in the GCC target files. > >> > >> > >> Many targets include dbxelf.h from the config.gcc script. There are > >> 130 references to that file there. That seems to be where most > >> architectures get it. > > > > AFAIK, no one has ever tried to build microblaze to generate stabs, > > and I can't see a good reason why anyone would. Including dbxelf.h > > seems wrong. I don't have an answer why other arch's do that. > Avoiding dbxelf would be advisable. We're really only supporting stabs > for for aix anymore. We need to start excising dbxelf from all the > places it's being used. As requested by Richi, the GCC configuration for AIX on trunk no longer enables stabs. There still are some variables defined in xcoffout.c that would need to move to rs6000.c. GCC should be ready for stabs support to be removed. Thanks, David