From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 11CAD382FC34 for ; Wed, 1 Jun 2022 15:33:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 11CAD382FC34 Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-608-tF9mzQT6Oca4SfPE-Hd99g-1; Wed, 01 Jun 2022 11:33:35 -0400 X-MC-Unique: tF9mzQT6Oca4SfPE-Hd99g-1 Received: by mail-oi1-f199.google.com with SMTP id s7-20020aca4507000000b0032c20f7f5baso1173346oia.19 for ; Wed, 01 Jun 2022 08:33:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dqqwIzvelhlP7GjIkjhNDJ5Ax4Tv7sc4oslR4fJ3ayY=; b=U9rla/Y7S1vgovU+agYmh6D+lsa1ZppAI2e9hIdo+c+1SwboCseiQniweU/nosQEIj piNjtXiwGUw260Q+sMP5UAur9uqW3wpSZC2hRW5jZqRZMA1RiJFjSSL4riy7gabIxO/r Y7NEmhzJBHdUXFC43R66rpQEvNDE2SRQi/ltbzEYzQciOCcUtttVZVACeEnmuK5ubidd N93Uau9zwGs+x4ypuXu7MaHId9Z3EbeMogMtOb4rIsLIG/SvmtQHN7rLgOug95Q6aYMY J/GYwWa95W9fWMQC5Ky24TPzhbRTLyTtzeKZYHjFSYKprjQyE3WvztNj1YMhd8MFaTbX 08sw== X-Gm-Message-State: AOAM531/QSM7vKLEC4cbon00UchEvsSSF4rGGhE1UBfXxF2E5sh1y4Cu DDAPcBKUr66UJbvc/OpXk+yXV8HzICsSsFsAvj7u7lgWwDwLPOntV+zox1R8zlz3xPASxrNcua5 9JDNEhR1QX4l2RMA6DyNo5s0= X-Received: by 2002:a05:6870:4307:b0:f2:3989:e85f with SMTP id w7-20020a056870430700b000f23989e85fmr36801oah.265.1654097613529; Wed, 01 Jun 2022 08:33:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjI54nxLz0h/niK30nxoftYZDuNo6nN7h3S64I/QjIpWMemENfSWr55TWM/rbvK1t9O6v53CBVEKQvTn4ycR8= X-Received: by 2002:a05:6870:4307:b0:f2:3989:e85f with SMTP id w7-20020a056870430700b000f23989e85fmr36787oah.265.1654097613330; Wed, 01 Jun 2022 08:33:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aldy Hernandez Date: Wed, 1 Jun 2022 17:33:22 +0200 Message-ID: Subject: Re: is_a<> with references To: GCC Mailing List X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2022 15:33:40 -0000 Issue resolved. Typedef no longer needed. Sorry for the noise. Aldy On Wed, Jun 1, 2022 at 4:29 PM Aldy Hernandez wrote: > > Hi folks. > > I rolled our own is_a<> implementation for vrange, because it was > trivial. We needed it to work on references, and GCC's is-a.h > implementation is pointer-only. However, I now realize it confuses > gengtype when adding additional types: > > template > struct vrange_traits > { > // Default to something unusable. > typedef void range_type; > }; > > template<> > struct vrange_traits > { > typedef irange range_type; > }; > > template<> > struct vrange_traits > { > typedef frange range_type; <-- BOO! HISS! > }; > > build/gengtype \ > -S /home/aldyh/src/gcc/gcc -I gtyp-input.list -w > tmp-gtype.state > /home/aldyh/src/gcc/gcc/value-range.h:291: type `range_type' previously defined > /home/aldyh/src/gcc/gcc/value-range.h:285: previously defined here > > Can some gengtype guru offer guidance? > > Thanks. > Aldy