From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 582253857C6E for ; Fri, 29 Jul 2022 11:51:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 582253857C6E Received: from mail-oa1-f69.google.com (mail-oa1-f69.google.com [209.85.160.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-176-xZ9-kfoRO0CluXoJOaHMLw-1; Fri, 29 Jul 2022 07:51:12 -0400 X-MC-Unique: xZ9-kfoRO0CluXoJOaHMLw-1 Received: by mail-oa1-f69.google.com with SMTP id 586e51a60fabf-10e7667b972so1820495fac.12 for ; Fri, 29 Jul 2022 04:51:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2bH+K+qAJiD+xAuOT3tvZm7ue7ckyKTtNJ2GnmdM7u0=; b=kPU0ImETeRtWWTB/Jl05UAHfs3IooR0mw+oVWvhd/ZSXUF015EcG2H0gNX4f1NqZDy DOGy55oRLGGSdqPMLYGqP9HAhcgs8a5fqciIHufg8LYO2srZMSGhCRABb1O6pl0/FHR+ dQEM++kOEq6h2NijC9Ey7enoYWHym/lLL5Pcok3o0wTa67Ry3ocBCk1zJjY7Hsc5ooAU +T4TMrHdlNqXo3IGzqDevtB//nDGhP3ODNlAHX66AenzeIgjy+AvVnLgTQdcdKz6AoM6 xatKNWQung5mo87XnbhXjzjuuq+5nRfreBKCQc2kxykqzD6RCA5GRPBdg2M95r1drQuK i0sQ== X-Gm-Message-State: AJIora/gmDG9P9e8TIMfRgYVcU++DtCkEvSvtrwPX94fBAExwMv9Y0Sq XyieggElxL1EwD6RDvU0fUXwWeWiCAnF10HQkLZCZquepruOpx163Za3DY1rZZpNnSw5wWd21+w Vk3N346uAzVEHSngbC9mauVA= X-Received: by 2002:a05:6830:108c:b0:61c:cfcb:f436 with SMTP id y12-20020a056830108c00b0061ccfcbf436mr1312288oto.276.1659095471336; Fri, 29 Jul 2022 04:51:11 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tmK19PV9oBmEwxtKAcQIBMGEo8Fhtn00bZufFbIPUNhABLwPwvSrxiw8TyhEct7zHlRHC/C4rwoIjErjfckYA= X-Received: by 2002:a05:6830:108c:b0:61c:cfcb:f436 with SMTP id y12-20020a056830108c00b0061ccfcbf436mr1312282oto.276.1659095471131; Fri, 29 Jul 2022 04:51:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aldy Hernandez Date: Fri, 29 Jul 2022 13:51:00 +0200 Message-ID: Subject: Re: spaceship_replacement cannot see through simplified set of FP conditionals To: Jakub Jelinek Cc: GCC Mailing List , "MacLeod, Andrew" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jul 2022 11:51:14 -0000 Sweeeet! Would you like me to XFAIL the test or leave it as a failure? Thanks. Aldy On Fri, Jul 29, 2022 at 1:50 PM Jakub Jelinek wrote: > > On Fri, Jul 29, 2022 at 01:40:12PM +0200, Aldy Hernandez wrote: > > With my upcoming patch enabling floating point VRP, > > g++.dg/opt/pr94589-2.C is failing: > > > > https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598788.html > > > > The problem is that phiopt no longer sees the following snippet, > > because we have folded away the final conditional as true: > > > Could someone give me a hand here? Can spaceship_replacement easily be > > adapted to handle this case, or should we be simplifying this > > elsewhere? > > Leave it to me, once you commit, file a PR and I'll work on it. > > Jakub >