From: Aldy Hernandez <aldyh@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc@gcc.gnu.org, amacleod@redhat.com
Subject: Re: are most floating point cases in tree_call_nonnegative_warnv_p() wrong for HONOR_NANS?
Date: Sun, 13 Nov 2022 19:49:04 +0100 [thread overview]
Message-ID: <CAGm3qMWx-jQH912eNAhU9s1Yo18OR_=_ih6jnFWAZMTqu1OeKQ@mail.gmail.com> (raw)
In-Reply-To: <2afa474d-79a0-c978-f881-bd71f8016585@redhat.com>
I suppose most of the calls to tree_expr_nonnegative_p that apply to
floats in match.pd and tree-ssa-math-opts.cc are guarded by
!HONOR_NANS || tree_expr_nonnegative_p. Still feels kinda delicate...
Aldy
On Sun, Nov 13, 2022 at 4:56 PM Aldy Hernandez <aldyh@redhat.com> wrote:
>
> Based on discussions in the last few weeks, aren't most of the cases in
> tree_call_nonnegative_warnv_p() wrong when honoring NANS?
>
> For example:
> CASE_CFN_ACOS:
> CASE_CFN_ACOS_FN:
> CASE_CFN_ACOSH:
> CASE_CFN_ACOSH_FN:
> ...
> ...
> /* Always true. */
> return true;
>
> But are we guaranteed a +NAN for any NAN input? I thought we were only
> guaranteed the NAN sign for abs, copysign, assignment, etc? Similarly
> for most other cases in this function.
>
> Hmmm. I really think a good chunk of fold-const.cc should live in
> range-ops. It seems we're duplicating a lot of functionality.
> Similarly to bit-CCP as I've mentioned.
>
> Aldy
prev parent reply other threads:[~2022-11-13 18:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 15:56 Aldy Hernandez
2022-11-13 18:49 ` Aldy Hernandez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGm3qMWx-jQH912eNAhU9s1Yo18OR_=_ih6jnFWAZMTqu1OeKQ@mail.gmail.com' \
--to=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).