From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id A7D2E385828E for ; Mon, 4 Dec 2023 12:37:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A7D2E385828E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A7D2E385828E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701693443; cv=none; b=Ko5pVzT7AI+GdF+G63+9wgfn8Xs11UnHmfJex6rlkfZI9VyYClqQx3/9/MwHDvaxkAnddIMVE6ihp430AgMgHnJc7f9Cte1a+3zofz7IDLVkS/J9+7gYCPwi6TTvXhJPXZjTSM/Sm9AfyHLMJ3tPo04v82vJojUFGF0vnH6gcCs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701693443; c=relaxed/simple; bh=pKwC8dGXjXiHk7C2Grgtyq/E2YBoXHWnaBWFzDmJOf8=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=xEKhN9eVJhVma7Glm434/rhBFKp4ZCdhbFuSp95nw+SUZn1voljSvXm59Gb0M2n5aH4+aOsFQKezefMOgFxgkEuwSCSRTNLf5b5xullBYMh8ZqdvWrJ6XuIzE+HgIJz3W9X4SEYo0agKMHAIWwMOWLJnwTipJszFpbbI0PfPNjI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a06e59384b6so605917466b.1 for ; Mon, 04 Dec 2023 04:37:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701693440; x=1702298240; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/et/Qt3v0KZXzG0zNJSCTsq6o0Yj7+0JfAKSvBCfEks=; b=ZiBALoWNN1lImL3n4tGAmJSzrzEl4UEUe0oeik2UbwoXgFp2At8+8b98VdV/U1lWxf 5EHUg1kRhuu0wS55mBCsuaYAa1iR63Oo2WmDYhZzzuNdD0r2wdHlpz0cXObqJeGu4yW+ 1SIBues8Qyviitkt0cnvuuy93b/f56dlqDzhHxTYd3kouCy61F/5WfkOD9prlIQxEZ9u Iwi6YifGNwz8yy2rv523ufkr1DThU0uGuYrc/7pu20N2CQNL5di14d7PgBz8H4qHkOhq RF3HTTTcEBDl1GBNgMULKy+I1GBz4CJSCWxNYgHaAHZVNi/vTurc7XrGehROIxjcz8rI YelQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701693440; x=1702298240; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/et/Qt3v0KZXzG0zNJSCTsq6o0Yj7+0JfAKSvBCfEks=; b=mWPhEgNyA98+YeNU3kX8pO9w/NEF2Caa0M7USbPi9SBpHFbVcZtScCtZDmGekA03Up gr+0I0nuPOJd0qCPcFzpgLqFH2YBCvSbaQCUnH8dbDPO2SJfVXgauU0kW6B1NvR7R9S1 Hjt+pBXAEGuxiqB7w0fLihHeLfadxlY7vKFuJek8BGDAkKzjWTVrXjepFwEP8IpydGp1 TmubtnNCo8sRnxjgtYiEOk87URnvlzfPljqvzFkV3XV8oQFBbqKKdT0LYNCXPxRNtEM8 3qNVZFk8YPYcGEAH2GKHXQFA5lBQf6ElAE9ptZ+c1G7JT4nriyp7LlbmTSQY7eAbi8QZ PciA== X-Gm-Message-State: AOJu0Yw1Nwk/VPYLRCiEJUIc49l/Nrq2yfTmV1xY1zqXwgQUyBEBtEVU MPfCvyp2ZLPfo6aVX08Nj1p8xbNW/zUgT+35FzY= X-Google-Smtp-Source: AGHT+IE1XVo6Ot66+FswR63iCbo7uDpQH4cuXSLhk5vxjagP/NgjaYSCIDQGh8YykSRZ6cb0+80nkwNJ2sTrC6s25XA= X-Received: by 2002:a17:906:3448:b0:a01:d364:ddaf with SMTP id d8-20020a170906344800b00a01d364ddafmr2727364ejb.51.1701693440176; Mon, 04 Dec 2023 04:37:20 -0800 (PST) MIME-Version: 1.0 References: <427492706.66Ch7QCkOD@nimes> In-Reply-To: <427492706.66Ch7QCkOD@nimes> From: Jonathan Wakely Date: Mon, 4 Dec 2023 12:37:08 +0000 Message-ID: Subject: Re: contributor guidelines To: Bruno Haible Cc: gcc@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 4 Dec 2023 at 12:19, Bruno Haible wrote: > > Hi, > > I was asked to post a patch for a bugzilla PR to gcc-patches@. Two questi= ons > regarding https://gcc.gnu.org/contribute.html#testing : > > 1) This web page says: > "For a normal native configuration, running > > make bootstrap > make -k check > > from the top level of the GCC tree (not the gcc subdirectory) will > accomplish this." > > But what I get, from a git checkout of the GCC tree: > > $ make bootstrap > make: *** No rule to make target 'bootstrap'. Stop. > > I think the instructions should be amended to read: > > ./configure [options] > make bootstrap > make -k check > > Right? No, don't configure in the source directory: https://gcc.gnu.org/wiki/FAQ#configure But otherwise yes, the fact you need to configure before running make is so obvious that apparently we took it for granted :-) And it hasn't been necessary to run 'make bootstrap' for years, just running 'make' does exactly the same thing now. > > 2) That's what I did: > > $ ./configure --build=3Dx86_64-pc-linux-gnu --host=3Dx86_64-pc-linux-gnu = --target=3Dx86_64-pc-linux-gnu --prefix=3D/arch/x86_64-linux-gnu/gnu-inst-g= cc/testing --enable-shared --enable-nls --enable-threads=3Dposix --enable-_= _cxa_atexit --disable-multilib --with-as=3D/arch/x86_64-linux-gnu/gnu-inst-= binutils/2.38/bin/as --with-ld=3D/arch/x86_64-linux-gnu/gnu-inst-binutils/2= .38/bin/ld --with-gmp=3D/arch/x86_64-linux-gnu/gnu-inst-gcc/testing --with-= mpfr=3D/arch/x86_64-linux-gnu/gnu-inst-gcc/testing --with-mpc=3D/arch/x86_6= 4-linux-gnu/gnu-inst-gcc/testing --with-isl=3D/arch/x86_64-linux-gnu/gnu-in= st-gcc/testing --enable-languages=3Dc,c++,objc,obj-c++,lto,jit,fortran,go,d= ,m2 --enable-host-shared 2>&1 | tee log0 This seems unnecessarily overcomplicated. Most of those options are just restating the defaults. > $ make bootstrap 2>&1 | tee log1 > > and it fails like this: > > /GCC/gcc/host-x86_64-pc-linux-gnu/gcc/xgcc -B/GCC/gcc/host-x86_64-pc-linu= x-gnu/gcc/ -B/arch/x86_64-linux-gnu/gnu-inst-gcc/testing/x86_64-pc-linux-gn= u/bin/ -B/arch/x86_64-linux-gnu/gnu-inst-gcc/testing/x86_64-pc-linux-gnu/li= b/ -isystem /arch/x86_64-linux-gnu/gnu-inst-gcc/testing/x86_64-pc-linux-gnu= /include -isystem /arch/x86_64-linux-gnu/gnu-inst-gcc/testing/x86_64-pc-lin= ux-gnu/sys-include -fno-checking -g -O2 -O2 -g -O2 -DIN_GCC -W -Wall -= Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format -Wstrict-prototypes -= Wmissing-prototypes -Wold-style-definition -isystem ./include -fpic -mlon= g-double-80 -DUSE_ELF_SYMVER -fcf-protection -mshstk -g -DIN_LIBGCC2 -fbuil= ding-libgcc -fno-stack-protector -fpic -mlong-double-80 -DUSE_ELF_SYMVER -= fcf-protection -mshstk -I. -I. -I../../host-x86_64-pc-linux-gnu/gcc -I../..= /./libgcc -I../.././libgcc/. -I../.././libgcc/../gcc -I../.././libgcc/../in= clude -I../.././libgcc/config/libbid -DENABLE_DECIMAL_BID_FORMAT -DHAVE_CC_= TLS -DUSE_TLS -o bid128_add.o -MT bid128_add.o -MD -MP -MF bid128_add.dep= -c ../.././libgcc/config/libbid/bid128_add.c > during RTL pass: expand > ../.././libgcc/config/libbid/bid128_add.c: In function =E2=80=98__bid128_= add=E2=80=99: > ../.././libgcc/config/libbid/bid128_add.c:637:42: internal compiler error= : Aborted > 637 | else if (rnd_mode =3D=3D ROUNDING_DOWN && x_sign !=3D y_sig= n) > 0x178a410 crash_signal > ../.././gcc/toplev.cc:316 I don't see this error when building master on x86_64-pc-linux-gnu. This might be a local problem, caused by your host compiler, or the versions of GMP, MPFR, or MPC, or something else. > I am surprised to see such a failure, since x86_64-linux-gnu is the most > common platform. > > What am I supposed to do? > - Use the latest release tag (13.2.0) instead of the tip of 'master', > and test my contribution there? > - Wait a few days, do a 'git pull', and retry? > - Something else?