Re: Error when accessing git read-only archive

[Jonathan Wakely <jwakely.gcc@gmail.com>]

On Wed, 15 Sept 2021 at 14:37, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
>
> Hi David, Jonathan and all others,
>
> On Wed, 2021-09-15 09:21:04 -0400, David Malcolm via Gcc <gcc@gcc.gnu.org> wrote:
> > On Mon, 2021-09-13 at 14:03 +0100, Jonathan Wakely via Gcc wrote:
> > > On Mon, 13 Sept 2021 at 14:01, Jonathan Wakely <jwakely.gcc@gmail.com>  wrote:
> > > > On Mon, 13 Sept 2021 at 13:53, Thomas Koenig via Gcc <gcc@gcc.gnu.org> wrote:
> >
> > Summarizing some notes from IRC:
> >
> > The last commit it manages to print successfully in that log seems to
> > be:
> >   c012297c9d5dfb177adf1423bdd05e5f4b87e5ec
> > so it appears that:
> >   42e95a830ab48e59389065ce79a013a519646f1
> > is triggering the issue, and indeed
> >   https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=f42e95a830ab48e59389065ce79a013a519646f1
> > fails in a similar way, whereas other commits work.
> >
> > It appears to be due to the "ł" character in the email address of the
> > Author, in that:
> >
> > commit c012297c9d5dfb177adf1423bdd05e5f4b87e5ec
> > Author: Jan-Benedict Glaw <jbglaw@lug-owl.de>
> >
> > works, whereas:
> >
> > commit f42e95a830ab48e59389065ce79a013a519646f1
> > Author: Jan-Benedict Glaw <jbglaw@ług-owl.de>
>
> That was indeed me, after moving my GCC repo to a different machine
> and adding an explicit user.email (as this wasn't automatically
> picking up a proper domain.) The "ł" was a typo (AltGr key still
> pressed while typing the "l" after having entered the "@" which
> requires it on a German keyboard layout.)
>
>   So I broke it. Any way to make sure something like this doesn't
> occur again?

We could add a check to the git hooks (and gcc-verify alias) to reject
non-ASCII email addresses, since they're probably mistakes.

And we should report it to Gitweb (if it isn't already fixed upstream)
and get a fix into the version used on gcc.gnu.org.