public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: "gcc@gcc.gnu.org" <gcc@gcc.gnu.org>
Subject: Re: Building GCC with -Wmissing-declarations and addressing its warnings
Date: Thu, 20 Feb 2014 18:21:00 -0000	[thread overview]
Message-ID: <CAH6eHdQxCQa-R5AWbk9eO92QqGBFEdODg=ukPJtOEmfCXfg=8g@mail.gmail.com> (raw)
In-Reply-To: <CA+C-WL966gncos_tZNNqE8SPnEsU0Gm0wznXSuBW5a1r7si4YA@mail.gmail.com>

On 20 February 2014 18:16, Patrick Palka wrote:
> On Thu, Feb 20, 2014 at 1:14 PM, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
>> On 20 February 2014 15:31, Patrick Palka wrote:
>>> (I counted nearly 100 (non-debug)
>>> functions that could be made static in gcc, and 4 in libstdc++, by the
>>> way.)
>>
>> Which were the four in libstdc++?
>>
>> I only see __gslice_on_index and __concat_size_t.
>
> Those two along with _Rb_tree_rotate_left and _Rb_tree_rotate_right.

See the comments above those functions.  (That mistake shouldn't
happen again, because we have the check-abi test to catch it.)

      reply	other threads:[~2014-02-20 18:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 20:47 Patrick Palka
2014-02-20  7:17 ` Jonathan Wakely
2014-02-20 10:02   ` Patrick Palka
2014-02-20 12:42     ` Jonathan Wakely
2014-02-20 15:37       ` Patrick Palka
2014-02-20 17:55         ` Richard Sandiford
2014-02-20 18:14         ` Jonathan Wakely
2014-02-20 18:16           ` Patrick Palka
2014-02-20 18:21             ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH6eHdQxCQa-R5AWbk9eO92QqGBFEdODg=ukPJtOEmfCXfg=8g@mail.gmail.com' \
    --to=jwakely.gcc@gmail.com \
    --cc=gcc@gcc.gnu.org \
    --cc=patrick@parcs.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).