public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Martin Jambor <mjambor@suse.cz>, GCC Mailing List <gcc@gcc.gnu.org>
Subject: Re: Mass rename of C++ .c files to .cc suffix?
Date: Fri, 7 Jan 2022 11:05:30 +0000	[thread overview]
Message-ID: <CAH6eHdRB6md9jSL1-MvGzu6dKQpsj7fj=7T+GiGzy5Txn8Zgtw@mail.gmail.com> (raw)
In-Reply-To: <20220107105133.GH2646553@tucnak>

On Fri, 7 Jan 2022 at 10:54, Jakub Jelinek via Gcc <gcc@gcc.gnu.org> wrote:
> My big worry would be backporting for the next 2 years.
> Do we need to adjust commit messages when backporting to replace *.cc with
> *.c in there?  Does git cherry-pick handle the changed files or do we
> need to resolve conflicts manually?

git cherry-pick (and the gcc-backport alias) should handle it
automatically, unless the diffs between trunk and the branch are a
large percentage of the whole file. IOf a file has been renamed then
Git finds the file to apply the patch to by comparing file contents
fuzzily. For a large repo like GCC you might want to set the
merge.renameLimit config variable so that it doesn't give up trying to
find the file too early. I did 'git config merge.renameLimit 9001' in
my repos. You can also set it to 0 which uses a hardcoded maximum
decided by Git, which gets updated now and then to ensure it works for
the kernel. That maps to a value much larger than 9000, but I've found
that my GCC cherry picks work with 9001.

References to .cc files in the commit message won't get changed to .c
automatically, but maybe the gcc-backport alias could be taught to do
that.

  reply	other threads:[~2022-01-07 11:05 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 10:25 Martin Jambor
2022-01-07 10:33 ` Richard Sandiford
2022-01-07 10:44   ` Andrew Pinski
2022-01-07 10:51 ` Jonathan Wakely
2022-01-07 10:51 ` Jakub Jelinek
2022-01-07 11:05   ` Jonathan Wakely [this message]
2022-01-07 12:55     ` Martin Liška
2022-01-07 14:42       ` Iain Sandoe
2022-01-07 14:49 ` Jeff Law
2022-01-07 15:45   ` Jeff Law
2022-01-07 15:59 ` David Malcolm
2022-01-07 17:31   ` Jonathan Wakely
2022-01-10  9:11   ` Martin Liška
2022-01-07 18:33 ` Alexandre Oliva
2022-01-07 19:01   ` Jakub Jelinek
2022-01-11 12:56 ` [PATCH] Mass rename of C++ .c files to .cc suffix Martin Liška
2022-01-11 15:48   ` Toon Moene
2022-01-11 15:50     ` Martin Liška
2022-01-11 15:56       ` Jakub Jelinek
2022-01-11 16:03         ` Martin Liška
2022-01-11 16:16           ` Jakub Jelinek
2022-01-12  8:58             ` Martin Liška
2022-01-12 15:54               ` [PATCH] git-backport: support renamed .cc files in commit message Martin Liška
2022-01-14  7:44                 ` Bernhard Reutner-Fischer
2022-01-14 15:26                   ` Martin Liška
2022-01-17 21:26                 ` Martin Liška
2022-01-18 19:10                   ` Harald Anlauf
2022-01-19  8:07                     ` Martin Liška
2022-01-11 18:00       ` [PATCH] Mass rename of C++ .c files to .cc suffix Harald Anlauf
2022-01-11 18:00         ` Harald Anlauf
2022-01-11 18:23         ` Jonathan Wakely
2022-01-11 18:36           ` Jakub Jelinek
2022-01-13 11:01     ` [ANNOUNCEMENT] Mass rename of C++ .c files to .cc suffix is going to happen on Jan 17 evening UTC TZ Martin Liška
2022-01-17 21:41       ` Martin Liška
2022-01-18  8:36         ` Eric Botcazou
2022-01-18  8:39           ` Martin Liška
2022-01-18  8:46             ` Eric Botcazou
2022-01-18  8:53               ` Richard Biener
2022-01-18  9:08                 ` Martin Liška
2022-01-18  9:13                   ` Jakub Jelinek
2022-01-18  9:43                     ` Martin Liška
2022-01-18 13:10         ` Richard Earnshaw
2022-01-18 13:16           ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH6eHdRB6md9jSL1-MvGzu6dKQpsj7fj=7T+GiGzy5Txn8Zgtw@mail.gmail.com' \
    --to=jwakely.gcc@gmail.com \
    --cc=gcc@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=mjambor@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).