From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id C54C73857B9B for ; Wed, 28 Sep 2022 14:12:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C54C73857B9B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x532.google.com with SMTP id z97so17407347ede.8 for ; Wed, 28 Sep 2022 07:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=XF0xei5Yya8QPtyaDUvy1A/u8PCtoXj0289c3Dey6Z4=; b=Ljtc3szhE29dgOo9LJPHqDuyvj+k9AnXXzvBR+mzu8Yru2CecEh8RyvrtgzMosKi34 nw2UsRAUgyT/Me5WIT3x9c5vkat0oGZbLk4KcKK0TCtJ3guDl3SXYN/vfNpcRbwLXdzt uCkjcA1D8k+GYUqTOEomj869P0pv63l/jBLP5x6q49L+nl8ntolRDfm30AY/n1loc9Gt GnMS4P59Q/AYC9cdY1x0sGTZ31koo/ehryuYP5Gja55GA50PwuXQL0yMJX+kI8J3jMxM IbxWA3ggURbABXZKYxTXxHgSWQ7murgg9HrvoOYMyvDkdlGgQ12VftMbVmUeMx2qWP7j GYjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=XF0xei5Yya8QPtyaDUvy1A/u8PCtoXj0289c3Dey6Z4=; b=zGNnhFitaXAUInnNi22lo0Um5H8bQfdpU/l31E6cDpRvRaZJ0ToxNsFrbGMM354R3E 1+iPKHxfnw/2NHcCs6yOUB0BfKjhTHQ0PU4Tc1lBvjYIiDrPuTFD20f+DgP96lnB1ies fuNqPIdxDk6x27vrClPQI+YSfAZDyW6vgUFPeaEODWBummH1sMDKJlRgR8pacEpUFSMw +7mwpyqbq+Ax3fHJEJL+UqYJ6QnyrEo/4oriHPRWt/s7wEisgqgNQQi3dF35p+1voBCe S7SSJYO+q3IjkqhFlRCmLyNbalcGxWifv63EL7Stg2zi1Px0V+cPntZcJae5rx7cNHzm YGqQ== X-Gm-Message-State: ACrzQf16Ibzq0HqnvC2ZHkXBZ+uwlafkzfr8neMlX8xp8RtYmcVs/Jdi qIAb/2yGMw4vYNsuTDx5xTzyL6VFqV/5BxKe4WM= X-Google-Smtp-Source: AMsMyM6IaUZGLiX4rJkz1AgjTV0LRczMzS08o+GfpA9wfWloSniSNoMo1C+EhYWP4WEXIfopAoIt4cYJdiyM3ZJ/arE= X-Received: by 2002:a05:6402:847:b0:453:943b:bf4 with SMTP id b7-20020a056402084700b00453943b0bf4mr33269948edz.301.1664374355384; Wed, 28 Sep 2022 07:12:35 -0700 (PDT) MIME-Version: 1.0 References: <87r18jt7uu.fsf@euler.schwinge.homeip.net> <871qrvlibb.fsf@euler.schwinge.homeip.net> In-Reply-To: <871qrvlibb.fsf@euler.schwinge.homeip.net> From: Jonathan Wakely Date: Wed, 28 Sep 2022 15:12:23 +0100 Message-ID: Subject: Re: DejaGnu: flags via 'RUNTESTFLAGS' overriding those specified in test cases To: Thomas Schwinge Cc: Tom de Vries , gcc@gcc.gnu.org, Segher Boessenkool Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 28 Sept 2022 at 14:50, Thomas Schwinge wrote: > > Hi! > > On 2022-02-04T13:09:29+0100, Tom de Vries via Gcc wrote: > > On 2/4/22 08:21, Thomas Schwinge wrote: > >> On 2022-02-03T13:35:55+0000, "vries at gcc dot gnu.org via Gcc-bugs" wrote: > >>> while iterating over dimensions { -mptx=3.1 , -mptx=6.3 } x { GOMP_NVPTX_JIT=-O0, }. > >> > >> Do you use separate (nvptx-none offload target only?) builds for > >> different '-mptx' variants (likewise: '-misa'), or have you hacked up the > >> multilib configuration? > > > > Neither, I'm using --target_board=unix/foffload= for that. > > OK, so that's for libgomp nvptx offloading testing. > > What about nvptx target testing: > 'gcc/testsuite/gcc.target/nvptx/nvptx.exp'. > > We have a DejaGnu board file, say 'BOARD', invoking the nvptx-tools > 'nvptx-none-run' launcher > (): > > $ make check RUNTESTFLAGS='--target_board=BOARD' > > That generally works as expected. > > But now suppose that 'BOARD' needs '-mptx=3.1', because old CUDA, for > example. Running the obvious '--target_board=BOARD/-mptx=3.1' FAILs in a > number of 'gcc.target/nvptx/nvptx.exp' test cases, for example: > > FAIL: gcc.target/nvptx/alias-1.c (test for excess errors) > Excess errors: > [...]/gcc.target/nvptx/alias-1.c:13:6: error: alias definitions not supported in this configuration > > That's because we then invoke GCC as follows: > > [GCC] [...]/gcc.target/nvptx/alias-1.c [...] -malias -mptx=6.3 [...] -mptx=3.1 -o ./alias-1.exe > > Here, '-malias -mptx=6.3' are due to 'dg-add-options ptx_alias' in the > test case, but our '-mptx=3.1' overrides that, thus FAIL. I think these > would work if the '-mptx=3.1' came first? Which version of Dejagnu are you using? There was a fix in 6.1 or 6.2 to change the order that the RUNTESTFLAGS and dg-options get added to the command line. It's a pain to make the testsuite work consistently for both old and new versions. I would be very happy if we just said you need a modern version of Dejagnu, and relied on the semantics in the newer versions.