public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>,
		Segher Boessenkool <segher@kernel.crashing.org>,
	Eric Raymond <esr@thyrsus.com>, Jeff Law <law@redhat.com>,
		GCC Development <gcc@gcc.gnu.org>
Subject: Re: Commit messages and the move to git
Date: Thu, 19 Dec 2019 11:05:00 -0000	[thread overview]
Message-ID: <CAH6eHdRa6nF-9NT-uoonZ+=LukHdiN=EOeBRA9=+YRKu3rF8mw@mail.gmail.com> (raw)
In-Reply-To: <CAH6eHdT+g6k-zEDzX6OGz-7xT7OjHNbvGPOPBi8XW+xjoOoF6A@mail.gmail.com>

On Thu, 19 Dec 2019 at 09:27, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
>
> On Thu, 19 Dec 2019 at 00:02, Joseph Myers <joseph@codesourcery.com> wrote:
> >
> > On Wed, 18 Dec 2019, Joseph Myers wrote:
> >
> > > On Mon, 18 Nov 2019, Richard Earnshaw (lists) wrote:
> > >
> > > > I've attached a sample from the start of the fixed list - the full list is far
> > > > too big to post to give a flavour of how the script currently works.  Note
> > > > that annotations of the form [checkme: ....] in the summary are for diagnostic
> > > > purposes.  These are where heuristics suggest that there's a higher than
> > > > normal chance that the PR number is incorrect and that manual auditing is
> > > > recommended.  Such annotations would not be appropriate in the final
> > > > conversion.
> > >
> > > Concretely, here is the current list of 664 checkme: annotations where
> > > something was suspicious about the PR number (either component mismatch or
> > > resolved as INVALID).  Would some people like to volunteer to pick up
> > > sections of this list and, for their section, produce a list of SVN
> > > revisions (at the end of the checkme line) for which the PR number appears
> > > to be correct, and a list of mappings from SVN revision to correct PR
> > > number when the PR number appears to be wrong?  For any that don't get
> > > reviewed like that we can easily make the script, for the final
> > > conversion, decline to add a new summary line for any commit where the PR
> > > number is suspicious.
> >
> > Here's a slightly shorter version with 644 checkme: annotations, after
> > adding a few more component aliases to the script (e.g., no longer
> > considering it suspicious if the log message says PR g++/something and
> > that PR is in the component that's actually called c++).
>
> Line 18: c++ SVN r116634, looks suspicious, but PR number is correct.
> Line 326: lto SVN r196613, PR number is correct
> Line 411: libstdc++ SVN r219147, PR number is correct
>
>
> How do you want the mapping from SVN revision to correct PR to be expressed?
>
> Line 19: the correct PR for fortran SVN r120056 is fortran/30238 (not 39238)
> Line 608: lto SVN r268728 should be PR 87089 (not 87809)
> Line 616: lto SVN r269799 should be PR 87089 (not 87809)

I can take a chunk of the file, but I'll wait until I know how to
present the results.

  reply	other threads:[~2019-12-19 11:05 UTC|newest]

Thread overview: 139+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 10:29 Richard Earnshaw (lists)
2019-11-04 12:11 ` Arnaud Charlet
2019-11-04 12:43 ` Martin Jambor
2019-11-04 17:43   ` Segher Boessenkool
2019-11-04 16:04 ` Jeff Law
2019-11-04 16:18   ` Richard Earnshaw (lists)
2019-11-05 15:48   ` Richard Earnshaw
2019-11-07 14:27   ` Eric S. Raymond
2019-11-08 13:43     ` Richard Earnshaw (lists)
2019-11-09  6:01       ` Eric S. Raymond
2019-11-18 15:32         ` Richard Earnshaw (lists)
2019-11-18 15:55           ` Segher Boessenkool
2019-11-18 16:48             ` Richard Earnshaw (lists)
2019-11-18 17:11               ` Segher Boessenkool
     [not found]                 ` <8c32c288-e9e6-b01b-7911-3f186116da85@gmail.com>
2019-11-18 17:24                   ` Nicholas Krause
2019-11-18 17:26                     ` Nicholas Krause
2019-11-18 17:46                       ` Richard Earnshaw (lists)
2019-11-18 17:49                         ` Richard Earnshaw (lists)
2019-11-18 17:55                         ` Nicholas Krause
2019-11-18 18:05                           ` Richard Earnshaw (lists)
2019-11-18 18:24                             ` Joseph Myers
2019-11-19 11:26                               ` Eric S. Raymond
2019-11-19 11:25                             ` Eric S. Raymond
2019-11-19 11:46                               ` Richard Earnshaw (lists)
2019-11-19 19:32                                 ` Eric S. Raymond
2019-11-19 19:47                                   ` Richard Earnshaw (lists)
2019-11-19 19:49                                     ` Richard Earnshaw (lists)
2019-11-19 22:14                                     ` Eric S. Raymond
2019-11-19 22:19                                       ` Richard Earnshaw (lists)
2019-11-21 16:41                                       ` Joseph Myers
2019-11-21 16:52                                         ` Richard Earnshaw (lists)
2019-11-21 18:11                                           ` Eric S. Raymond
2019-11-21 18:09                                         ` Eric S. Raymond
2019-11-21 19:22                                         ` Richard Earnshaw (lists)
2019-11-19 19:43                                 ` Richard Earnshaw (lists)
2019-11-19 22:08                                   ` Eric S. Raymond
2019-11-18 17:38                 ` Richard Earnshaw (lists)
2019-11-18 18:53                   ` Segher Boessenkool
2019-11-18 19:14                     ` Richard Earnshaw (lists)
2019-11-18 19:21                     ` Richard Earnshaw (lists)
2019-11-18 19:44                       ` Segher Boessenkool
2019-11-18 20:53                         ` Jason Merrill
2019-11-18 21:38                           ` Richard Earnshaw (lists)
2019-11-19 14:57                             ` Jason Merrill
2019-11-19 16:31                               ` Segher Boessenkool
2019-11-19 16:47                                 ` Jonathan Wakely
2019-11-19 16:48                                 ` Jason Merrill
2019-11-19 19:36                                   ` Eric S. Raymond
2019-11-19 23:29                                     ` Segher Boessenkool
2019-11-19 23:44                                       ` Joseph Myers
2019-11-19 23:51                                         ` Nicholas Krause
2019-11-20  8:55                                           ` Jonathan Wakely
2019-11-20 14:50                                         ` Szabolcs Nagy
2019-11-20 17:30                                         ` Richard Earnshaw (lists)
2019-11-20  8:58                                       ` Jonathan Wakely
2019-11-20 11:27                                         ` Segher Boessenkool
2019-11-20 11:30                                           ` Richard Earnshaw (lists)
2019-11-20 11:42                                             ` Segher Boessenkool
2019-11-20 14:25                                           ` Jason Merrill
2019-11-20 16:01                                             ` Segher Boessenkool
2019-11-19 16:49                                 ` Richard Earnshaw (lists)
2019-12-02 10:54                               ` Richard Earnshaw (lists)
2019-12-02 15:35                                 ` Segher Boessenkool
2019-12-02 16:19                                   ` Richard Earnshaw (lists)
2019-12-02 17:25                                     ` Segher Boessenkool
2019-12-02 17:47                                       ` Richard Earnshaw (lists)
2019-12-02 18:00                                         ` Segher Boessenkool
2019-12-02 18:11                                           ` Richard Earnshaw (lists)
2019-12-02 18:17                                           ` Eric S. Raymond
2019-12-02 20:24                                       ` Joseph Myers
2019-12-03  0:48                                         ` Segher Boessenkool
2019-12-03  9:44                                           ` Richard Earnshaw (lists)
2019-12-03 10:12                                             ` Richard Earnshaw (lists)
2019-12-02 20:22                                     ` Richard Sandiford
2019-12-04 23:52                                 ` Richard Earnshaw (lists)
2019-12-05 10:26                                   ` Jonathan Wakely
2019-12-05 10:32                                     ` Jonathan Wakely
2019-12-05 10:36                                       ` Richard Earnshaw (lists)
2019-12-05 10:41                                         ` Jonathan Wakely
2019-12-05 10:54                                           ` Jonathan Wakely
2019-12-05 13:18                                         ` Joseph Myers
2019-12-05 17:10                                           ` Eric S. Raymond
2019-12-05 17:22                                             ` Joseph Myers
2019-12-05 17:45                                               ` Eric S. Raymond
2019-12-05 20:14                                                 ` Joseph Myers
2019-12-05 20:46                                                   ` Joseph Myers
2019-12-05 21:14                                                     ` Eric S. Raymond
2019-12-05 21:13                                                   ` Eric S. Raymond
2019-12-05 15:33                                         ` Eric S. Raymond
2019-12-18 23:43                   ` Joseph Myers
2019-12-19  0:01                     ` Joseph Myers
2019-12-19  9:27                       ` Jonathan Wakely
2019-12-19 11:05                         ` Jonathan Wakely [this message]
2019-12-19 11:50                         ` Richard Earnshaw (lists)
2019-12-19 11:58                           ` Richard Earnshaw (lists)
2019-12-19 12:23                           ` Jonathan Wakely
2019-12-19 12:33                             ` Richard Earnshaw (lists)
2019-12-19 12:35                               ` Jonathan Wakely
2019-12-19 12:42                                 ` Richard Earnshaw (lists)
2019-12-19 13:34                                   ` Jonathan Wakely
2019-12-19 16:00                                     ` Joseph Myers
2019-12-19 16:06                                       ` Richard Earnshaw (lists)
2019-12-19 14:29                           ` Joseph Myers
2019-12-19 15:17                             ` Jonathan Wakely
2019-12-19 15:20                               ` Richard Earnshaw (lists)
2019-12-19 15:44                                 ` Jonathan Wakely
2019-12-19 15:47                                   ` Joseph Myers
2019-12-19 15:48                                     ` Jonathan Wakely
2019-12-19 15:48                                   ` Richard Earnshaw (lists)
2019-12-19 15:49                                 ` Joseph Myers
2019-12-19 16:27                                   ` Jonathan Wakely
2019-12-19 16:28                                     ` Jonathan Wakely
2019-12-19 16:33                                     ` Joseph Myers
2019-12-19 16:39                                       ` Jonathan Wakely
2019-12-19 16:43                                         ` Joseph Myers
2019-12-20 20:30                                     ` Joseph Myers
2019-12-20 21:30                                       ` Jonathan Wakely
2019-12-20 21:41                                         ` Joseph Myers
2019-12-20 22:11                                           ` Jonathan Wakely
2019-12-20 22:58                                             ` Joseph Myers
2019-12-20 23:23                                               ` Jonathan Wakely
2019-12-20 23:53                                                 ` Joseph Myers
2019-12-19 11:16                       ` Jakub Jelinek
2019-12-19 15:05                         ` Richard Earnshaw (lists)
2019-11-04 16:19 ` Jonathan Wakely
2019-11-04 16:35   ` Richard Earnshaw (lists)
2019-11-04 17:33   ` Segher Boessenkool
2019-11-04 17:42     ` Joseph Myers
2019-11-04 17:50       ` Segher Boessenkool
2019-11-05 11:07       ` Jonathan Wakely
2019-11-05 11:28         ` Jason Merrill
2019-11-05 14:12           ` Marek Polacek
2019-11-05 21:40             ` Richard Earnshaw (lists)
2019-11-05 14:50           ` David Malcolm
2019-11-05 22:08             ` Segher Boessenkool
2019-11-05 20:16         ` Segher Boessenkool
2019-11-05 21:01           ` Iain Sandoe
2019-11-05  2:51 ` Kewen.Lin
2019-11-05 21:42   ` Richard Earnshaw (lists)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH6eHdRa6nF-9NT-uoonZ+=LukHdiN=EOeBRA9=+YRKu3rF8mw@mail.gmail.com' \
    --to=jwakely.gcc@gmail.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=esr@thyrsus.com \
    --cc=gcc@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=law@redhat.com \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).