From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 508763839838 for ; Tue, 6 Jul 2021 22:09:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 508763839838 Received: by mail-wm1-x32f.google.com with SMTP id t14-20020a05600c198eb029020c8aac53d4so7754233wmq.1 for ; Tue, 06 Jul 2021 15:09:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fd3PoSeZkf028vgM+EgT9Y10P7UgHjlDrn3azeP9HY0=; b=W69VDHjlhDtV2iW2B9D1bgbcMpV7/wnfZxR5dWHIux2K+vgFk8xV0QF7l5PCTaFiy+ M4psa8yBQXrnmZ62Ea6sm9g0hbaJJWNlX4KiqSkztMub1LftDD+PA5ZyOUaLZcmirQ6W Yt0cHjO/FISDA4Se2Q9tHuMfQkMGSzjBpeXqP9NrlvsJmnvrHFptGOEgPoH8ABXPzwER DeP+R3YvFMLQt7elsfeDqGtFkp7uAQNG1ikai+pay4xHde44/cyOvQuzQv8yU+6VBEqx x4niI0bgIUisMs7otQhnQvo1DlfG8nqXKwerYOt34Yj6DhhVTljqf5/Zj6ijl0XJ9CeT ckQw== X-Gm-Message-State: AOAM5325iHIf16UvJ2t9sNFjiLbrf8iwE9p6ghaubGkYUuIwG1Lh8hWE VLL/otoXttGC2+nA0JbVVylBkxAYXrMZKaZdgP8= X-Google-Smtp-Source: ABdhPJxxifqDiVNe7SNrL4sMGVMFghKjzdadbbFZjp/dl+ZCp17oORk10IfHEzWMekkmsMGjR/2C8oQoWRpHy1vB5Oc= X-Received: by 2002:a7b:cf3a:: with SMTP id m26mr22829025wmg.117.1625609355162; Tue, 06 Jul 2021 15:09:15 -0700 (PDT) MIME-Version: 1.0 References: <9121724e-e741-9bad-a39d-d6ac49422589@gmail.com> In-Reply-To: <9121724e-e741-9bad-a39d-d6ac49422589@gmail.com> From: Jonathan Wakely Date: Tue, 6 Jul 2021 23:09:03 +0100 Message-ID: Subject: Re: where is PRnnnn required again? To: Martin Sebor Cc: Marek Polacek , gcc mailing list X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 22:09:18 -0000 On Tue, 6 Jul 2021, 22:45 Martin Sebor via Gcc, wrote: > On 7/6/21 3:36 PM, Marek Polacek wrote: > > On Tue, Jul 06, 2021 at 03:20:26PM -0600, Martin Sebor via Gcc wrote: > >> I came away from the recent discussion of ChangeLogs requirements > >> with the impression that the PRnnnn bit should be in the subject > >> (first) line and also above the ChangeLog part but doesn't need > >> to be repeated again in the ChangeLog entries. But my commit > >> below was rejected last Friday with the subsequent error. Adding > >> PR middle-end/98871 to the ChangeLog entry let me push the change: > >> > >> https://gcc.gnu.org/g:6feb628a706e86eb3f303aff388c74bdb29e7381 > >> > >> I just had the same error happen now, again with what seems like > >> a valid commit message. Did I misunderstand something or has > >> something changed recently? > >> > >> Martin > >> > >> commit 8a6d08bb49c2b9585c2a2adbb3121f6d9347b780 (HEAD -> master) > >> Author: Martin Sebor > >> Date: Fri Jul 2 16:16:31 2021 -0600 > >> > >> Improve warning suppression for inlined functions [PR98512]. > >> > >> Resolves: > >> PR middle-end/98871 - Cannot silence -Wmaybe-uninitialized at > >> declaration si > >> te > >> PR middle-end/98512 - #pragma GCC diagnostic ignored ineffective in > >> conjunct > >> ion with alias attribute > > > > This should be just > > > > PR middle-end/98871 > > PR middle-end/98512 > > > > , no? > > Does it matter if there's text after the PR ...? Yes. With extra text the whole line is just treated as arbitrary text, not a "PR component/nnnn" string. So with the extra text it won't be added to the ChangeLog file, and won't match the PR in the subject line. I managed to push > > https://gcc.gnu.org/pipermail/gcc-cvs/2021-July/350316.html > > that uses the same style earlier today But will it add the PR numbers to the ChangeLog? I think the answer is no (in which case you could edit the ChangeLog tomorrow if you want them to be in there).