From: Jonathan Wakely <jwakely.gcc@gmail.com>
To: Martin Sebor <msebor@gmail.com>
Cc: Marek Polacek <polacek@redhat.com>, gcc mailing list <gcc@gcc.gnu.org>
Subject: Re: where is PRnnnn required again?
Date: Wed, 7 Jul 2021 21:42:42 +0100 [thread overview]
Message-ID: <CAH6eHdRyEReT_1FmdbXSNnx5H=Owz1JS36b53H4tAMaR+bj3_w@mail.gmail.com> (raw)
In-Reply-To: <b26dd2ae-c04f-76db-307e-03df52b012f2@gmail.com>
On Wed, 7 Jul 2021, 17:39 Martin Sebor, <msebor@gmail.com> wrote:
> On 7/6/21 4:09 PM, Jonathan Wakely wrote:
> >
> >
> > On Tue, 6 Jul 2021, 22:45 Martin Sebor via Gcc, <gcc@gcc.gnu.org
> > <mailto:gcc@gcc.gnu.org>> wrote:
> >
> > On 7/6/21 3:36 PM, Marek Polacek wrote:
> > > On Tue, Jul 06, 2021 at 03:20:26PM -0600, Martin Sebor via Gcc
> wrote:
> > >> I came away from the recent discussion of ChangeLogs requirements
> > >> with the impression that the PRnnnn bit should be in the subject
> > >> (first) line and also above the ChangeLog part but doesn't need
> > >> to be repeated again in the ChangeLog entries. But my commit
> > >> below was rejected last Friday with the subsequent error. Adding
> > >> PR middle-end/98871 to the ChangeLog entry let me push the
> change:
> > >>
> > >> https://gcc.gnu.org/g:6feb628a706e86eb3f303aff388c74bdb29e7381
> > >>
> > >> I just had the same error happen now, again with what seems like
> > >> a valid commit message. Did I misunderstand something or has
> > >> something changed recently?
> > >>
> > >> Martin
> > >>
> > >> commit 8a6d08bb49c2b9585c2a2adbb3121f6d9347b780 (HEAD -> master)
> > >> Author: Martin Sebor <msebor@redhat.com <mailto:
> msebor@redhat.com>>
> > >> Date: Fri Jul 2 16:16:31 2021 -0600
> > >>
> > >> Improve warning suppression for inlined functions [PR98512].
> > >>
> > >> Resolves:
> > >> PR middle-end/98871 - Cannot silence -Wmaybe-uninitialized
> at
> > >> declaration si
> > >> te
> > >> PR middle-end/98512 - #pragma GCC diagnostic ignored
> > ineffective in
> > >> conjunct
> > >> ion with alias attribute
> > >
> > > This should be just
> > >
> > > PR middle-end/98871
> > > PR middle-end/98512
> > >
> > > , no?
> >
> > Does it matter if there's text after the PR ...?
> >
> >
> >
> > Yes. With extra text the whole line is just treated as arbitrary text,
> > not a "PR component/nnnn" string. So with the extra text it won't be
> > added to the ChangeLog file, and won't match the PR in the subject line.
> >
> > I managed to push
> >
> > https://gcc.gnu.org/pipermail/gcc-cvs/2021-July/350316.html
> >
> > that uses the same style earlier today
> >
> >
> > But will it add the PR numbers to the ChangeLog? I think the answer is
> > no (in which case you could edit the ChangeLog tomorrow if you want them
> > to be in there).
>
> It updated Bugzilla but it didn't add the PR numbers to the ChangeLog
> entries. I still don't (obviously) understand the rules the hook uses
> for what to update or the rationale for them. It seems as though
> the PR in the subject is used to update only Bugzilla but not also
> update the ChangeLogs (why not?)
Because they are two completely separate processes. Verifying the commit
message format is done by a git hook, and you can run exactly the same
checks locally before pushing a commit.
Updating bugzilla is done by a separate and different process, which has
been in place for years (decades?) before we switched to git.
The PR component/nnnn part that's
> supposed to come before the ChangeLog is used to update ChangeLog
> entries but seems to be ignored if it's followed by any text (why?)
>
See Jakub's reply.
>
next prev parent reply other threads:[~2021-07-07 20:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 21:20 Martin Sebor
2021-07-06 21:36 ` Marek Polacek
2021-07-06 21:44 ` Martin Sebor
2021-07-06 22:09 ` Jonathan Wakely
2021-07-07 16:39 ` Martin Sebor
2021-07-07 20:42 ` Jonathan Wakely [this message]
2021-07-07 21:35 ` Martin Sebor
2021-07-07 21:53 ` Marek Polacek
2021-07-07 22:18 ` Martin Sebor
2021-07-07 22:24 ` Jonathan Wakely
2021-07-07 22:58 ` Martin Sebor
2021-07-07 23:03 ` David Malcolm
2021-07-08 8:26 ` Jonathan Wakely
2021-07-08 18:58 ` Martin Sebor
2021-07-07 22:15 ` Jonathan Wakely
2021-07-07 23:38 ` Martin Sebor
2021-07-07 17:51 ` Jakub Jelinek
2021-07-07 19:01 ` Martin Sebor
2021-07-07 21:01 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH6eHdRyEReT_1FmdbXSNnx5H=Owz1JS36b53H4tAMaR+bj3_w@mail.gmail.com' \
--to=jwakely.gcc@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=msebor@gmail.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).