Failing in generated file options.c

Failing in generated file options.c

[Gary Oblock]

Guys,

I checked out a fresh copy of the GCC sources today, applied somebodies
patch to it and voila!

options.c:13591:2: error: #error Report option property is dropped #error Report option property is dropped

I built this the same minimally convoluted way that I always do.

cd $1
BASE=`pwd`
echo BASE = $BASE
touch objdir install
rm -rf objdir install
mkdir objdir install
cd objdir
echo BUILDING IN `pwd`
../sources/configure --prefix=$BASE/install --disable-bootstrap -enable-language=c,c++,lto --disable-multilib --enable-valgrind-annotations
make CFLAGS='-O2 -g' CXXFLAGS='-O2 -g' -j 12
make install

The file option.c is generated in objdir/gcc by an awk script:

mawk -f ../../sources/gcc/opt-functions.awk -f ../../sources/gcc/opt-read.awk \
       -f ../../sources/gcc/optc-gen.awk \
       -v header_name="config.h system.h coretypes.h options.h tm.h" < optionlist > options.c

Does anyone  have any idea what's going to here?


CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to Ampere Computing or its subsidiaries. It is to be used solely for the purpose of furthering the parties' business relationship. Any unauthorized review, copying, or distribution of this email (or any attachments thereto) is strictly prohibited. If you are not the intended recipient, please contact the sender immediately and permanently delete the original and any copies of this email and any attachments thereto.

Re: Failing in generated file options.c

[Andrew Pinski]

On Mon, Mar 15, 2021 at 7:41 PM Gary Oblock via Gcc <gcc@gcc.gnu.org> wrote:
>
> Guys,
>
> I checked out a fresh copy of the GCC sources today, applied somebodies
> patch to it and voila!
>
> options.c:13591:2: error: #error Report option property is dropped #error Report option property is dropped
>
> I built this the same minimally convoluted way that I always do.
>
> cd $1
> BASE=`pwd`
> echo BASE = $BASE
> touch objdir install
> rm -rf objdir install
> mkdir objdir install
> cd objdir
> echo BUILDING IN `pwd`
> ../sources/configure --prefix=$BASE/install --disable-bootstrap -enable-language=c,c++,lto --disable-multilib --enable-valgrind-annotations
> make CFLAGS='-O2 -g' CXXFLAGS='-O2 -g' -j 12
> make install
>
> The file option.c is generated in objdir/gcc by an awk script:
>
> mawk -f ../../sources/gcc/opt-functions.awk -f ../../sources/gcc/opt-read.awk \
>        -f ../../sources/gcc/optc-gen.awk \
>        -v header_name="config.h system.h coretypes.h options.h tm.h" < optionlist > options.c
>
> Does anyone  have any idea what's going to here?


# If FLAGS contains a "NAME(...argument...)" flag, return the value
# of the argument.  Print error message otherwise.

It could be any of the following:
Name/Type inside Enum
Enum/String/Value instead EnumValue

Thanks,
Andrew

>
>
> CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to Ampere Computing or its subsidiaries. It is to be used solely for the purpose of furthering the parties' business relationship. Any unauthorized review, copying, or distribution of this email (or any attachments thereto) is strictly prohibited. If you are not the intended recipient, please contact the sender immediately and permanently delete the original and any copies of this email and any attachments thereto.

Re: Failing in generated file options.c

[Martin Liška]

On 3/16/21 3:39 AM, Gary Oblock via Gcc wrote:
> Guys,
> 
> I checked out a fresh copy of the GCC sources today, applied somebodies
> patch to it and voila!
> 
> options.c:13591:2: error: #error Report option property is dropped #error Report option property is dropped
> 
> I built this the same minimally convoluted way that I always do.
> 
> cd $1
> BASE=`pwd`
> echo BASE = $BASE
> touch objdir install
> rm -rf objdir install
> mkdir objdir install
> cd objdir
> echo BUILDING IN `pwd`
> ../sources/configure --prefix=$BASE/install --disable-bootstrap -enable-language=c,c++,lto --disable-multilib --enable-valgrind-annotations
> make CFLAGS='-O2 -g' CXXFLAGS='-O2 -g' -j 12
> make install
> 
> The file option.c is generated in objdir/gcc by an awk script:
> 
> mawk -f ../../sources/gcc/opt-functions.awk -f ../../sources/gcc/opt-read.awk \
>         -f ../../sources/gcc/optc-gen.awk \
>         -v header_name="config.h system.h coretypes.h options.h tm.h" < optionlist > options.c
> 
> Does anyone  have any idea what's going to here?

Hey.

As already mentioned, the error message appeared in 5137d1ae6a1fe4a3ff8b5983f6e4d9aeb69e5486:

     Remove Report keyword for options
     
     Since g:7caa49706316e650fb67719e1a1bf3a35054b685 the option is ignored
     as we print used command line for -fverbose-asm output.
     
     gcc/ChangeLog:
     
             * doc/options.texi: Remove Report keyword.
             * opt-functions.awk: Print error when Report keyword
             is used.
             * optc-gen.awk: Do not handle Report keyword.
             * opts.h (struct cl_option): Remove cl_report bitfield flag.

> 
> 
> CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to Ampere Computing or its subsidiaries. It is to be used solely for the purpose of furthering the parties' business relationship. Any unauthorized review, copying, or distribution of this email (or any attachments thereto) is strictly prohibited. If you are not the intended recipient, please contact the sender immediately and permanently delete the original and any copies of this email and any attachments thereto.
> 

Small comment about this one. Is it really appropriate attaching such a notice if you send an email to a public mailing list?

Cheers,
Martin

Re: Failing in generated file options.c

[Jonathan Wakely]

On Tue, 16 Mar 2021, 08:53 Martin Liška, <mliska@suse.cz> wrote:

> On 3/16/21 3:39 AM, Gary Oblock via Gcc wrote:
> >
> >
> > CONFIDENTIALITY NOTICE: This e-mail message, including any attachments,
> is for the sole use of the intended recipient(s) and contains information
> that is confidential and proprietary to Ampere Computing or its
> subsidiaries. It is to be used solely for the purpose of furthering the
> parties' business relationship. Any unauthorized review, copying, or
> distribution of this email (or any attachments thereto) is strictly
> prohibited. If you are not the intended recipient, please contact the
> sender immediately and permanently delete the original and any copies of
> this email and any attachments thereto.
> >
>
> Small comment about this one. Is it really appropriate attaching such a
> notice if you send an email to a public mailing list?
>

Our policies say it's not appropriate:
https://gcc.gnu.org/lists.html#policies


>
>

Failing in generated file options.c

[Erick Ochoa]

Hi Gary,

the options.c file is generated from the gcc/common.opt file. Report was a
keyword that could be given to optimization options but which was dropped
sometime in December I think. The patches I sent you should have the
keyword Report dropped. Are you applying your sources already? If not, are
you only applying a subset of the patches? If you look at the patch
numbered 9, you will see that the Report keyword was removed. If you are
only applying patches before the 9th, yeah I would expect that error to
trigger.

-Erick