From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-return-201448-listarch-gcc=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 29180 invoked by alias); 10 Jan 2020 13:38:23 -0000
Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc/>
List-Post: <mailto:gcc@gcc.gnu.org>
List-Help: <http://gcc.gnu.org/ml/>
Sender: gcc-owner@gcc.gnu.org
Received: (qmail 29169 invoked by uid 89); 10 Jan 2020 13:38:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mail-wr1-f50.google.com
Received: from mail-wr1-f50.google.com (HELO mail-wr1-f50.google.com) (209.85.221.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2020 13:38:21 +0000
Received: by mail-wr1-f50.google.com with SMTP id c9so1824357wrw.8        for <gcc@gcc.gnu.org>; Fri, 10 Jan 2020 05:38:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com; s=20161025;        h=mime-version:references:in-reply-to:from:date:message-id:subject:to         :cc;        bh=6Dg9gCJLHyofdcdQc0qePk2SVTfggWmV9MATL1ThPWY=;        b=Ujca7RK/FmAg6WTBT5RIgF5ezyVJS/kyZewo9j1SpS6te8YcDnnscocw+fbr3Ud2iS         heKRmNrPFIR+LLPGxi9u++WfFo0gsb1rdvpgv1OFgI5++Ns/kvNgGGn7rdf7eBJL/vZt         lhDbMIkTqqwWstlT29ZWEEKbQO1fSO8HIEhhrrmsPmY1sgg96XWnZte1GkysHvVMcvXt         CJ92Nmah20M2YxSFQu8lnx7HBbCxQ8GaDCt6VaDIXOu92M3dJWSWTSvMhLHiGcg0F/z2         MxQxhzKPVZ9+A+CJgt7ZhHHjeQt9A4WZyFcRw20Bae+Mn++PpUXArQy9dii94bI1bJ/r         5whg==
MIME-Version: 1.0
References: <CADzB+2mqKfG2iEfHZXsv5qJ_U8NQ-cGTgvGRgPWi-5mj3Hot_A@mail.gmail.com> <20190916150650.GB4945@adacore.com> <alpine.DEB.2.21.2001091417030.4040@digraph.polyomino.org.uk> <alpine.DEB.2.21.2001092158480.27516@digraph.polyomino.org.uk> <CAH6eHdSmJ96hGZ0KokOXi3CcPkHmKCmX+phB62RyTsdkiugP9w@mail.gmail.com> <alpine.DEB.2.21.2001101304390.20600@digraph.polyomino.org.uk>
In-Reply-To: <alpine.DEB.2.21.2001101304390.20600@digraph.polyomino.org.uk>
From: Jonathan Wakely <jwakely.gcc@gmail.com>
Date: Fri, 10 Jan 2020 13:38:00 -0000
Message-ID: <CAH6eHdSfCzC7ku7vXhXY+EP_XR9U4prbK8QLreRgm5bdL=0QPg@mail.gmail.com>
Subject: Re: GCC Git hooks
To: Joseph Myers <joseph@codesourcery.com>
Cc: Joel Brobecker <brobecker@adacore.com>, Jason Merrill <jason@redhat.com>, 	Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>, gcc Mailing List <gcc@gcc.gnu.org>, 	Gerald Pfeifer <gerald@pfeifer.com>, Daniel Berlin <dberlin@dberlin.org>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2020-01/txt/msg00118.txt.bz2

On Fri, 10 Jan 2020 at 13:06, Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Fri, 10 Jan 2020, Jonathan Wakely wrote:
>
> > Could you avoid the double negative here? And the error message could
> > be more specific to the actual error by testing the two cases
> > separately, e.g.
>
> I'm sort of hoping we don't end up using the hooks in this form for very
> long - the patch was posted to demonstrate the features that seem to need
> changes to the hook code, but hopefully that code can get extended
> upstream to support such features in a cleaner way and then we'll only
> need some custom configuration, not custom code.

Gotcha. Forget what I said then.