From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99364 invoked by alias); 19 Dec 2019 09:27:55 -0000 Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org Received: (qmail 99353 invoked by uid 89); 19 Dec 2019 09:27:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2146 X-HELO: mail-wm1-f49.google.com Received: from mail-wm1-f49.google.com (HELO mail-wm1-f49.google.com) (209.85.128.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 09:27:53 +0000 Received: by mail-wm1-f49.google.com with SMTP id 20so4710011wmj.4 for ; Thu, 19 Dec 2019 01:27:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=REmZ2rU4N04yoSxBrfOSR/huaEmaU36EhFVwf12iCtk=; b=BjidkGZp5ZfWywINRPqCHFH5kEJdTWu23SY2wgcBJs7jl1ct6wXyzU82mydwrCdJbd GRU0Y2Zf4jhNICTkpQFSOT6RLFwjyUMW98F9nUvCsfqz/duqCipDcT637IiezGr6aj7f TecS329PZQtu9RdPJJihQoRVIDzaS6wf+evaPyZS2ZPA9yrzoOgm74p1nwRxd6rC/FYZ jmpA9VbjCqWqJMBnv7ygL/uhCwWKtRj+1BgfOZrfcJgr1DO6i7cg6vHj1s/2Ad2yALrf dlZaLKxKo+Hxb4W90Uw5gJWFn5zC2OA4DqSA6B2WYPmt4y6XAxblRx/G0a4nEdyMkbTy +pbQ== MIME-Version: 1.0 References: <20191107142727.GA72444@thyrsus.com> <20191109060151.GA82270@thyrsus.com> <78a57894-74f2-94d5-65a1-3ce2bd934f32@arm.com> <20191118155549.GH16031@gate.crashing.org> <20191118171115.GI16031@gate.crashing.org> In-Reply-To: From: Jonathan Wakely Date: Thu, 19 Dec 2019 09:27:00 -0000 Message-ID: Subject: Re: Commit messages and the move to git To: Joseph Myers Cc: "Richard Earnshaw (lists)" , Segher Boessenkool , Eric Raymond , Jeff Law , GCC Development Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00301.txt.bz2 On Thu, 19 Dec 2019 at 00:02, Joseph Myers wrote: > > On Wed, 18 Dec 2019, Joseph Myers wrote: > > > On Mon, 18 Nov 2019, Richard Earnshaw (lists) wrote: > > > > > I've attached a sample from the start of the fixed list - the full list is far > > > too big to post to give a flavour of how the script currently works. Note > > > that annotations of the form [checkme: ....] in the summary are for diagnostic > > > purposes. These are where heuristics suggest that there's a higher than > > > normal chance that the PR number is incorrect and that manual auditing is > > > recommended. Such annotations would not be appropriate in the final > > > conversion. > > > > Concretely, here is the current list of 664 checkme: annotations where > > something was suspicious about the PR number (either component mismatch or > > resolved as INVALID). Would some people like to volunteer to pick up > > sections of this list and, for their section, produce a list of SVN > > revisions (at the end of the checkme line) for which the PR number appears > > to be correct, and a list of mappings from SVN revision to correct PR > > number when the PR number appears to be wrong? For any that don't get > > reviewed like that we can easily make the script, for the final > > conversion, decline to add a new summary line for any commit where the PR > > number is suspicious. > > Here's a slightly shorter version with 644 checkme: annotations, after > adding a few more component aliases to the script (e.g., no longer > considering it suspicious if the log message says PR g++/something and > that PR is in the component that's actually called c++). Line 18: c++ SVN r116634, looks suspicious, but PR number is correct. Line 326: lto SVN r196613, PR number is correct Line 411: libstdc++ SVN r219147, PR number is correct How do you want the mapping from SVN revision to correct PR to be expressed? Line 19: the correct PR for fortran SVN r120056 is fortran/30238 (not 39238) Line 608: lto SVN r268728 should be PR 87089 (not 87809) Line 616: lto SVN r269799 should be PR 87089 (not 87809)