From: Erick Ochoa <eochoa@gcc.gnu.org>
To: Richard Biener <richard.guenther@gmail.com>
Cc: Jan Hubicka <hubicka@ucw.cz>, GCC Development <gcc@gcc.gnu.org>
Subject: Re: tree decl stored during LGEN does not map to a symtab_node during WPA
Date: Thu, 22 Jul 2021 14:33:20 +0200 [thread overview]
Message-ID: <CAJ_nqzhj-0Ne-gpUDn9vr5nCqtDNnnrGHD-Ua7rmbB6DNUXXjg@mail.gmail.com> (raw)
In-Reply-To: <CAFiYyc2yUPW3ybQemQqqV41YGFjY-8goGN6XbNcgUctoOTD1rw@mail.gmail.com>
> > > 1. pid of lgen process that generated the encoding
> > > 2. index returned by lto_symtab_encoder_encode
> > > 3. varpool_node->name ()
> > > 4. the pointer address being pointed by varpool node
>
> Well, yes, during LGEN no WPA has run. Do you mean LTRANS after WPA?
> Sure, the encoder numbers do not have to match up between different
> LTRANS units but then they don't speak to each other so that shouldn't
> matter, no?
No. I mean during WPA. On a different e-mail I clarified the following:
```
>
> fopen $PID1 8 $ADDR1
> fopen $PID2 7 $ADDR2
>
Just to clarify a bit further. $PID is generated and stored during
LGEN. The encoding is obviously generated during LGEN.
These are read during WPA. And the encoding is decoded and dyn_casted
into a cgraph_node at WPA time.
All these are printed during WPA.
```
>
> I _think_ that it should work if you stream at LGEN constraint variables
> as their varpool node (using the varpool encoder), get the nodes merged
> at WPA time, and thus your constraints from different LGEN runs "merged"
> properly, then stream them the same way to the LTRANS units?
>
The only reference to a varpool encoder is on the Changelog. The only
encoder I know of is the symtab_encoder (which I believe should be the
same as varpool_nodes and cgraph_nodes are both symtab_nodes). But
again, I do not know what you mean by "merged" here, since they have
different addresses.
>
> And the same solution should exist. For "merged" function definitions
> (like multiple same inline definitions) you'd simply drop all but one set of
> constraints.
>
Yes, this is what I would like, but I don't see how to detect "merged"
function definitions. I can get their cgraphs but as I mentioned for
every encoding I decode and dyn_cast all I get is a cgraph holding a
different address. What does "merged" concretely mean?
next prev parent reply other threads:[~2021-07-22 12:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 9:27 Erick Ochoa
2021-07-09 7:51 ` Erick Ochoa
2021-07-09 9:49 ` Richard Biener
2021-07-12 10:55 ` Erick Ochoa
2021-07-13 9:21 ` Erick Ochoa
2021-07-13 9:41 ` Richard Biener
2021-07-13 10:49 ` Erick Ochoa
2021-07-13 12:55 ` Richard Biener
2021-07-14 13:56 ` Erick Ochoa
2021-07-15 7:23 ` Richard Biener
2021-07-21 16:55 ` Erick Ochoa
2021-07-22 11:40 ` Richard Biener
2021-07-22 12:04 ` Erick Ochoa
2021-07-22 12:08 ` Erick Ochoa
2021-07-22 12:23 ` Richard Biener
2021-07-22 12:33 ` Erick Ochoa [this message]
2021-07-22 12:48 ` Richard Biener
2021-07-22 14:32 ` Erick Ochoa
2021-07-28 10:35 ` Richard Biener
2021-07-13 11:56 ` Erick Ochoa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ_nqzhj-0Ne-gpUDn9vr5nCqtDNnnrGHD-Ua7rmbB6DNUXXjg@mail.gmail.com \
--to=eochoa@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).