Re: [WIP][RFC] split of i386.c

["Jan Hubička" <honza.hubicka@gmail.com>]

Hello,
the patch looks good to me. I think in the copyright comment you want to
copy all the years of copyright of original i386.c since the code is not
from 2019. also there are missing licence comments in the .h files.
I would probably put the bigger machine specific optimization passes into
separate files (these have noreason to be globbed).
It will also make it more obvoius that i386 has couple of optimization
passes. Why scalar chain needs to be exported?

I think it would be nice to commit the patch early stage1 :)
Honza



On Mon, Mar 18, 2019 at 3:19 PM Martin Liška <mliska@suse.cz> wrote:

> Hi.
>
> I'm sending first version of the split, which has following
> statistics:
>
>  gcc/config.gcc                  |     5 +-
>  gcc/config/i386/i386-builtins.c |  2563 ++++++++++
>  gcc/config/i386/i386-builtins.h |   314 ++
>  gcc/config/i386/i386-expand.c   | 19868
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  gcc/config/i386/i386-expand.h   |    40 +
>  gcc/config/i386/i386-features.c |  2854 +++++++++++
>  gcc/config/i386/i386-features.h |   179 +
>  gcc/config/i386/i386-options.c  |  3678 ++++++++++++++
>  gcc/config/i386/i386-options.h  |    76 +
>  gcc/config/i386/i386-protos.h   |     4 -
>  gcc/config/i386/i386.c          | 62939
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>  gcc/config/i386/i386.h          |     9 +
>  gcc/config/i386/t-i386          |    16 +
>  13 files changed, 46542 insertions(+), 46003 deletions(-)
>
> The newly created files have following content:
> - i386-builtins.c - builtin-in handling, __builtin_cpu_is and
> __builtin_cpu_supports, target pragma handling
> - i386-expand.c - all scalar and vector expansion code
> - i386-features.c - contains isolated target features - vzerotoupper, stv,
> cet, rpad, multi-versioning,
> - i386-options.c - option related functions, target attribute handling
>
> Now the i386.c file is down in size:
> 23038 gcc/config/i386/i386.c
>
> Question is whether I should continue or not? Remaining content of the
> file is made of
> various costing functions, print_reg*, various target hooks, coff, ms_abi,
> retpolines,
> output-functions, etc. I don't see any further split point which should
> define a new
> file.
>
> Patch:
> https://drive.google.com/file/d/1SiNcR35DHMNBumyg5ltbOozEJ5Q0ajKn/view?usp=sharing
>
> Thoughts?
> Thanks,
> Martin
>