From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id 4E03A3858D33 for ; Sun, 28 Apr 2024 18:16:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4E03A3858D33 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4E03A3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714328212; cv=none; b=tz44/pUkWz2iQ9RK0N5lDZtigxlCeHxqc22n5qYuONDfov+3bmOTRei8nNbWtHmtkMHlctT9RI33P45qZwyrQtIK2T+LM+4Ufisy5wm/mvCS2O4UPEPx5ejVQx4uG28m4jOvYpQitLFukiSVIZ+2GkYKvbd2VGleFKiHe3+f2H0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714328212; c=relaxed/simple; bh=4OuhdFMi1Qx3BDhppVxdpexNE1zvZxxOVOU8WLKvXeo=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=MIhGNOzLTzbLxoehEN40uorTpXll3zdyeR4BTtjQHg2xY+pyx1iS1bAdGCbeAkMlKrJEGdNjmh6e2HViBpUuIwr1sD+spcqtnHA0Vm3Gh6ib2z6JDruLWEfs1tbmQuK1uEF80FB+lVLnx4x0OwhKVt4oYjPhuTfem9UHLNtCqxI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102f.google.com with SMTP id 98e67ed59e1d1-2a2d82537efso2567369a91.2 for ; Sun, 28 Apr 2024 11:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google-com.20230601.gappssmtp.com; s=20230601; t=1714328209; x=1714933009; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=h/982Oq7813Rbg5OH2mcK//MLovs/vaG1FFucP7p4Bs=; b=Jxi23Gw5JuLUoDXWjt0Ontc1+96KbwXNQ8wgy6qLyOj7UjEgVFrHK5cEMceRprQwhr FRJNiCyAJhuEhWC8AigxyU9Jb/E3J/PzZXym7d8ovk71ulZ+z+TM2YkCr0QsIExNrOKm n5gLz+PrGbOrhNlrlV0PNNM8jjQQUe21Itx0TquYQeFjrn+IRgZXDC4b1m2NNtZ1Hhy4 hNmlRangul3L5WLJPR2M3whGwF+x75WyxA8n92W16KyytHQuUtPLM+pe63H42LomuK2e OfXWLg+dj05QVXvbG8W5C6kiUSmgcNfGxasbnTI1hhcnndrFeBXtrc7KKTDhwhm+NwaU ZIRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714328209; x=1714933009; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h/982Oq7813Rbg5OH2mcK//MLovs/vaG1FFucP7p4Bs=; b=eh0uCdAglo+7zGwgghKKCKkhP8SmVd0wH63Px1Hr8xd8fF8rP6YpszKYKzTo+oBmSN mP8I0XcZiQ2s9wOg+VcAJTqQLvPeQg05ILaG0Il2zcelpP1uhevOzOeO5WUBbZ4gNZOO QYGcBF8Hb0EbSmLBVmXsb00JbvoFQWrexCD+2XN0h9v2Mu/ZP1Ta+LSY+lI9EzVTbsKM cxNm5MySJBjx2+X7DYvNnVZOD1jvd+gyGwcJOSMvsJsBkpiaySEs7nCeeq4qt3UAfinp SYnogfSl4LKJ4kM6XRxwp+wQ4Sk94vZ1GLFxQm0gtcpMgAxV1SJ/N6WkSAQdqkeHI0GU ABYw== X-Forwarded-Encrypted: i=1; AJvYcCUi/Mard+dyNTA5FX713n6s+qJ5nnqA9zFd0xcIHufvXrluaspUverVvE7hhKjn6VC6boBWrmWGX3ie2lDluGo= X-Gm-Message-State: AOJu0YwU0bXwLPADRitD/uBTGbyCuv+LC9nbO8I+l0svk+AjNNRbbzll idqTIIeDQVNqid8bO82yBAzVEPnSKKP/liS0HEwwMHHwrsNKiMfeB7CuAGzVVONhLbDobp/83v7 RS+PnsQpHuBTxkNs8MEwWLrNpDFPlmXcrXsXBc6worspr7g1HyA== X-Google-Smtp-Source: AGHT+IHMmk2P7cbLScg5LPWmpV1nkh3lHd9OIlfzQjDOmO6W0lKeORmkqAR+dVlFWqU3RydlOGj1ggY7y6sOfM2Tmes= X-Received: by 2002:a17:90a:b8f:b0:2a2:e56a:ca8f with SMTP id 15-20020a17090a0b8f00b002a2e56aca8fmr8428020pjr.42.1714328208830; Sun, 28 Apr 2024 11:16:48 -0700 (PDT) MIME-Version: 1.0 References: <20230120105409.54949-1-gcc@hazardy.de> <20230120105409.54949-4-gcc@hazardy.de> <0c08e584-499f-473f-8699-a41c6a967536@hazardy.de> <2bb200e6-2ae7-40b0-86a7-24a72532924c@hazardy.de> <25fd32ea-72aa-44b9-bbb5-1e58a446231f@hazardy.de> In-Reply-To: <25fd32ea-72aa-44b9-bbb5-1e58a446231f@hazardy.de> From: Ian Lance Taylor Date: Sun, 28 Apr 2024 11:16:36 -0700 Message-ID: Subject: Re: [PATCH 5/4] libbacktrace: improve getting debug information for loaded dlls To: =?UTF-8?B?QmrDtnJuIFNjaMOkcGVycw==?= Cc: gcc-patches@gcc.gnu.org, gcc@gcc.gnu.org Content-Type: multipart/mixed; boundary="000000000000eb080e06172c23e7" X-Spam-Status: No, score=-15.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000eb080e06172c23e7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 25, 2024 at 1:15=E2=80=AFPM Bj=C3=B6rn Sch=C3=A4pers wrote: > > > Attached is the combined version of the two patches, only implementing = the > > variant with the tlhelp32 API. > > > > Tested on x86 and x86_64 windows. > > > > Kind regards, > > Bj=C3=B6rn. > > A friendly ping. Thanks. Committed as follows. Which of your other patches are still relevant? Thanks. Ian --000000000000eb080e06172c23e7 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvjuqkzz0 OTQyYTljZjJhOTU4MTEzZDJhYjQ2ZjViMDE1YzM2ZTU2OWFiZWRjZgpkaWZmIC0tZ2l0IGEvbGli YmFja3RyYWNlL2NvbmZpZ3VyZS5hYyBiL2xpYmJhY2t0cmFjZS9jb25maWd1cmUuYWMKaW5kZXgg M2UwMDc1YTJiNzkuLjU5ZTljNDE1ZGI4IDEwMDY0NAotLS0gYS9saWJiYWNrdHJhY2UvY29uZmln dXJlLmFjCisrKyBiL2xpYmJhY2t0cmFjZS9jb25maWd1cmUuYWMKQEAgLTM4MCw2ICszODAsMTAg QEAgaWYgdGVzdCAiJGhhdmVfbG9hZHF1ZXJ5IiA9ICJ5ZXMiOyB0aGVuCiBmaQogCiBBQ19DSEVD S19IRUFERVJTKHdpbmRvd3MuaCkKK0FDX0NIRUNLX0hFQURFUlModGxoZWxwMzIuaCwgW10sIFtd LAorWyNpZmRlZiBIQVZFX1dJTkRPV1NfSAorIyAgaW5jbHVkZSA8d2luZG93cy5oPgorI2VuZGlm XSkKIAogIyBDaGVjayBmb3IgdGhlIGZjbnRsIGZ1bmN0aW9uLgogaWYgdGVzdCAtbiAiJHt3aXRo X3RhcmdldF9zdWJkaXJ9IjsgdGhlbgpkaWZmIC0tZ2l0IGEvbGliYmFja3RyYWNlL3BlY29mZi5j IGIvbGliYmFja3RyYWNlL3BlY29mZi5jCmluZGV4IDllNDM3ZDgxMGM3Li40ZjI2Nzg0MTE3OCAx MDA2NDQKLS0tIGEvbGliYmFja3RyYWNlL3BlY29mZi5jCisrKyBiL2xpYmJhY2t0cmFjZS9wZWNv ZmYuYwpAQCAtNDksNiArNDksMTggQEAgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuICAqLwog I2VuZGlmCiAKICNpbmNsdWRlIDx3aW5kb3dzLmg+CisKKyNpZmRlZiBIQVZFX1RMSEVMUDMyX0gK KyNpbmNsdWRlIDx0bGhlbHAzMi5oPgorCisjaWZkZWYgVU5JQ09ERQorLyogSWYgVU5JQ09ERSBp cyBkZWZpbmVkLCBhbGwgdGhlIHN5bWJvbHMgYXJlIHJlcGxhY2VkIGJ5IGEgbWFjcm8gdG8gdXNl IHRoZQorICAgd2lkZSB2YXJpYW50LiBCdXQgd2UgbmVlZCB0aGUgYW5zaSB2YXJpYW50LCBzbyB1 bmRlZiB0aGUgbWFjcm9zLiAqLworI3VuZGVmIE1PRFVMRUVOVFJZMzIKKyN1bmRlZiBNb2R1bGUz MkZpcnN0CisjdW5kZWYgTW9kdWxlMzJOZXh0CisjZW5kaWYKKyNlbmRpZgogI2VuZGlmCiAKIC8q IENvZmYgZmlsZSBoZWFkZXIuICAqLwpAQCAtNTkyLDcgKzYwNCw4IEBAIGNvZmZfc3ltaW5mbyAo c3RydWN0IGJhY2t0cmFjZV9zdGF0ZSAqc3RhdGUsIHVpbnRwdHJfdCBhZGRyLAogc3RhdGljIGlu dAogY29mZl9hZGQgKHN0cnVjdCBiYWNrdHJhY2Vfc3RhdGUgKnN0YXRlLCBpbnQgZGVzY3JpcHRv ciwKIAkgIGJhY2t0cmFjZV9lcnJvcl9jYWxsYmFjayBlcnJvcl9jYWxsYmFjaywgdm9pZCAqZGF0 YSwKLQkgIGZpbGVsaW5lICpmaWxlbGluZV9mbiwgaW50ICpmb3VuZF9zeW0sIGludCAqZm91bmRf ZHdhcmYpCisJICBmaWxlbGluZSAqZmlsZWxpbmVfZm4sIGludCAqZm91bmRfc3ltLCBpbnQgKmZv dW5kX2R3YXJmLAorCSAgdWludHB0cl90IG1vZHVsZV9oYW5kbGUgQVRUUklCVVRFX1VOVVNFRCkK IHsKICAgc3RydWN0IGJhY2t0cmFjZV92aWV3IGZoZHJfdmlldzsKICAgb2ZmX3QgZmhkcl9vZmY7 CkBAIC04NzAsMTIgKzg4Myw3IEBAIGNvZmZfYWRkIChzdHJ1Y3QgYmFja3RyYWNlX3N0YXRlICpz dGF0ZSwgaW50IGRlc2NyaXB0b3IsCiAgICAgfQogCiAjaWZkZWYgSEFWRV9XSU5ET1dTX0gKLSAg ewotICAgIHVpbnRwdHJfdCBtb2R1bGVfaGFuZGxlOwotCi0gICAgbW9kdWxlX2hhbmRsZSA9ICh1 aW50cHRyX3QpIEdldE1vZHVsZUhhbmRsZSAoTlVMTCk7Ci0gICAgYmFzZV9hZGRyZXNzID0gbW9k dWxlX2hhbmRsZSAtIGltYWdlX2Jhc2U7Ci0gIH0KKyAgYmFzZV9hZGRyZXNzID0gbW9kdWxlX2hh bmRsZSAtIGltYWdlX2Jhc2U7CiAjZW5kaWYKIAogICBpZiAoIWJhY2t0cmFjZV9kd2FyZl9hZGQg KHN0YXRlLCBiYXNlX2FkZHJlc3MsICZkd2FyZl9zZWN0aW9ucywKQEAgLTkxNywxMiArOTI1LDYx IEBAIGJhY2t0cmFjZV9pbml0aWFsaXplIChzdHJ1Y3QgYmFja3RyYWNlX3N0YXRlICpzdGF0ZSwK ICAgaW50IGZvdW5kX3N5bTsKICAgaW50IGZvdW5kX2R3YXJmOwogICBmaWxlbGluZSBjb2ZmX2Zp bGVsaW5lX2ZuOworICB1aW50cHRyX3QgbW9kdWxlX2hhbmRsZSA9IDA7CisjaWZkZWYgSEFWRV9U TEhFTFAzMl9ICisgIGZpbGVsaW5lIG1vZHVsZV9maWxlbGluZV9mbjsKKyAgaW50IG1vZHVsZV9m b3VuZF9zeW07CisgIEhBTkRMRSBzbmFwc2hvdDsKKyNlbmRpZgorCisjaWZkZWYgSEFWRV9XSU5E T1dTX0gKKyAgbW9kdWxlX2hhbmRsZSA9ICh1aW50cHRyX3QpIEdldE1vZHVsZUhhbmRsZSAoTlVM TCk7CisjZW5kaWYKIAogICByZXQgPSBjb2ZmX2FkZCAoc3RhdGUsIGRlc2NyaXB0b3IsIGVycm9y X2NhbGxiYWNrLCBkYXRhLAotCQkgICZjb2ZmX2ZpbGVsaW5lX2ZuLCAmZm91bmRfc3ltLCAmZm91 bmRfZHdhcmYpOworCQkgICZjb2ZmX2ZpbGVsaW5lX2ZuLCAmZm91bmRfc3ltLCAmZm91bmRfZHdh cmYsIG1vZHVsZV9oYW5kbGUpOwogICBpZiAoIXJldCkKICAgICByZXR1cm4gMDsKIAorI2lmZGVm IEhBVkVfVExIRUxQMzJfSAorICBkbworICAgIHsKKyAgICAgIHNuYXBzaG90ID0gQ3JlYXRlVG9v bGhlbHAzMlNuYXBzaG90IChUSDMyQ1NfU05BUE1PRFVMRSwgMCk7CisgICAgfQorICB3aGlsZSAo c25hcHNob3QgPT0gSU5WQUxJRF9IQU5ETEVfVkFMVUUKKwkgJiYgR2V0TGFzdEVycm9yICgpID09 IEVSUk9SX0JBRF9MRU5HVEgpOworCisgIGlmIChzbmFwc2hvdCAhPSBJTlZBTElEX0hBTkRMRV9W QUxVRSkKKyAgICB7CisgICAgICBNT0RVTEVFTlRSWTMyIGVudHJ5OworICAgICAgQk9PTCBvazsK KyAgICAgIGVudHJ5LmR3U2l6ZSA9IHNpemVvZiAoTU9EVUxFRU5UUlkzMik7CisKKyAgICAgIGZv ciAob2sgPSBNb2R1bGUzMkZpcnN0IChzbmFwc2hvdCwgJmVudHJ5KTsgb2s7IG9rID0gTW9kdWxl MzJOZXh0IChzbmFwc2hvdCwgJmVudHJ5KSkKKwl7CisJICBpZiAoc3RyY21wIChmaWxlbmFtZSwg ZW50cnkuc3pFeGVQYXRoKSA9PSAwKQorCSAgICBjb250aW51ZTsKKworCSAgbW9kdWxlX2hhbmRs ZSA9ICh1aW50cHRyX3QpIGVudHJ5LmhNb2R1bGU7CisJICBpZiAobW9kdWxlX2hhbmRsZSA9PSAw KQorCSAgICBjb250aW51ZTsKKworCSAgZGVzY3JpcHRvciA9IGJhY2t0cmFjZV9vcGVuIChlbnRy eS5zekV4ZVBhdGgsIGVycm9yX2NhbGxiYWNrLCBkYXRhLAorCQkJCSAgICAgICBOVUxMKTsKKwkg IGlmIChkZXNjcmlwdG9yIDwgMCkKKwkgICAgY29udGludWU7CisKKwkgIGNvZmZfYWRkIChzdGF0 ZSwgZGVzY3JpcHRvciwgZXJyb3JfY2FsbGJhY2ssIGRhdGEsCisJCSAgICAmbW9kdWxlX2ZpbGVs aW5lX2ZuLCAmbW9kdWxlX2ZvdW5kX3N5bSwgJmZvdW5kX2R3YXJmLAorCQkgICAgbW9kdWxlX2hh bmRsZSk7CisJICBpZiAobW9kdWxlX2ZvdW5kX3N5bSkKKwkgICAgZm91bmRfc3ltID0gMTsKKwl9 CisKKyAgICAgIENsb3NlSGFuZGxlIChzbmFwc2hvdCk7CisgICAgfQorI2VuZGlmCisKICAgaWYg KCFzdGF0ZS0+dGhyZWFkZWQpCiAgICAgewogICAgICAgaWYgKGZvdW5kX3N5bSkK --000000000000eb080e06172c23e7--