From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) by sourceware.org (Postfix) with ESMTPS id 194EC3889805 for ; Thu, 30 Mar 2023 18:44:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 194EC3889805 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cs.washington.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cs.washington.edu Received: by mail-ua1-x932.google.com with SMTP id v48so14500028uad.6 for ; Thu, 30 Mar 2023 11:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.washington.edu; s=goo201206; t=1680201865; x=1682793865; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zRTLz1PhdZnFFU/Ej9UBxORYW1eaqFvyWUqdZi2fKe4=; b=DWWvA5myPePVcVhq6ojY5g6vezAAc1DDrejA5c7Vs1XSySuNv4F56UyIb/XWwd+FyE ND0spgfokQqDC/0PSFuh1PJxT9CK+nClFv/IfwSr44EdK+SvlJgQ8PR+RNWxPE6jqO7o morl3dMtDgG6I0/uHjZrh3PurHsG4TRoddUkA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680201865; x=1682793865; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zRTLz1PhdZnFFU/Ej9UBxORYW1eaqFvyWUqdZi2fKe4=; b=AsPBFG1Rwk92nf1QCFfi/fFQPP/I3YEHAJ4Wld6zujxidWbZ0LLaAGmcmQvqo/jieP X6Y8rLKEEvj7xxg5UAjwbVDHn8lr8yPZBXyZlEnYAa6Uj+mX8P4vLPlHUQnvkbzOQmge fmI61ELe57N54FA4wQ2vtjD9jG2AnrGDw9jLu4RDlE0ICCf9kSOUwQtVbnfeVr2Dauqa 7Uf/5MlGy9ZUDooUmIo43Bn34Z2fGNnjy7aJDQw4Sms76H6ccKijq0A747Z8KqaZtuhR ZUfgJNxPZNlKGnHZbcrBNdmSL1IazoU7/TQldvcwO7dAag8x467T3MmDKutJrEpTGhfY zI3w== X-Gm-Message-State: AAQBX9c4OXudurNZaqRVfevKmaTjaDpaAjSjCAO0klm4ETbusgUOUAKC Mn0c/g63uDvAJc5LTfnxDFWYnBAvEdrKloVxhP+87Q== X-Google-Smtp-Source: AKy350ZzvL+FuXgOVJ8WRT1SLN+EmVmZFblYQL2V6v4Cw/KzpA7QplJuC8jNIhVZtmWYLH0O1QxE6BfppNovGmqDVro= X-Received: by 2002:a1f:9f52:0:b0:406:1ef2:7bc7 with SMTP id i79-20020a1f9f52000000b004061ef27bc7mr13181396vke.2.1680201865288; Thu, 30 Mar 2023 11:44:25 -0700 (PDT) MIME-Version: 1.0 References: <7f83711f-5094-6c6d-822b-966293062afc@inria.fr> <32c3f04d-2196-5c3d-0176-f807b1744720@gmail.com> In-Reply-To: From: Ken Matsui Date: Thu, 30 Mar 2023 11:44:14 -0700 Message-ID: Subject: Re: [GSoC] Conflicted Built-in Trait Name To: Jonathan Wakely Cc: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= , libstdc++@gcc.gnu.org, gcc@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I see. Thank you for the clarification! On Thu, Mar 30, 2023 at 5:23=E2=80=AFAM Jonathan Wakely wrote: > > On Thu, 30 Mar 2023 at 09:33, Ken Matsui wrote: > > > > Hi Fran=C3=A7ois, > > > > On Wed, Mar 29, 2023 at 10:11=E2=80=AFPM Fran=C3=A7ois Dumont wrote: > > > > > > Hi > > > > > > Do not hesitate to dig into library doc. Especially this page: > > > > > > https://gcc.gnu.org/onlinedocs/gcc-8.1.0/libstdc++/manual/manual/test= .html > > > > > > You can also find it in your git clone in /libstdc++-v3/doc= /html. > > > > > > You'll see also how to run test in different std modes like --std=3Dc= ++98 > > > to catch the kind of issue reported by Jonathan. > > > > This is what I wanted to know! Thank you so much! > > > > > Regarding your patches I wonder if it's not too splitted. 1 patch per > > > builtin would sound more logical, at least for an easy one like __is_= void. > > > > I see. I will squash is_void-related commits into the commit of > > __is_void implementation. Thank you for pointing it out! > > > Yes, good point, Fran=C3=A7ois. These kind of changes for the front-end a= nd > library should be in one patch. Otherwise, if they were committed > separately then you would create a revision where bootstrap fails. If > the front-end change is committed without the library change, then you > can't build the library because it still uses __is_void which is now a > keyword. If the library change is committed first then you don't break > bootstrap, but you're adding support to the library for a new built-in > which doesn't actually exist (yet). They should be a single revision, > so that the tree can always be built. >