From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by sourceware.org (Postfix) with ESMTPS id 0B6DF39874F6 for ; Thu, 5 Aug 2021 07:36:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0B6DF39874F6 Received: by mail-vs1-xe29.google.com with SMTP id b138so2549483vsd.2 for ; Thu, 05 Aug 2021 00:36:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KV2buondlXk68lMvZ7PY0786gbvRvqTp1AEpTG5S2UQ=; b=PETqy1Yj5oVPyZC9QAJbW8DpogGq4TSRw7drp1osT9kEesp4Q/kFNXua9mpt2E+Y8+ UvFsnbHAn9qjhqcbAzjMHANrdZCnXPIkgp9UqwruT0vNQxMovo5Yq8N7kjneB+12HF26 CxDDT7a886deFtvQNQIbjML520Tgq3SUoAIpPG7KXtZrEsInewlYKqJE15MMj5nvyysw e+/DD7B8yospMjbmCBva5uHABNyDHv0gPK1aZn/RDMFi+hm0FJ46lOS1GI1bitdbo0Pl G9wX6McxEb6LGtsvwEmQbNgiGG2dVKKMUTwIPf1Tnepqu9LtOjjHYoGWcugrlDGDFymB oPVQ== X-Gm-Message-State: AOAM533JITUJSXLhf/5ZcoRMUyG6+XH9CFVpF6cMepiP16Itqh8yhSmL 7rQXtKlM52FY898NR8tzxS0bRGKSS695UZp9IgWx95lexn7wDg== X-Google-Smtp-Source: ABdhPJzyX/goNetVFUoxHYs8wcmvozzZwh5aVTtQS2baNO+9UEynQl15UHubPnNzS5eRECLK7u6exSqh40Y43CtO7g4= X-Received: by 2002:a67:f80f:: with SMTP id l15mr3567434vso.6.1628148971629; Thu, 05 Aug 2021 00:36:11 -0700 (PDT) MIME-Version: 1.0 References: <0532D36E954348E28A2B22812297A5F2@H270> In-Reply-To: <0532D36E954348E28A2B22812297A5F2@H270> From: Hongtao Liu Date: Thu, 5 Aug 2021 15:41:51 +0800 Message-ID: Subject: Re: Suboptimal code generated for __buitlin_ceil on AMD64 without SS4_4.1 To: Stefan Kanthak Cc: GCC Development Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2021 07:36:13 -0000 Could you file a bugzilla for that? https://gcc.gnu.org/bugzilla/enter_bug.cgi?product=gcc On Thu, Aug 5, 2021 at 3:34 PM Stefan Kanthak wrote: > > Hi, > > targeting AMD64 alias x86_64 with -O3, GCC 10.2.0 generates the > following code (17 instructions using 78 bytes, plus 6 quadwords > using 48 bytes) for __builtin_ceil() when -msse4.1 is NOT given: > > .text > 0: f2 0f 10 15 10 00 00 00 movsd .LC1(%rip), %xmm2 > 4: R_X86_64_PC32 .rdata > 8: f2 0f 10 25 00 00 00 00 movsd .LC0(%rip), %xmm4 > c: R_X86_64_PC32 .rdata > 10: 66 0f 28 d8 movapd %xmm0, %xmm3 > 14: 66 0f 28 c8 movapd %xmm0, %xmm1 > 18: 66 0f 54 da andpd %xmm2, %xmm3 > 1c: 66 0f 2e e3 ucomisd %xmm3, %xmm4 > 20: 76 2b jbe 4d <_ceil+0x4d> > 22: f2 48 0f 2c c0 cvttsd2si %xmm0, %rax > 27: 66 0f ef db pxor %xmm3, %xmm3 > 2b: f2 0f 10 25 20 00 00 00 movsd 0x20(%rip), %xmm4 > 2f: R_X86_64_PC32 .rdata > 33: 66 0f 55 d1 andnpd %xmm1, %xmm2 > 37: f2 48 0f 2a d8 cvtsi2sd %rax, %xmm3 > 3c: f2 0f c2 c3 06 cmpnlesd %xmm3, %xmm0 > 41: 66 0f 54 c4 andpd %xmm4, %xmm0 > 45: f2 0f 58 c3 addsd %xmm3, %xmm0 > 49: 66 0f 56 c2 orpd %xmm2, %xmm0 > 4d: c3 retq > > .rdata > .align 8 > 0: 00 00 00 00 .LC0: .quad 0x1.0p52 > 00 00 30 43 > 00 00 00 00 > 00 00 00 00 > .align 16 > 10: ff ff ff ff .LC1: .quad ~(-0.0) > ff ff ff 7f > 18: 00 00 00 00 .quad 0.0 > 00 00 00 00 > .align 8 > 20: 00 00 00 00 .LC2: .quad 0x1.0p0 > 00 00 f0 3f > 00 00 00 00 > 00 00 00 00 > .end > > JFTR: in the best case, the memory accesses cost several cycles, > while in the worst case they yield a page fault! > > > Properly optimized, faster and shorter code, using just 15 instructions > in 65 bytes, WITHOUT superfluous constants, thus avoiding costly memory > accesses and saving at least 32 bytes, follows: > > .intel_syntax > .equ BIAS, 1023 > .text > 0: f2 48 0f 2c c0 cvttsd2si rax, xmm0 # rax = trunc(argument) > 5: 48 f7 d8 neg rax > # jz .L0 # argument zero? > 8: 70 36 jo .L0 # argument indefinite? > # argument overflows 64-bit integer? > a: 48 f7 d8 neg rax > d: f2 48 0f 2a c8 cvtsi2sd xmm1, rax # xmm1 = trunc(argument) > 12: 48 a1 00 00 00 mov rax, BIAS << 52 > 19: 00 00 00 f0 3f > 1c: 66 48 0f 6e d0 movq xmm2, rax # xmm2 = 0x1.0p0 > 21: f2 0f 10 d8 movsd xmm3, xmm0 # xmm3 = argument > 25: f2 0f c2 d9 02 cmplesd xmm3, xmm1 # xmm3 = (argument <= trunc(argument)) ? ~0L : 0L > 2a: 66 0f 55 da andnpd xmm3, xmm2 # xmm3 = (argument <= trunc(argument)) ? 0.0 : 1.0 > 2e: f2 0f 58 d9 addsd xmm3, xmm1 # xmm3 = (argument > trunc(argument)) ? 1.0 : 0.0 > # + trunc(argument) > # = ceil(argument) > 32: 66 0f 73 d0 3f psrlq xmm0, 63 > 37: 66 0f 73 f0 3f psllq xmm0, 63 # xmm0 = (argument & -0.0) ? -0.0 : 0.0 > 3c: 66 0f 56 c3 orpd xmm0, xmm3 # xmm0 = ceil(argument) > 40: c3 .L0: ret > .end > > regards > Stefan -- BR, Hongtao