From: Hanke Zhang <hkzhang455@gmail.com>
To: Martin Jambor <mjambor@suse.cz>
Cc: gcc@gcc.gnu.org
Subject: Re: Question about function splitting
Date: Tue, 3 Oct 2023 01:13:17 +0800 [thread overview]
Message-ID: <CAM_DAs9f-rFXH95CnCyfkj-SWBOqS+6gWxGGGdwGQUv3SJqj5w@mail.gmail.com> (raw)
In-Reply-To: <ri6wmw5j84z.fsf@suse.cz>
Martin Jambor <mjambor@suse.cz> 于2023年10月3日周二 00:34写道:
>
> Hello,
>
> On Mon, Oct 02 2023, Hanke Zhang via Gcc wrote:
> > Hi, I have some questions about the strategy and behavior of function
> > splitting in gcc, like the following code:
> >
> > int glob;
> > void f() {
> > if (glob) {
> > printf("short path\n");
> > return;
> > }
> > // do lots of expensive things
> > // ...
> > }
> >
> > I hope it can be broken down like below, so that the whole function
> > can perhaps be inlined, which is more efficient.
> >
> > int glob;
> > void f() {
> > if (glob) {
> > printf("short path\n");
> > return;
> > }
> > f_part();
> > }
> >
> > void f_part() {
> > // do lots of expensive things
> > // ...
> > }
> >
> >
> > But on the contrary, gcc splits it like these, which not only does not
> > bring any benefits, but may increase the time consumption, because the
> > function call itself is a more resource-intensive thing.
> >
> > int glob;
> > void f() {
> > if (glob) {
> > f_part();
> > return;
> > }
> > // do lots of expensive things
> > // ...
> > }
> >
> > void f_part() {
> > printf("short path\n"); // just do this????
> > }
> >
> > Are there any options I can offer to gcc to change this behavior? Or
> > do I need to make some changes in ipa-split.cc?
>
> I'd suggest you file a bug to Bugzilla with a specific example that is
> mis-handled, then we can have a look and discuss what and why happens
> and what can be done about it.
>
> Thanks,
>
> Martin
Hi, thanks for your reply.
I'm trying to create an account right now. And I put a copy of the
example code here in case someone is interested.
And I'm using gcc 12.3.0. When you complie the code below via 'gcc
test.c -O3 -flto -fdump-tree-fnsplit', you will find a phenomenon that
is consistent with what I described above in the gimple which is
dumped from fnsplit.
#include <stdio.h>
#include <stdlib.h>
int opstatus;
unsigned char *objcode = 0;
unsigned long position = 0;
char *globalfile;
int test_split_write(char *file) {
FILE *fhd;
if (!opstatus) {
// short path here
printf("Object code generation not active! Forgot to call "
"quantum_objcode_start?\n");
return 1;
}
if (!file)
file = globalfile;
fhd = fopen(file, "w");
if (fhd == 0)
return -1;
fwrite(objcode, position, 1, fhd);
fclose(fhd);
int *arr = malloc(1000);
for (int i = 0; i < 1000; i++) {
arr[i] = rand();
}
return 0;
}
// to avoid `test_split_write` inlining into main
void __attribute__((noinline)) call() { test_split_write("./txt"); }
int main() {
opstatus = rand();
objcode = malloc(100);
position = 0;
call();
return 0;
}
next prev parent reply other threads:[~2023-10-02 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 15:59 Hanke Zhang
2023-10-02 16:34 ` Martin Jambor
2023-10-02 17:13 ` Hanke Zhang [this message]
2023-10-04 8:17 ` Richard Biener
2023-10-04 14:22 ` Hanke Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM_DAs9f-rFXH95CnCyfkj-SWBOqS+6gWxGGGdwGQUv3SJqj5w@mail.gmail.com \
--to=hkzhang455@gmail.com \
--cc=gcc@gcc.gnu.org \
--cc=mjambor@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).