From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29978 invoked by alias); 28 Jul 2011 14:24:41 -0000 Received: (qmail 29947 invoked by uid 22791); 28 Jul 2011 14:24:39 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jul 2011 14:24:25 +0000 Received: by qwh5 with SMTP id 5so1561426qwh.20 for ; Thu, 28 Jul 2011 07:24:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.81.198 with SMTP id y6mr79597qck.8.1311863063893; Thu, 28 Jul 2011 07:24:23 -0700 (PDT) Received: by 10.229.98.193 with HTTP; Thu, 28 Jul 2011 07:24:23 -0700 (PDT) In-Reply-To: References: Date: Thu, 28 Jul 2011 14:34:00 -0000 Message-ID: Subject: Re: RFC: PATCH: Require and use int64 for x86 options From: "H.J. Lu" To: "Joseph S. Myers" Cc: Ian Lance Taylor , Uros Bizjak , Igor Zamyatin , gcc@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00493.txt.bz2 On Wed, Jul 27, 2011 at 2:37 PM, H.J. Lu wrote: > On Wed, Jul 27, 2011 at 2:23 PM, Joseph S. Myers > wrote: >> On Wed, 27 Jul 2011, H.J. Lu wrote: >> >>> ; Maximum number of mask bits in a variable. >>> MaxMaskBits >>> ix86_isa_flags =3D 64 >>> >>> It mark ix86_isa_flags as 64bit. =A0Any comments? >> >> The patch won't work as is. =A0set_option, for example, casts a pointer = to >> (int *), and stores a mask that came from option->var_value, which is an >> int, so this won't work with option fields not of type int or values that >> don't fit in int; you'd need to check all uses of CLVC_BIT_CLEAR and >> CLVC_BIT_SET in the source tree to adapt things for the possibility of >> wider mask fields, and track the type of each such field. > > We will prepare a separate patch. > >> Independently, I approve of setting need_64bit_hwint for all x86 targets, >> but your patch doesn't achieve the expected simplification. =A0In >> config.gcc, there are settings for various individual targets that should >> be removed once it's set in one place for all x86 targets. =A0In >> libcpp/configure.ac, similarly the cases for i[34567]86-*-darwin* >> i[34567]86-*-solaris2.1[0-9]* x86_64-*-solaris2.1[0-9]* >> i[34567]86-w64-mingw* i[34567]86-*-linux* (the last only if >> --enable-targets=3Dall) should all be removed as obsolete once >> i[34567]86-*-* is there along with x86_64-*-*. >> > > Is this patch OK for trunk? > > Thanks. > > H.J. > ---- > gcc/ > > 2011-07-27 =A0H.J. Lu =A0 > > =A0 =A0 =A0 =A0* config.gcc: Set need_64bit_hwint to yes for x86 targets. > > libcpp/ > > 2011-07-27 =A0H.J. Lu =A0 > > =A0 =A0 =A0 =A0* configure.ac: Set need_64bit_hwint to yes for x86 target= s. > =A0 =A0 =A0 =A0* configure: Regenerated. > Bootstrapped on Linux/ia32. I am checking it in. Thanks. --=20 H.J.