From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00364e01.pphosted.com (mx0b-00364e01.pphosted.com [148.163.139.74]) by sourceware.org (Postfix) with ESMTPS id 5E49C3858C5F for ; Fri, 4 Aug 2023 15:02:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5E49C3858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=columbia.edu Received: from pps.filterd (m0167076.ppops.net [127.0.0.1]) by mx0b-00364e01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 374E70WT025195 for ; Fri, 4 Aug 2023 11:02:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h=mime-version : references : in-reply-to : from : date : message-id : subject : to : cc : content-type : content-transfer-encoding; s=pps01; bh=pjbKxugFN5UOiNjnvNwYponAzb0z5qR3qNfu8iVbOnQ=; b=X4WH8/DO+CbHh+8JUmRshkvnAkhEzJdmYFUutk6Dk29BjoZ31U9pzojdJVM9Gqp7zA+F xXvFYYQs5lHHv99LQIMWM205KgKo2lKHsfNkVrDXgJ0aMrsalmyDDnRfYWw5AKqjhxqP d52AWBrRC4Ekd0GeDniZmRsuGN+nPSwyqIwEp7HOuZXB2yTHjMcl8eV/24S5a7x84IrS S/3RXaP9KGe28YvT9luqkHXrAG4domcIEhHMPFaMNQqj/B+uqaD5RpgQReAPps0Lu1s5 C9Jly52UFBwamShM+IT+y3H3T3suxPg9ZBL3w4TaDH9EKhcgNqT02F2NlC3SL6w0rkts 0A== Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by mx0b-00364e01.pphosted.com (PPS) with ESMTPS id 3s8kg24f4j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 04 Aug 2023 11:02:42 -0400 Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-6bc807e99adso3251196a34.2 for ; Fri, 04 Aug 2023 08:02:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691161361; x=1691766161; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pjbKxugFN5UOiNjnvNwYponAzb0z5qR3qNfu8iVbOnQ=; b=d/uyB2Lzq0P2NsbCHmOcxBem5w6yJ6YLOAahkm1d+G3b2shOIk5aeMHrawaL+M1pAQ xX7BnoZp2tI2kmgMX4eII9W2Bsx1fqchYbfPO7a4kiJEZkq5BvUqGNbmRQ+6WSd/E1zB wjzrlp4gi1QPWLVehAG2SG8KZmrxoygOtsyeYOie5BLBzv/oKl/RUEEEWicTaCYGwzj4 gC1EnK2lK0lH1cX6rqCWJUtvuUZx0mUjzsY/Ns6hF8TjsOHODCAW6L++TNh2kNtCR42M ZRiVI5EsV3hNmnyJx/q+685+VAvXtfzDqaUZ+KUwsndb4+B37kPhkhZsa6L0wlR0ZeHI Zvdw== X-Gm-Message-State: AOJu0YywR8G7hZSEJVMmaIwfzIVpQpvd3emiTPBEHtda6H7Sqr5Ozyl7 Vlt15+h8+pgZDNK2T5D9ieKicDIly3VW/BXbM4NgpAWkPlaCSO6wMaq6iw9xGKTLYvK2E2YgJMy we/pRDpai4jZJLjElTBOF X-Received: by 2002:a05:6358:430e:b0:132:d333:4a5c with SMTP id r14-20020a056358430e00b00132d3334a5cmr2427096rwc.10.1691161361229; Fri, 04 Aug 2023 08:02:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHFXJbiFMUfJrVBTbKEiyBWwViNKlYt3w/sTATd0srx3hdssa0K8j6YEmW5JUdTay5oDX9p/TMaNKi4Bw401fI= X-Received: by 2002:a05:6358:430e:b0:132:d333:4a5c with SMTP id r14-20020a056358430e00b00132d3334a5cmr2427056rwc.10.1691161360848; Fri, 04 Aug 2023 08:02:40 -0700 (PDT) MIME-Version: 1.0 References: <969057b59e5cf472b73e8e1dedcc4a46630b31a0.camel@redhat.com> <6050a30719fed76a5bdb36c00620f4cb44e00aad.camel@redhat.com> In-Reply-To: From: Eric Feng Date: Fri, 4 Aug 2023 11:02:29 -0400 Message-ID: Subject: Re: Update and Questions on CPython Extension Module -fanalyzer plugin development To: David Malcolm Cc: gcc@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: KOvJr7r77hyjgIVFwlAnz0jUK8LVJRq0 X-Proofpoint-GUID: KOvJr7r77hyjgIVFwlAnz0jUK8LVJRq0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-04_13,2023-08-03_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 clxscore=1015 mlxscore=0 spamscore=0 phishscore=0 mlxlogscore=999 impostorscore=10 lowpriorityscore=10 adultscore=0 bulkscore=10 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308040132 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Dave, Tests related to our plugin which depend on Python-specific definitions have been run by including /* { dg-options "-fanalyzer -I/usr/include/python3.9" } */. This is undoubtedly not ideal; is it best to approach this problem by adapting a subset of relevant definitions like in gil.h? Best, Eric On Tue, Aug 1, 2023 at 1:06=E2=80=AFPM David Malcolm = wrote: > > On Tue, 2023-08-01 at 09:57 -0400, Eric Feng wrote: > > > > > > My guess is that you were trying to do it from the > > > PLUGIN_ANALYZER_INIT > > > hook rather than from the plugin_init function, but it's hard to be > > > sure without seeing the code. > > > > > > > Thanks Dave, you are entirely right =E2=80=94 I made the mistake of try= ing to > > do it from PLUGIN_ANALYZER_INIT hook and not from the plugin_init > > function. After following your suggestion, the callbacks are getting > > registered as expected. > > Ah, good. > > > I submitted a patch to review for this feature > > on gcc-patches; please let me know if it looks OK. > > Thanks Eric; I've posted a reply to your email there, so let's discuss > the details there. > > Dave >