From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=6dwF=4M=gmail.com=gntengetta@sourceware.org>
Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435])
	by sourceware.org (Postfix) with ESMTPS id 4726E383557B
	for <gcc@gcc.gnu.org>; Wed, 14 Dec 2022 17:27:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4726E383557B
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-pf1-x435.google.com with SMTP id 21so4951401pfw.4
        for <gcc@gcc.gnu.org>; Wed, 14 Dec 2022 09:27:35 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=to:subject:message-id:date:from:mime-version:from:to:cc:subject
         :date:message-id:reply-to;
        bh=DXeW2+T3QhKlgJBk+ZdPM4zAgy3fREsjTs09cy5uX+c=;
        b=hdJ2EW9xtl6YYFmr0Pbuwul3actqQtrPUF0M1dHZzmQzDolufr1zKcL8KWyB40lLMF
         0byYeXP8VAu7fQjYoLsyAR2q39EkD0Mk5STKdgGY9eU7Zn1Nd7ePcG4aftOkOWEk7gjm
         Ceh9al1Q5YfU6kmScZ+4eq3aB78P+BzgoRyNX1amgkCq4vZNLKLB2Okva6Scp/v9CTUn
         wqUSEmAUmaVvLjPLoG7bZTFoMeG6Pq7ysDJe1kBT2xCCgLo2NlegT4zXWDpCO2XeJX1O
         ZuBCvPebleiwTFCfyyzHwRVR3iWrclLO98jrvpUCwin/Ap0Qr5MB3JsdxyN1riYAf33J
         C/vA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=to:subject:message-id:date:from:mime-version:x-gm-message-state
         :from:to:cc:subject:date:message-id:reply-to;
        bh=DXeW2+T3QhKlgJBk+ZdPM4zAgy3fREsjTs09cy5uX+c=;
        b=aFHeIaGtXKh+aRya/UBA26Vf3o/01RK473lb8mOkld81eQkx74+9/LO4FJZ/5Pw3+S
         UbzeJG2T2haXAzKNl2lGMzUqHLQHcO93sOErhAjCTpylUe8RE0IFhfSVE3yLWU4p914g
         RSNnvtpursJTp9pDj7DubrMeDpa6Z5WhBl1UH9XAIxhFWp7uNrwoZfNcRb940ZeZ9Q1c
         nB6rcvPclAi3+XPPdEG/qgulsa7HscFvAGSpUic//34RwVqBUDX3FNGvNELT0bZ/E/Nt
         sLIesyHvEEDJgd/M8lQ7IUQcVfqlgspH9o8criNGA6LCi4+ADmBy1X8MRQKSP7VkfJCo
         suxA==
X-Gm-Message-State: ANoB5ploqD2LkaHPa4GpXTFhHOrmPsgfeLpcP14uVB+Pgo8KAYJKAMy1
	8YF0EFC/rUiyJUOQ5Ro3f2K1uMkFooZfWQSPLmHEEIXNOqk=
X-Google-Smtp-Source: AA0mqf5lmH5WRpe0xNkjSbMkZj5G52vZRdV7IH6OymmQ6XaUq9mGBfTPjZQ3IRB31sHYdlasNBT5XbG86t5CrQe28zs=
X-Received: by 2002:a63:5a0d:0:b0:47c:979b:7234 with SMTP id
 o13-20020a635a0d000000b0047c979b7234mr360976pgb.625.1671038854241; Wed, 14
 Dec 2022 09:27:34 -0800 (PST)
MIME-Version: 1.0
From: "G.T." <gntengetta@gmail.com>
Date: Sat, 17 Dec 2022 04:25:54 -0500
Message-ID: <CAOBJmmsDctppVOtFs_K=-ag31X2sUv2cu+QdHuJcv2KB5Bgktw@mail.gmail.com>
Subject: Possible dead code in file lra-spills.cc
To: gcc@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_48_96,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc.gcc.gnu.org>

At line 276, lra_assert (spill_class != NO_REGS); would trigger
whenever execution reached here with spill_class equal to NO_REGS.
Seems to me that would never happen. Because one of the conditions in
the if statement right above it (line 265) catches spill_class ==
NO_REGS and causes the rest of the for loop to be skipped by executing
continue in the consequent of the if. So lra_assert never sees
spill_class == NO_REGS. That makes line 276 dead code, right?

Thanks.
GT.