From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by sourceware.org (Postfix) with ESMTPS id 3837A3858C62 for ; Mon, 20 Feb 2023 13:55:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3837A3858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb36.google.com with SMTP id v78so1345523ybe.3 for ; Mon, 20 Feb 2023 05:55:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=lPenmCAyMbW6Nk4D9MHZbf2IFWW/J5AStEaeq7UOJcM=; b=MquE0SFbzUv7XOj81p6p4fqERUzDNPTpnU6kAGf4+nBtpJUUHPV0iJOOykXThqbflP vIwCmZrnpHP5+yfaD4echLIrlFxm/8e78D1NA3T2ctRTuhLFPkgZ1qYG5HpSFuDcDTyy kUknA9R/5L/btDuA318jnSamiffHcajVlQl9UPS6Y2nKjVXb1Ii+Flbt5sH1PZDyzf3/ 4WecbNefXDjwRmRfq9YRYeyKU4ZgZ9jfgadUHxsbTIh6oLLMc9nOdblTD0jffm731yRM iQTDXVlo+PkQe0YqH8QO/yjjljxWfah92nG+u1qSHZXzTL2/iZ8el9ZJfyonFOIbgsbJ IDdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lPenmCAyMbW6Nk4D9MHZbf2IFWW/J5AStEaeq7UOJcM=; b=0NVIS24ts/To/8i9Q9rwYsVnPoqiHMG90NvGH2Ro64IF8W4978CnK7ikU308FSGMPp lHgXanXHos1712CZD2O7LvXttCgpfdsuP3oi7kYwVedL5s6JfqnfsBQxObigtheKDp1P lCupPdrkehB1scUCemHuKYEBKX24uuUj7OcWxq/uA0e81SAM3xdqdfHEA09Be5CBzcMG 1QEOdLWoh0mluIcnJFSv2kzYUs9A4xKIE/Oi62YoQku6/Dy+bV0a8zMELXf51JhfRAuo N6UUvxvOaaDFkniAauLQGJogsxFoViNKG5NEBJsUJ++8LpY0cfBbhmWpHwJsw0JXLWus bGtA== X-Gm-Message-State: AO0yUKUdOAfckoz5a9zowkWES3DB0ltzKiOChc2VH5P549J9LuWIdX+D mQu7qxk27hCdvaiFl5vk/+Yo0VKOPcluASozBlT5pQ6/8bM= X-Google-Smtp-Source: AK7set+PhKpYk2RGtcVZ65oAErzn2OUIt3Q9djot1aIchL9gKLGWZSUUaPWs336uvk1z3fqgCbwGG/OBUijDt/ZaXps= X-Received: by 2002:a05:6902:2c3:b0:974:ed01:881a with SMTP id w3-20020a05690202c300b00974ed01881amr252147ybh.681.1676901335463; Mon, 20 Feb 2023 05:55:35 -0800 (PST) MIME-Version: 1.0 From: Vincent Fazio Date: Mon, 20 Feb 2023 07:55:24 -0600 Message-ID: Subject: MicroBlaze symver attribute support To: gcc@gcc.gnu.org Cc: eager@eagercon.com Content-Type: multipart/alternative; boundary="0000000000006c803905f522047f" X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000006c803905f522047f Content-Type: text/plain; charset="UTF-8" Michael, all, Regarding: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101766 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102110 If I understand correctly, since the GCC MicroBlaze targets generate ELF images, it would seem there's no technical reason why `__attribute__ ((symver ...))` cannot be supported? The issue seems to be that the MicroBlaze targets in config.gcc do not include elfos.h https://github.com/gcc-mirror/gcc/blob/master/gcc/config.gcc#L2369 Which defines `ASM_OUTPUT_SYMVER_DIRECTIVE` https://github.com/gcc-mirror/gcc/blob/master/gcc/config/elfos.h#L259 Which is necessary for https://github.com/gcc-mirror/gcc/blob/master/gcc/varasm.cc#L6260 Changing the targets to include elfos.h leads to a number of conflicts with the target specific header (config/microblaze/microblaze.h). Should `ASM_OUTPUT_SYMVER_DIRECTIVE` be copied into config/microblaze/microblaze.h or should the MicroBlaze targets and header be reworked to support elfos.h? I'm asking because I've seen a number of projects run into this issue (xz, elfutils, libfuse, libkcapi, cryptsetup). Thanks, -Vincent --0000000000006c803905f522047f--