public inbox for gcc@gcc.gnu.org
 help / color / mirror / Atom feed
From: Julian Waters <tanksherman27@gmail.com>
To: gcc@gcc.gnu.org
Subject: [PATCH] Basic asm blocks should always be volatile
Date: Wed, 28 Jun 2023 00:01:27 +0800	[thread overview]
Message-ID: <CAP2b4GMm_4PxQMicPuBOs8ajL-5EdVx-buzOTT5xyScV96EHWQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

gcc's documentatation mentions that all basic asm blocks are always volatile,
yet the parser fails to account for this by only ever setting
volatile_p to true
if the volatile qualifier is found. This patch fixes this by adding a
special case check for extended_p before finish_asm_statement is called

From 3094be39e3e65a6a638f05fafd858b89fefde6b5 Mon Sep 17 00:00:00 2001
From: TheShermanTanker <tanksherman27@gmail.com>
Date: Tue, 27 Jun 2023 23:56:38 +0800
Subject: [PATCH] asm not using extended syntax should always be volatile

---
 gcc/cp/parser.cc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc
index a6341b9..ef3d06a 100644
--- a/gcc/cp/parser.cc
+++ b/gcc/cp/parser.cc
@@ -22355,6 +22355,9 @@ cp_parser_asm_definition (cp_parser* parser)
       /* Create the ASM_EXPR.  */
       if (parser->in_function_body)
  {
+          if (!extended_p) {
+            volatile_p = true;
+          }
    asm_stmt = finish_asm_stmt (asm_loc, volatile_p, string, outputs,
        inputs, clobbers, labels, inline_p);
    /* If the extended syntax was not used, mark the ASM_EXPR.  */
-- 
2.35.1.windows.2

             reply	other threads:[~2023-06-27 16:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27 16:01 Julian Waters [this message]
2023-06-27 16:08 ` Andrew Pinski
2023-06-27 16:15   ` Julian Waters
2023-06-27 16:15     ` Julian Waters
2023-06-27 16:24       ` Andrew Pinski
2023-06-27 16:23     ` Andrew Pinski
2023-06-28  7:31       ` Julian Waters
2023-06-28  7:38         ` Andrew Pinski
2023-06-28 10:43           ` Julian Waters
2023-06-28 15:04             ` Michael Matz
2023-06-28 18:46               ` Andrew Pinski
2023-06-29  6:42                 ` Julian Waters
2023-06-29 13:27                   ` Michael Matz
2023-06-30  6:11                     ` Julian Waters
2023-06-27 16:07 Julian Waters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAP2b4GMm_4PxQMicPuBOs8ajL-5EdVx-buzOTT5xyScV96EHWQ@mail.gmail.com \
    --to=tanksherman27@gmail.com \
    --cc=gcc@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).