From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 9565A382F987 for ; Fri, 20 May 2022 15:59:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9565A382F987 Received: by mail-wm1-x335.google.com with SMTP id bd25-20020a05600c1f1900b0039485220e16so5197575wmb.0 for ; Fri, 20 May 2022 08:59:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j/Zuoi6VmM5Yn/NCMwWfoayEGQqc1S6+DQOrb+USJd0=; b=HcA9IzPf96LteESRxHl+AI9IwBKHxUmJcTDoQ2fCwng2GBBREBwVJosJvM6+vCR6ew LmbgTuj/BSTouSCHoL+v2nlYHoO2jl5E9ukKdzT0bmIR/JeeQ5QXpsR/Pm1AWBEqXLp9 CHmCGGgHPNPn1XFnMgWrSkkeph9FgtDLoWKQCeaR3BbwIjDpKR9j9AAaiBjIeE9D/yCA 8xNVlZlBPcC/SfRlTtCI0R2FxEJ83Jh+zc1ErKW/tIVnehYCsdIPuMN4gthgf2wSdXlB R9igGEEmgobevDQ/XLEeX1jEx3ZEsqvMqOHYX/T7sBXo7xqckC23zyiHAgOmYdhH3EP/ CPdg== X-Gm-Message-State: AOAM532kKE+ACPstMdCQUVxyt2iic6ShmhCp+OQvghlQR61XUE7GOsi1 ne81UGYJgUKFUa3xm+U/eM+0iloLkdE3jond1hA= X-Google-Smtp-Source: ABdhPJzaF7raFJoqEcwl3jxWZVUg7CGlZVS3rGM9cAljBFmZUegh5074ROEv3jOyoJwQKZQ/U6bCNDY2byQVqSRizt8= X-Received: by 2002:a05:600c:ad4:b0:397:3e2e:ed6d with SMTP id c20-20020a05600c0ad400b003973e2eed6dmr690720wmr.8.1653062351247; Fri, 20 May 2022 08:59:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mohamed Atef Date: Fri, 20 May 2022 17:58:59 +0200 Message-ID: Subject: Re: problem with Makefile.in generation in lingomp To: Jakub Jelinek Cc: gcc@gcc.gnu.org X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HTML_MESSAGE, KAM_LOTSOFHASH, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 15:59:14 -0000 I am really sorry. =D9=81=D9=8A =D8=A7=D9=84=D8=AC=D9=85=D8=B9=D8=A9=D8=8C =D9=A2=D9=A0 =D9=85= =D8=A7=D9=8A=D9=88=D8=8C =D9=A2=D9=A0=D9=A2=D9=A2 =D9=A5:=D9=A5=D9=A8 =D9= =85 Mohamed Atef =D9=83=D8=AA=D8=A8: > In fact that's why i downloaded the repo again i forget to modify the > copyright and when i tried to repush but i got an error As my branch is n= ot > updated i wanted delete the branch and create new one and push again. > If you have the authority to remove the last batch please do. > > =D9=81=D9=8A =D8=A7=D9=84=D8=AC=D9=85=D8=B9=D8=A9=D8=8C =D9=A2=D9=A0 =D9= =85=D8=A7=D9=8A=D9=88=D8=8C =D9=A2=D9=A0=D9=A2=D9=A2 =D9=A5:=D9=A5=D9=A2 = =D9=85 Jakub Jelinek =D9=83=D8=AA=D8=A8: > >> On Fri, May 20, 2022 at 11:53:36AM +0200, Mohamed Atef wrote: >> > I use 1.15.1. >> > This is the link to the line I mentioned. >> > >> https://github.com/gcc-mirror/gcc/blob/master/libgomp/plugin/Makefrag.am= #L29 >> >> You shouldn't be running autoreconf, just automake to regenerate >> Makefile.in, and when I run it, it certainly doesn't emit that error. >> >> Anyway, can you explain the >> https://gcc.gnu.org/g:c7a99c5953487c4dd6cdce1b01126ac2b06f16cd >> commit? That makes the branch quite useless. >> The point is that all commits pushed to gcc trunk have to have proper >> ChangeLog in the commit log to describe the actual changes in that commi= t. >> Commits aren't allowed to be pushed there unless they satisfy the >> checking. >> On development branches this isn't checked on commits, but if those >> branches are meant to be usable for commits to trunk later, they need to >> follow those rules (as I said, git gcc-verify should check it). >> I suppose the 8b5ad311eac66b0939a1e6473a46f68e31158bfe commit might have >> passed it, but I don't see how c7a99c5953487c4dd6cdce1b01126ac2b06f16cd >> could, you've used the same ChangeLog entry but that doesn't describe >> the changes you've done in that commit, you've reverted some Makefile.am >> changes (why?), removed the FSF Copyright lines (that is ok but it shoul= d >> have been replaced by the Copyright The GNU Toolchain Authors. line in >> that >> case), but the ChangeLog then would need to describe those changes. >> >> Jakub >> >>