From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 14E0F3846401 for ; Fri, 5 Apr 2024 07:22:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14E0F3846401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 14E0F3846401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712301760; cv=none; b=MjAsHlrXMznLmvMXJL/SQZVJVzbJ3iS+b9jsNgjF4FAC7KDizE/i4SZpRPTn6JPdu2+jjMqjPLSCei2Gom6cKf1795B5IQ+dNNEeAAelrDxPX+CtROBp1w0qADlz+fqD3gJb3cs9kzUbo6JrsE05PwTIYr4ct+HqUuE+nQXhoHc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712301760; c=relaxed/simple; bh=RlKxn1gRY735/SILHw9ciEloZggKTThjMghKFspQkVs=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=V4Y9MUPSb6yf5MRHU6dBwaIokJLgEnbDVLrYYuPjoxBaYw5IoJFgvBaXyRJwSN+TlCzsDvkllp/fCA2IEpspUWSLrIC1aIHM8hpneyfF3x0XnRYrLQAUuzGUGbpDJKmwCzyu0mPFJHH6nbtH1mPvV3ACiREBVwbThcwXxyd0kVI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a51a1c8d931so56443466b.0 for ; Fri, 05 Apr 2024 00:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712301756; x=1712906556; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RlKxn1gRY735/SILHw9ciEloZggKTThjMghKFspQkVs=; b=XRKisBxAjiAgxorQofU1fTyuTxWwlMo+RcejVqhjXxtRUuvEjAhgNq7WEc9lgxJaoo nMT5gV3hMAzf3umv05L2+ZeOY6jkuocvtsKjh0MMYSz9t1SCeJmvhiRuSJEg7UXphUOn +kGc/LpRepFBS3/YT2fVppP0izG4pqcH3s0vD14NDvuuK1DRD5BeXMSRJGL9jrwcfAic rRfwk72q5B9S8qUPYJ8/xWYw9rBuup5R36yH9Dnxd6OMrsKOc5mVApIyVgd5nSqxUXXY qvmO/fmQKH5k1rcx8jvszaJiWzPAf7wNrGtNlkir3nRJc1U2Ks86/3V4CZ3Lcfrnk75n Fgug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712301756; x=1712906556; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RlKxn1gRY735/SILHw9ciEloZggKTThjMghKFspQkVs=; b=PooNP8IlP3HuWrZMqlQODjLOk6ydr3LOB6nMZz1x2k1vTdnKOnLy+Ot1obSwPRlAIt k6mis+dEMSf2087W0CzxkcpnaHQJ92UtqxNIvGAvKH5uEnL2c3JtMp9pyv0z048fet6o 3GmFzA93iMsOjNwp8H4kHkZ9I9JRHeN6Mkl9bwvQ7X7HAUjxvbOOYFpkemNtCVbJ0j1S vViQ/ArkMtRF1VY1nYuVWhw1qIJ143gW+TuE8XZwT9E1Y/rRLIa3S8i1Q04Sxd2Tl79x baW6QUrBeWkMpuE2pNwD0k44QEUGGQId2uaJDdnBWjSmVwrIaa1vMPKYAEsVlZhWoAux SwFQ== X-Forwarded-Encrypted: i=1; AJvYcCXpv/Wb5W0/tEtd5Qwn7I0h5Pq73xyiV6oaac0g9cEojVVNKD+/v7bdrsiYfvXMoYjrK+kq9gNoII99Aw+lY8k= X-Gm-Message-State: AOJu0YzAvnT1NxWsdINKQLcDNAXXsNrAjBEiULPgaSDWFwezPSVeKh06 Cx8BjRXJQx392uDC2tX2Ow88Hub4io7+02BBCBuZYbQ2G4Dyl9WRyGdFTY3LjTYHjcCJ3s10/fH N3F5R7G/2tHGx7YORz47pSgLfCtr95Z/HRlI8mA== X-Google-Smtp-Source: AGHT+IHmRvujbWjF8S10baq+jZrZy3TYWmhsvc4lFRP5TuKBRSqNbPgwOfXvnhjGkZ5z1lYqMX5E/Hr4IeKcBcj3GMI= X-Received: by 2002:a17:906:f847:b0:a4e:114e:25cb with SMTP id ks7-20020a170906f84700b00a4e114e25cbmr354008ejb.53.1712301755712; Fri, 05 Apr 2024 00:22:35 -0700 (PDT) MIME-Version: 1.0 References: <0d343d67-33e0-4f63-b385-8ae360bc68dc@suse.com> In-Reply-To: <0d343d67-33e0-4f63-b385-8ae360bc68dc@suse.com> From: Christophe Lyon Date: Fri, 5 Apr 2024 09:22:28 +0200 Message-ID: Subject: Re: Patches submission policy change To: Jan Beulich Cc: Maxim Kuvyrkov , Thiago Bauermann , Adhemerval Zanella , binutils@sourceware.org, GCC Mailing List , gdb@sourceware.org, Nick Clifton , Richard Biener , Jakub Jelinek , Joel Brobecker , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 4 Apr 2024 at 10:12, Jan Beulich wrote: > > On 03.04.2024 15:11, Christophe Lyon wrote: > > On Wed, 3 Apr 2024 at 10:30, Jan Beulich wrote: > >> > >> On 03.04.2024 10:22, Christophe Lyon wrote: > >>> Dear release managers and developers, > >>> > >>> TL;DR: For the sake of improving precommit CI coverage and simplifyin= g > >>> workflows, I=E2=80=99d like to request a patch submission policy chan= ge, so > >>> that we now include regenerated files. This was discussed during the > >>> last GNU toolchain office hours meeting [1] (2024-03-28). > >>> > >>> Benefits or this change include: > >>> - Increased compatibility with precommit CI > >>> - No need to manually edit patches before submitting, thus the =E2=80= =9Cgit > >>> send-email=E2=80=9D workflow is simplified > >>> - Patch reviewers can be confident that the committed patch will be > >>> exactly what they approved > >>> - Precommit CI can test exactly what has been submitted > >>> > >>> Any concerns/objections? > >> > >> Yes: Patch size. And no, not sending patches inline is bad practice. > > Not sure what you mean? Do you mean sending patches as attachments is > > bad practice? > > Yes. It makes it difficult to reply to them (with proper reply context). Agreed. > > >> Even assuming sending patches bi-modal (inline and as attachment) work= s > >> (please indicate whether that's the case), it would mean extra work on > >> the sending side. > >> > > For the CI perspective, we use what patchwork is able to detect as patc= hes. > > Looking at recent patches submissions, it seems patchwork is able to > > cope with the output of git format-patch/git send-email, as well as > > attachments. > > There are cases where patchwork is not able to detect the patch, but I > > don't know patchwork's exact specifications. > > Question was though: If a patch was sent inline plus attachment, what > would CI use as the patch to apply? IOW would it be an option to > attach the un-stripped patch, while inlining the stripped one? > Sorry, I don't know how patchwork would handle such a case. Thanks, Christophe > Jan >