From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id A5B59385841A for ; Mon, 18 Mar 2024 17:28:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A5B59385841A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A5B59385841A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710782911; cv=none; b=x9NERkbrE9OVXkrnWdq30wgFz3P4arM8S1YrKXXOyDHYqwaNMWldwEc89zEdhjW/QOArOe0F46m3KK3ic2AiQIm9XbjkfF2sHAyg9GTD+JpgPOOzdkXpXllVBpoikRtJCb0vK0b4SDdb+6lIcv11bW9WyQVip/TdTkzoKzxyMyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710782911; c=relaxed/simple; bh=SJmBLQlQERY6vQYYNWeQyV7nLkpfQXLtFdFTLZgqLGg=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=kW2Yx5vDJDV6V3guZpgefABQmrBAhmIOsVU+pm0H1PCiqZNWEN/9ygoFqrONAHcdwAcC1WJURBU0NPVRKQZQmLVhKB0PnG8BypqzqecY3AYVN3Srqcr5huNNV+WN9BzO+/mheVgp8P1qgcLm4/wjzaJ5/VhBS6VceGPWHEevFx8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a28a6cef709so696399066b.1 for ; Mon, 18 Mar 2024 10:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710782907; x=1711387707; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jSvQh+BEKUpJ0td03AVsH9AmVcpLM4fQPR4wDJiM9Qo=; b=dXChL+3glPl7CSJHDvO96pU/stkECBHFGC21D3uAH1IGdxRA2r4fuDlvzP7Zdj+af3 ZIIJt3HpKnIcX0UNLCKZQ3zPAyEGss5csOiIs/fzp0PnL/oM6VQ5vpWiMeoK6FCWvuH/ Bk8lVL1fpTRh9D7wgtwkRoLkXiCod02GYOPNH7MCr9cacnSNKA0rAN3iSs+LP5tcvYwF GdNIwLEBTVyH4Fcrnl0kd+rvCJbolNfDxm5Bs6w3Zcc8WrkQxMz9OK7mSIVA0JwBkIwi uWDfBN3/W9xZPQ1LUdHOpUkwOgqfhmHtlIj7ki7OULOcG0mYFU4UsfXvQrmBTUyqkudd mhag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710782907; x=1711387707; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jSvQh+BEKUpJ0td03AVsH9AmVcpLM4fQPR4wDJiM9Qo=; b=XyKAzS+H77ob/xcaFZDRo21lYaBQuVmT4cicUWxrnuU349D7am6G66BjeZnJrvmT9h s2DIg26TdrzPF3h64VUYE/AxAVXjtOqhC/DwK9JkSFH5+0JKglS3V/V5HiFkDiMIt5m5 x/KECY7pc609zfLy51+qIiw9niNvsBERYipFxS2rlftPAl8hWo9LCT307gNUTZ2dhM6A jV7W4ZIH6sSGCLNlxvX8Gx40QcOXTowFKZqGy1W8WiCavN6suF7PUzTnjLw1KDW1fzmm V6ZJ0HTrjvGMbqQmrIrSG40J5lbBG9FCMqn7y7xQlYMb+HWFCr/S2gs8cdQQRWSrbAfL vrPg== X-Forwarded-Encrypted: i=1; AJvYcCWicYeud+fJy3g7PSnkFvWYq/1voaG/BIRt6VaWKVhX7+XXoUEfeQpX5C1au1Fm5X9ExmtYJvHmEnnUdA53a5M= X-Gm-Message-State: AOJu0YwacOu9NDZBhZivKtu0Pj0SB7S2rogv7wm3eHmO+lu3O51JFwp9 85agBolrLzGnMxG1d7xCcr/O6uNBp9lEswJpbM7aHkP+3y7uyNUPwAsi5oyiFn6KuDAnc0J6ajE wpbtoJJ9VlmyJ8/PxmCux8Ls/1FXkfP9JVlFNRw== X-Google-Smtp-Source: AGHT+IFmaW5XlhrEWOFpmblkiUxkVihgTrwukSRnJBL22V5cwQDlliwE54u4V+fji82bqVt74zbTzMRDPS+PEXJsg0o= X-Received: by 2002:a17:906:ca56:b0:a43:e550:4067 with SMTP id jx22-20020a170906ca5600b00a43e5504067mr7600593ejb.12.1710782907310; Mon, 18 Mar 2024 10:28:27 -0700 (PDT) MIME-Version: 1.0 References: <20240313080237.1143034-1-christophe.lyon@linaro.org> <1eb529f2-3842-4090-a8e2-f713a28f2394@simark.ca> <87edcbk1x3.fsf@tromey.com> In-Reply-To: <87edcbk1x3.fsf@tromey.com> From: Christophe Lyon Date: Mon, 18 Mar 2024 18:28:16 +0100 Message-ID: Subject: Re: [RFC] add regenerate Makefile target To: Tom Tromey Cc: Eric Gallager , Simon Marchi , binutils@sourceware.org, gdb@sourceware.org, gcc@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 15 Mar 2024 at 15:25, Tom Tromey wrote: > > >>>>> "Eric" == Eric Gallager writes: > > Eric> Also there are the files generated by cgen, too, which no one seems to > Eric> know how to regenerate, either. > > I thought I sent out some info on this a while ago. > > Anyway what I do is make a symlink to the cgen source tree in the > binutils-gdb source tree, then configure with --enable-cgen-maint. > Then I make sure to build with 'make GUILE=guile3.0'. > > It could be better but that would require someone to actually work on > cgen. > > Eric> And then in bfd there's that chew > Eric> program in the doc subdir. And then in the binutils subdirectory > Eric> proper there's that sysinfo tool for generating sysroff.[ch]. > > gdb used to use a mish-mash of different approaches, some quite strange, > but over the last few years we standardized on Python scripts that > generate files. They're written to be seamless -- just invoke in the > source dir; the output is then just part of your patch. No special > configure options are needed. On the whole this has been a big > improvement. > Good to know that this is perceived as a big improvement, that's a strong argument for moving to a script. I'm not up-to-date with gdb's policy about patches: are they supposed to be posted with or without the regenerated parts included? IIUC they are not included in patch submissions for binutils and gcc, which makes the pre-commit CI miss some patches. Thanks, Christophe > Tom