From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 2BCCB3858401 for ; Wed, 3 Apr 2024 13:12:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2BCCB3858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2BCCB3858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712149926; cv=none; b=a9q/Frr5Sb2rqm9uBfoVLTxBrDrmMPa66+L0EtauXcYhC+mRT3gBvHbkPBCrpX5BcbrHakiC3ZrmA4sEZzLQFVxWhWoo2O04/jeW/Kxxiq3rVflFVZ2Eay7K9cGj2I4bkRCp8A55BnU8RMu2SSy52Oen7qzOVdvbdsORuPr77E4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712149926; c=relaxed/simple; bh=TYAbtIKQex0pKecxFclbJ8/nw6wxb0wEJijsPVMhMxk=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=X88iKDOCp5UFLlFZepNSwkQ5Pgsd2xSNiNENJOE6rfOH4KNXUL6I9AkEhAk7hq05dRg5Q2204S5E90LL5y0bzgBVHKVacTnx1puuXnNC0UiZsMiI2nmKhidmLFdpPqeVYtKM7f7N7CSg7SuhHsFHT/pcvflphkDgNUfUR3Zkheg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a4e62f3e63dso416142066b.0 for ; Wed, 03 Apr 2024 06:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712149923; x=1712754723; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TYAbtIKQex0pKecxFclbJ8/nw6wxb0wEJijsPVMhMxk=; b=wnEbfy95oRi5StDLgijX5PY1k93vNT59cxLfvJ5p220q9ZEhenWEU7M3F2UgkvxZmX 4mbN1w6o9BF+UrFwkBn55WSjr8i6E/dETcRBMRVx8zBGvO11tZCsCtLuWzVTGZCVeLHh k/7KKbRANeFdOuPIOsslr96KSxq3d9lUtot72B5N2dOx1ko3c69GDyMZgGWd+zApzaSI IkbSCpVrQnFGhuZVY8tlDPGLLntgowpgTRSZi+ta58+RT1f4NrWHyxwGVuA8oRvCSyKB NG/SRhRHpbF09IQqd4Bw/GSMlaFyK0c/EroUr9t8zCYBS/06UnoXiryqg90t0TRZb/OB DWEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712149923; x=1712754723; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TYAbtIKQex0pKecxFclbJ8/nw6wxb0wEJijsPVMhMxk=; b=r3XotDszrK0a9YO4tPq6Vp9XteOjK4yZYjjlUfJv8CGfSykQV3HHEOlc00c8v3gWYp czpb3uU7jUePom8f4sv8+Ur5eSezJn6fAvvfu8NKDmS7WeA2Fg0AJtFkjCjTNBjXH+2c cYITyFh7F9bYd4GrO72YTEOL4tbbv8CJR1CSC0BorkFx9k0r3wAH0BXlYm6lq5z40Qjk tD7YsIZpq4UAfkhEpAyTse6Z6O0lNKEOr5aEAt9q3G+DqCaIMJEJeKgrNPgeFZOrknYq MNmAOGM4u4NU5T8XjJqHWk5C1ujdfTT24AxBOO26qp4jYulWHq4ZVxXvaa4eXAhsvR86 SvMA== X-Forwarded-Encrypted: i=1; AJvYcCUvKbXunFGPsZzKSUKIUs8f8T35tjJHN/T39+HSzAnedQRfxuZGI32/rmc3cFgoeSiTnmPo0umAlE9Tnj6pD9c= X-Gm-Message-State: AOJu0Yxtb+W7oahf0Odzm1O5GE/cuE90grhtVJEiG2buECR/tCJ9Sico ZQ0QQMnfMWi35bqVHgYWU5wpbOe154KGx8f60+OncFCZCS6d+YBT6rXfwQRt2LCEkWok+WHW3Am RFJic2uVCSLSx7bxwmCBPTO+xVxP+mLxytavRsA== X-Google-Smtp-Source: AGHT+IFK/kd/0XBlXOqWcMikDlI9vfJizCAuy9InNYVCE3cxkjMlzmreBNfuNkSKupnJCO7UCUmeafRKytJiyh/iI9U= X-Received: by 2002:a17:906:4a48:b0:a4e:4518:4b62 with SMTP id a8-20020a1709064a4800b00a4e45184b62mr7937076ejv.70.1712149922720; Wed, 03 Apr 2024 06:12:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christophe Lyon Date: Wed, 3 Apr 2024 15:11:55 +0200 Message-ID: Subject: Re: Patches submission policy change To: Jan Beulich Cc: Maxim Kuvyrkov , Thiago Bauermann , Adhemerval Zanella , binutils@sourceware.org, GCC Mailing List , gdb@sourceware.org, Nick Clifton , Richard Biener , Jakub Jelinek , Joel Brobecker , "Carlos O'Donell" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 3 Apr 2024 at 10:30, Jan Beulich wrote: > > On 03.04.2024 10:22, Christophe Lyon wrote: > > Dear release managers and developers, > > > > TL;DR: For the sake of improving precommit CI coverage and simplifying > > workflows, I=E2=80=99d like to request a patch submission policy change= , so > > that we now include regenerated files. This was discussed during the > > last GNU toolchain office hours meeting [1] (2024-03-28). > > > > Benefits or this change include: > > - Increased compatibility with precommit CI > > - No need to manually edit patches before submitting, thus the =E2=80= =9Cgit > > send-email=E2=80=9D workflow is simplified > > - Patch reviewers can be confident that the committed patch will be > > exactly what they approved > > - Precommit CI can test exactly what has been submitted > > > > Any concerns/objections? > > Yes: Patch size. And no, not sending patches inline is bad practice. Not sure what you mean? Do you mean sending patches as attachments is bad practice? > Even assuming sending patches bi-modal (inline and as attachment) works > (please indicate whether that's the case), it would mean extra work on > the sending side. > For the CI perspective, we use what patchwork is able to detect as patches. Looking at recent patches submissions, it seems patchwork is able to cope with the output of git format-patch/git send-email, as well as attachments. There are cases where patchwork is not able to detect the patch, but I don't know patchwork's exact specifications. Thanks, Christophe > Jan