From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2118.outbound.protection.outlook.com [40.107.243.118]) by sourceware.org (Postfix) with ESMTPS id 50A4E3857C7B for ; Sat, 22 May 2021 01:28:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 50A4E3857C7B ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CzNydFT46HHSbjpDtMzWKxOGb5umfXnq9qzlbxbmCmBecQv26gCpROjw2uWlIZ0LKmhxG/AOALsXM5R5jdTGPKbxxhKClxdiMfnucnVHxfO8gdoaC6ihpHjz2yuz96VEC/oNvg6kOIMKfE0A3aviMHiRiO9nONBhU7ErpKlut9lnGCMtrqJ4P79zhkg0lWUk4/t5/AV4zbN0NxDwgJWiAYNRsXcEX78jdc/fIKvUvTl+skbaGjQibFMYd+6yF+Wuq64GfJpnKCDyURM7IpfWrTqy97J4efQ2kobMGycol4tQBM+pGhv1Aq/ORsZ20D92c6Oj7hwcBI/M6RJSgIS5xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AdINuVUCyro0vOxd9MwJG10B7/w02orF58wLunJ/Zck=; b=Qijc/dxEJbedBxl9dbszj2DbGwFqtkTspKxWp2rqIW+butffaJr6y8xIcF91De6uZqLpQeQaTHDTP52Eheu7PpFTi9iKp8l1Mho+WutVdP1/M37nUh1BonOPgqQeLJy3JsDTc/2V0hbZO2cJdARxZ+cNAvJc/uyzXyZD41fVOazXebyeAVY6tETXUl9gxTi22tXZrkYLNkQ9Z8NkYX+rmKm6koh6iZsgOW0J0hzPk81rztoVe2C/HgE8uNotlHMMVic6awwqNSw/rnPNOfzCrs3IjkA7e35+UN1LUzRJdGqRsH1hiucqQ1SRg9BDYfvklVCVGaK4cSPWgKZT2ZXHqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none Received: from CY4PR21MB0789.namprd21.prod.outlook.com (2603:10b6:903:13b::15) by CY4PR2101MB0723.namprd21.prod.outlook.com (2603:10b6:910:8f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.7; Sat, 22 May 2021 01:28:32 +0000 Received: from CY4PR21MB0789.namprd21.prod.outlook.com ([fe80::c1c7:6190:42f6:c95d]) by CY4PR21MB0789.namprd21.prod.outlook.com ([fe80::c1c7:6190:42f6:c95d%4]) with mapi id 15.20.4173.016; Sat, 22 May 2021 01:28:32 +0000 From: Eugene Rozenfeld To: Wei Mi , Andi Kleen CC: Hongtao Yu , Xinliang David Li , Jan Hubicka , "gcc@gcc.gnu.org" , Wenlei He Subject: RE: [EXTERNAL] Re: State of AutoFDO in GCC Thread-Topic: [EXTERNAL] Re: State of AutoFDO in GCC Thread-Index: AQHXOsu5yff2ykdMyE6mPDeCIIGFBarK/raAgBJ5I4CAEWTx0A== Date: Sat, 22 May 2021 01:28:32 +0000 Message-ID: References: <20210423192834.GA1949@kam.mff.cuni.cz> <20210425190754.GA88857@kam.mff.cuni.cz> <87a6plulkz.fsf@linux.intel.com> <20210426180011.GA1401198@tassilo.jf.intel.com> <20210429054025.GB4032392@tassilo.jf.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=c8340c2f-d0bf-44d7-9349-9d0369bc3fc5; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-05-22T01:24:21Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-originating-ip: [2601:600:9700:56f0:b41d:3ce6:291d:8840] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9639a37c-de53-4fcc-cebf-08d91cc0e957 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QdjDsiV5mUIbyikTSYSxsV7zpIOEuJd8Y6hq9e0KhEtRPn/hXolHWNMtw9Y7/VL7JOOikHtWeG7IauXkrSdcvVDiuBlddhs1NzaBuZoS6yLdd9+mTM8m23stmmnQa4UM1dlkZkteS4yMKOAo4n7BhxO7MsnCyb6m9oEBCEDh+gEKZNvkY/Cb1CGP5w/MvWVAzVXY8pmyHyeH/Cpk2dwskNKe81K/EE8KpggyWh4wv6NzRYG/+8iVuM+7VEJDQF+w26IhzNdWnuxX3mhzOqYKSe4rC8DhlH8mZBcTj+CEKBGEoDnfMsc0MDhwcIHHLNc3uQvVGFTYpEFmIZgI5TBlC2HSioGz/vqg8zfD8mQ3CTUVeZF/2TkSduU9tmwnRlJBtToOT4NUT92WEPqcwjUSCk3Cl2LxBu5j+tT4P6OkKh+6orIK5uCofx8ApcVc/4O2V4yIQuPc7BNK7pkONTK9KWRHF1rmmOpAxZP9hVd8rdjMUwd3xZLHeQT+gESPcF48F3v5OLf9XRzvHsPZXrw78RVgndw8+3/RCZmugz9SHpyYcNJZPfppWCeu2TPbcqtzSf0DcUtvSSINvJcZHnEqORVdHqNqDuxgV3e8noHw/nG0SsXWAeejspOMvnS31vAM/y6YjztnzXmDBKljSjt4oG9oGwYz3g+82pQQ0okuSqnImq65L3uc4J+yihCOecWvNc4DSbGBgANksiGPg6uemTs/dQ4uhR8g8Zf8UdwY9bE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR21MB0789.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(9686003)(33656002)(5660300002)(76116006)(110136005)(66946007)(64756008)(66476007)(8936002)(316002)(55016002)(54906003)(122000001)(66446008)(166002)(71200400001)(66556008)(8990500004)(38100700002)(52536014)(10290500003)(82960400001)(6506007)(4326008)(83380400001)(82950400001)(966005)(478600001)(8676002)(53546011)(7696005)(2906002)(86362001)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 2 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?w3dyUJsba0r1JqLAK1fUwIafWpKjJgF5Lae3ajfKBkg0KN/c2awO+dFcqYgN?= =?us-ascii?Q?qGjNT+v2+zCilbixNKxz6Z/vck+W9poW430hZ9SuxYIzfBH2sUYXnw1dT8jz?= =?us-ascii?Q?cJ+cB6ZxXCq2XhA2/rLbrl0dOKdsgNpZwF5ofXdaoZLer/BUGDc9z/mNSjRh?= =?us-ascii?Q?P1Ssvx3zvQQDKvN/OrzItGO284/HTPWJji80pgN/UFWHL1sOLEx0Aa0Gp/hx?= =?us-ascii?Q?9t9SaNm0q288y6kApVolKvqB/YsRiJKjDSgzoR+5OIrYC4uRlybIC/qQeVUZ?= =?us-ascii?Q?ME4n17qLDl8KejsQWhg7xSxEyydJGgasmyI4K+o6z4Ww5jW3KqdUfRdzs5F2?= =?us-ascii?Q?V1u6WfwXxVh9Hx0v03dV93svsAft/WbeQuBYZdpi2yoJUeYIwfy7OJFrldGM?= =?us-ascii?Q?W7nDYYR+CPJQva1ZJ/ZpuXtEc7xmQy5Y+HUPyFfk3fZiJzxo21tFpaFLsryo?= =?us-ascii?Q?ub/fgbHgMXKW49lqZd3oU2pE6pk+kvwO1o+ZItHjpw8gb6iUzGE9US0PJmXq?= =?us-ascii?Q?DHETB6qDZcurvUzyDNlUfEP72aWpQl6nJuZDnNNleGVYay2GvWcnf0KHAn7U?= =?us-ascii?Q?Mb3xRZfQ8Z6xaOz/qbjsxLJCTZEcObX8xELEJYrAfsFTHYAIDptgPO2B9mmJ?= =?us-ascii?Q?o3/pROhT6cE+V2FQSL/IeLuQjc0A+BlYqngqB3pgzQTXfrz1PpqavGfCjFhl?= =?us-ascii?Q?y1nEujY/+pO3lE2pMa/Ts1BoeheeDnUtEul0yubCvEBw3shLkm4iyzKPoam1?= =?us-ascii?Q?bck67RUe51NgNoNC+g6Rvh7YzKgyYs2ODBpKmB/CVYgIPVNb0l0hty/wMFGy?= =?us-ascii?Q?yhNxNnPsWMiq8Y9C5XA3q/Xp0g0odasutyaQ25rblIzntdfm4orRK6+MAnRR?= =?us-ascii?Q?ga8ayIF8QYINSQprAd6QwBcvRg9PIsEKo01XROOHGOTiZjHBjhOqzNT2qdKP?= =?us-ascii?Q?0Vwr6GxZJsVpy7K6BabhgzJP+zeZzSVsEwbis3eX?= x-ms-exchange-antispam-messagedata-1: cqr9az83Q44DRZjMRv559KzU0k+jXxpMpneKjxOaLGJuUQa4skLsQ5xHy8EBF3SP/rtiYeWI2qFQLsIghamRU1wU4pOUKOeAI+uX4ZL46WHG0f/oYphRa6P/tVZdDrek+NGzoTK0boaKF4j9+sNRLrtCjWpYLAjBgk+rgeVh1Q5I2aAvX6wWa5hEZ5idqyqcwsV1NOMmgtWqHNDdCo1L9d3Cs/4GeG5+hrm2rCV5Go06jXw5Golv2iQ1H3ASWdk7o1V3RG26BzdyczAg4L5JXSQZwfWu6/lTmVHenXoU+Ldsvorh5fNgIoLUOa26o0qFqdOxwv/wiwnQempvcPNtPCHPQvheHs2E/c+Pa7S9UsLHpusaNtVTiuJFE03q9gw42XQFUr1ShJ8HsUpyUYUv03ma x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR21MB0789.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9639a37c-de53-4fcc-cebf-08d91cc0e957 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2021 01:28:32.2780 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DHWF+DUZr9N3mJOhmvGjcq9gXQJrBNNphd6iInAFlZyldNyPtJC3XsAlXQqEINdqGlrWg5NEMSj0xEHSK8uFzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR2101MB0723 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, HTTPS_HTTP_MISMATCH, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 May 2021 01:28:39 -0000 I tried following the instructions in "2.2 Build autofdo tool for gcc" in h= ttps://github.com/google/autofdo#readme and got build failures: eugene@eugene-Virtual-Machine:~/autofdo1/build$ ninja [1/228] Building CXX object CMakeFiles/create_gcov_lib.dir/profile.cc.o FAILED: CMakeFiles/create_gcov_lib.dir/profile.cc.o /usr/bin/c++ -I../ -I../third_party/glog/src -I../third_party/abseil -I../= third_party/perf_data_converter/src -I../third_party/perf_data_converter/sr= c/quipper -I../util -I. -Ithird_party/glog -std=3Dgnu++1z -MD -MT CMakeFile= s/create_gcov_lib.dir/profile.cc.o -MF CMakeFiles/create_gcov_lib.dir/profi= le.cc.o.d -o CMakeFiles/create_gcov_lib.dir/profile.cc.o -c ../profile.cc In file included from ../third_party/perf_data_converter/src/quipper/perf_p= arser.h:18:0, from ../sample_reader.h:18, from ../profile.h:15, from ../profile.cc:5: ../third_party/perf_data_converter/src/quipper/base/macros.h:8:0: warning: = "DISALLOW_COPY_AND_ASSIGN" redefined #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ In file included from ../profile.h:14:0, from ../profile.cc:5: ../base/macros.h:114:0: note: this is the location of the previous definiti= on #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ In file included from ../third_party/perf_data_converter/src/quipper/perf_p= arser.h:18:0, from ../sample_reader.h:18, from ../profile.h:15, from ../profile.cc:5: ../third_party/perf_data_converter/src/quipper/base/macros.h:12:0: warning:= "arraysize" redefined #define arraysize(x) (sizeof(x) / sizeof(*x)) In file included from ../profile.h:14:0, from ../profile.cc:5: ../base/macros.h:162:0: note: this is the location of the previous definiti= on #define arraysize(array) (sizeof(ArraySizeHelper(array))) In file included from ../third_party/perf_data_converter/src/quipper/perf_p= arser.h:21:0, from ../sample_reader.h:18, from ../profile.h:15, from ../profile.cc:5: ../third_party/perf_data_converter/src/quipper/compat/proto.h:16:10: fatal = error: perf_stat.pb.h: No such file or directory #include "perf_stat.pb.h" ^~~~~~~~~~~~~~~~ compilation terminated. What is supposed to generate perf_stat.pb.h? Thanks, Eugene From: Wei Mi Sent: Monday, May 10, 2021 4:47 PM To: Andi Kleen Cc: Hongtao Yu ; Xinliang David Li ; Jan Hu= bicka ; gcc@gcc.gnu.org; Eugene Rozenfeld ; Wenlei He Subject: [EXTERNAL] Re: State of AutoFDO in GCC https://github.com/google/autofdo ha= s been updated. Now create_gcov/dump_gcov are added back and can be built s= eparately. Please look at "2.2 Build autofdo tool for gcc" in https://github.com/googl= e/autofdo#readme On Wed, Apr 28, 2021 at 10:40 PM Andi Kleen > wrote: > > On Mon, Apr 26, 2021 at 06:40:56PM +0000, Hongtao Yu wrote: > > Andi, thanks for pointing out the perf script issues. Can you please > > elaborate a bit on the exact issue you have seen? We've been using > > specific output of perf script such as mmap, LBR and callstack event= s > > filtered by process id. It works fine so far but may certainly hit i= ssues > > in the future with extended uses. > > Okay I took a look at the latest autofdo now. It seems to be basically > a LLVM project now that depends on LLVM to even build with all kinds > of dependency hell on some old LLVM version and other packages. > > I guess gcc will really need a replacement that doesn't pull in > all of LLVM if it wants to continue supporting autofdo. > > I'm myself unable to build now. > > I'm using the old version I had a git fork of and that > was before all of this. I added a patch to make it work > with the latest perf by ignoring increased perf_attr > and unknown perf events. > > Honza please use > > https://github.com/andikleen/autofdo -b perf-future > > for testing. > > -Andi >