From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id BEEFB3857C55 for ; Fri, 6 Nov 2020 19:56:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BEEFB3857C55 Received: by mail-wm1-x32e.google.com with SMTP id c9so2601304wml.5 for ; Fri, 06 Nov 2020 11:56:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:user-agent:in-reply-to:references :mime-version:content-transfer-encoding:subject:to:cc:from :message-id; bh=VfTneLtUO9ZOaxLq85bGmlh/7OV6B9C7SGZwAjvy/n0=; b=YG4IXNrHiN215czgf0CQqcNnY8+ghJm9RdNsLmxPUm5Sh1uLNmSVfXNhTeT9GHHEl6 JXJuhEnuY2Ben/uvDtzhW6at1LX3OVvcxy5Iv24Uv+3joJlg21egR8JW/kyyJvEzeesg xadeMuDedv/Q74IZ0gNSH4OKNnnBUYfu0DSc129hO5Pl5MvZko6P3YbTBbQQIwOBEYgB eJHeXrNEeamoDskgVj2qvM2wezCH6eM+McYpI5A0sOOe2gWDbn3YcCPwQz9VQY7vQNFb EOjR5AYA+wI+n6JmYKs/6ieooGW+J066/L6gYxSzGLwdHF4cyLRF3FHeCMEzKqu+xBK8 0T2w== X-Gm-Message-State: AOAM5329gLtjKqIQ2o6MGBuFhT0wJ7t0R1eo5rt1ltiEzYy6toeX5884 9yzVjM6l1TiSaQYH3vKa3iI= X-Google-Smtp-Source: ABdhPJxdrxTf35hDG+v32UgwStqVd7e8ns8HKBtAQgRLTrHqlzd4AH0oKR/UoHe+l7iJEDQaPiEI2Q== X-Received: by 2002:a1c:b041:: with SMTP id z62mr1254595wme.183.1604692588818; Fri, 06 Nov 2020 11:56:28 -0800 (PST) Received: from [192.168.178.32] (dynamic-077-009-061-099.77.9.pool.telefonica.de. [77.9.61.99]) by smtp.gmail.com with ESMTPSA id w21sm3103731wmi.29.2020.11.06.11.56.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Nov 2020 11:56:28 -0800 (PST) Date: Fri, 06 Nov 2020 20:56:25 +0100 User-Agent: K-9 Mail for Android In-Reply-To: <20201106194555.GO3788@tucnak> References: <20201102194357.GI3788@tucnak> <30cf614e-814a-aa3f-b31f-91f6104b833a@suse.cz> <20201102205849.GL3788@tucnak> <20201106194555.GO3788@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: gcc/DATESTAMP not updated any longer To: Jakub Jelinek , Jakub Jelinek via Gcc , Joseph Myers , =?UTF-8?Q?Martin_Li=C5=A1ka?= CC: gcc@gcc.gnu.org,Richard Biener From: Richard Biener Message-ID: X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 19:56:31 -0000 On November 6, 2020 8:45:55 PM GMT+01:00, Jakub Jelinek via Gcc wrote: >On Tue, Nov 03, 2020 at 06:26:58PM +0000, Joseph Myers wrote: >> On Mon, 2 Nov 2020, Jakub Jelinek via Gcc wrote: >>=20 >> > It isn't that easy (because update_version_git checks the gcc trunk >and >> > so I had to insert a sh invocation in which I've tweaked it), but >it worked, >> > thanks=2E But something is really wrong with the hooks, as the >gcc-cvs mail >> > for the trunk daily bump wasn't sent again (r10, r9 and r8 changes >did)=2E >>=20 >> I think any issue with an email not sent to gcc-cvs should be raised >with=20 >> overseers or postmaster; they'll need to check logs at the exact time >to=20 >> see if the email was ever submitted by the hooks to the MTA (and at >least=20 >> part of the mail sending from the hooks is I think asynchronous so >any=20 >> issues might not be reported back to the git commit command)=2E If it >was=20 >> submitted to the MTA, the problem is with the MTA or mailman=2E If it >was=20 >> not submitted to the MTA, Joel might be able to advise on how to=20 >> instrument the process of email sending from the hooks to see where >it=20 >> went wrong=2E > >As I didn't hear from overseers yet and we've seen again multiple >missing >mails, after discussion with Martin Liska we've applied following hack >to log the mail addresses and mail subjects that are being passed to >sendmail=2Epostfix, and a short while ago we got another case of missing >mail=2E >And it didn't show up in the log file either: >gcc-cvs@gcc=2Egnu=2Eorg [gcc r11-4793] core: Rename DECL_IS_BUILTIN -> >DECL_IS_UNDECLARED_BUILTIN >gcc-cvs@gcc=2Egnu=2Eorg [gcc r11-4794] Add PC as control register >gcc-cvs@gcc=2Egnu=2Eorg [gcc r11-4795] Combine new calculated ranges with >existing range=2E >gcc-cvs@gcc=2Egnu=2Eorg [gcc r11-4796] rework PRE PHI translation cache >gcc-cvs@gcc=2Egnu=2Eorg [gcc r11-4798] c++: Propagate attributes to clone= s >in duplicate_decls [PR67453] >As you can see, the r11-4797 commit is missing from that list and >didn't >make gcc-cvs either=2E >But git log certainly shows that commit in between: >commit 556ab5125912fa2233986eb19d6cd995cf7de1d2 >Author: Iain Sandoe >Date: Fri Jul 31 21:05:28 2020 +0100 > > Darwin: Darwin 20 is to be macOS 11 (Big Sur)=2E >So, I'm afraid it must fail or bypass this code path somewhere earlier >in the hooks=2E Is that maybe already known to the repo when it is on some rebased user br= anch? Richard=2E=20 >diff --git a/hooks/post_receive=2Epy b/hooks/post_receive=2Epy >index 3761c00=2E=2Ef368559 100644 >--- a/hooks/post_receive=2Epy >+++ b/hooks/post_receive=2Epy >@@ -16,7 +16,7 @@ from init import init_all_globals > from updates=2Eemails import EmailQueue > from updates=2Efactory import new_update > from utils import debug, warn >- >+import traceback >=20 >def post_receive_one(ref_name, old_rev, new_rev, refs, >submitter_email): > """post-receive treatment for one reference=2E >@@ -44,8 +44,12 @@ def post_receive_one(ref_name, old_rev, new_rev, >refs, submitter_email): > " old_rev =3D %s" % old_rev, > " new_rev =3D %s" % new_rev) > return >- update=2Esend_email_notifications() >- >+ try: >+ update=2Esend_email_notifications() >+ except Exception as e: >+ with open("/tmp/gcc-git-mail=2Elog", "a") as f: >+ f=2Ewrite(str(e) + '\n') >+ f=2Ewrite(traceback=2Eformat_exc() + '\n') >=20 > def post_receive(updated_refs, submitter_email): > """Implement the post-receive hook for all given updated_refs=2E >diff --git a/hooks/updates/emails=2Epy b/hooks/updates/emails=2Epy >index 706124c=2E=2E81f4beb 100644 >--- a/hooks/updates/emails=2Epy >+++ b/hooks/updates/emails=2Epy >@@ -272,6 +272,9 @@ class Email(object): > else: # pragma: no cover (do not want real emails during testing) > sendmail(self=2Eemail_info=2Eemail_from, email_recipients, > e_msg=2Eas_string(), 'localhost') >+ with open("/tmp/gcc-git-mail=2Elog", "a") as f: >+ f=2Ewrite(e_msg['To'] + ' ' + e_msg['Subject'] + '\n') >+ f=2Eclose() >=20 > if self=2Efiler_cmd is not None: > self=2E__call_filer_cmd() > > Jakub