From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-obe.outbound.protection.outlook.com (mail-centralusazon11021026.outbound.protection.outlook.com [52.101.62.26]) by sourceware.org (Postfix) with ESMTPS id 56B873856DDE for ; Wed, 27 Jul 2022 18:30:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 56B873856DDE ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=faHq3uZnpkHttRvPpQN8079+x1q625Yq2d4fVu2C6OruoTteWaFAFvpVPHUy+GGkidgY3OIlABkxdO62Xcv7elIN1aHh4qWKOTs2mc22+z8BeqstRjY9l2ftraJjxvnAAYBB8MK/8ybSCjUBqOpsnfEh+5jZroCKk/redGphX4+0hYQqLkmC5kzwYG0JokLPTXe5Vvi2YBoA9zxXzn2Um2AvzFbfnqbajVeH1HGP1caBEv2SfnfZS8feia6iFS/7rII+TmeUv2BzFyn71W/vCz5OntMf0iQvCKLHdy2toWw1j6uqB3BtmqJSF8pdx1W+MbglG/oeWPwdzs29YfLUCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ik+fThvdpicbqLFoxUOgDKm2IdMMRv1byo3pD1NL4Ik=; b=bApFSNtB+yiONzGZZWOlisHAoOCMBb4U9+3iGA/KGgRnXb6zMbT1Op9qT65wi0a3hrJovOltCpZtldsnWhgpRESjCHIHUUNL4UTBRwa2GNE3PTxvmqT8tOciP+pBTk1AHla5V7gOnIMpLORxSSTKpQ/tU7JO4apbvAk5XNew6CdBDuDVb824IjEmvk1Uvw3RI8QNa89J2oppLpFZf9pRCSu/p2UF5WWWYBitFbqZw+fJ31jNRE+HDVkL9G1CH2+ILwfswvrgl8FCY1XemsrZR3bv5KA5UrOkgkftltpSHIOWiNsBE/H2H4hvlMjLb4TeguH45CcDJ4IuhXFh1LttkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none Received: from DM5PR21MB1767.namprd21.prod.outlook.com (2603:10b6:4:a7::39) by DS7PR21MB3478.namprd21.prod.outlook.com (2603:10b6:8:91::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.1; Wed, 27 Jul 2022 18:30:20 +0000 Received: from DM5PR21MB1767.namprd21.prod.outlook.com ([fe80::6050:eecb:f17e:3c8]) by DM5PR21MB1767.namprd21.prod.outlook.com ([fe80::6050:eecb:f17e:3c8%9]) with mapi id 15.20.5504.001; Wed, 27 Jul 2022 18:30:20 +0000 From: Eugene Rozenfeld To: Jan Hubicka , David Edelsohn CC: Martin Liska , Xinliang David Li , gcc , Andi Kleen , Joseph Myers Subject: RE: [EXTERNAL] Re: State of AutoFDO in GCC Thread-Topic: [EXTERNAL] Re: State of AutoFDO in GCC Thread-Index: AQHYoSwDrvTft2hTz0KNU80j7i7NwK2RPk8AgACT1YCAALex8A== Date: Wed, 27 Jul 2022 18:30:20 +0000 Message-ID: References: <4d005159.55ea.1791e171ab9.Coremail.172060045@hdu.edu.cn> <875z0378j1.fsf@linux.intel.com> <67df7dbb.5eae.1794bba0ca3.Coremail.172060045@hdu.edu.cn> <7c802b11-857e-78eb-c2e8-0a3044817793@linux.intel.com> <20210509170121.GE25641@kam.mff.cuni.cz> <20210510172121.GT4032392@tassilo.jf.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=48df2781-c3ec-424e-a9aa-cf0382acf5fb; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-07-27T18:24:20Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0e1ab3de-d832-42a5-9f89-08da6ffe0fe0 x-ms-traffictypediagnostic: DS7PR21MB3478:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yS5cEdSUkm8TgZIhAZld6oQQKLyrMQp3qWIcZFrXs6ubZyafHSNxSijnOKkq4rPFGD+Iq+EmwAQ16268VcnhkAAI90vjbTZpcTo9Se3gVdcttAMN9b595vy1NzcJdjd8uNJlLCcrRZY8CPgJBxUOsTyu2ejKsBSsgekzvNdtcfyJhr7M4GxfNinVFblDkVfbw5pgcMT79RqnjLFcJAbcYDVYlGW3Il4uI2+Fqb9L+cFY5XH17PBp3BUpa1vnfdvq9EtljQnmebFRTkvknTnHWv+1W3jPcNYSxA9KXpTIxJQwlsBIgo7Jc+Hff76LJ9cB+MuGHNUcIHUPSzaIUaDVxtezoqm1D87xHceIdedHdK3NjyBsRLsa7XYoc/7C+r2EhjkC01dY82zv7bVeraiISX1rKvxSGFk9O5Q5VPviqumFUHvAllKztpOUwug4QzsjHuEYhb2VW8sYWSLSN/aNHSRQ5e7qFNYkeJYagScRScwV0P0AtWrcBGCc+nd5VTjX757G/jHOuUo2V7TLjB+oqOV3OXdWgvBx226BckChsimfoHsH25bgxSo2CdXbpXqC0yso+DhbcKs/pw7wVpZHTmwibnXin0Cc4NUYK/rM7nrE/74iLwNZl8+vva4OXXrgnm+S3AoMSG7+sMzEoWudRc3902S66DuzDcYSzb1DqxOyecxq3mRthjq6Dwz453mWQP3TTolRfitVoOL4LHxKqa22mhr9dfirR70uJTGVphNe0B7m973mSoR07k3+CCX/DEBfdlI01G/oRgKZdRoeF+jpJDPIlbURTrMh88c/Eye7pudYVhYTXOmqRlUeuSjsYX/aFQo9lQ0Z1QS96MuKVPHnYnxO5s3lZ6liuSIU8spoLfKcxVZimY15yTzp2G/mZK+J67Y9EBnO7RL5ha9phsS8RTCzDLP1ZFI7D1Ob04k= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR21MB1767.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(39860400002)(366004)(346002)(396003)(136003)(451199009)(38070700005)(82950400001)(53546011)(86362001)(966005)(478600001)(71200400001)(186003)(41300700001)(110136005)(10290500003)(82960400001)(6506007)(316002)(7696005)(83380400001)(54906003)(64756008)(76116006)(52536014)(30864003)(66946007)(8990500004)(66446008)(5660300002)(2906002)(66476007)(9686003)(8936002)(33656002)(4326008)(122000001)(8676002)(55016003)(66556008)(38100700002)(4001150100001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UF8rVn2rrerTQiYSbVLecCdCWdUOeInW6A3Q102ErgbG22TV2Vb/iMTU62Rl?= =?us-ascii?Q?fOTv9V/qAPmQzMyTSJaIquNCmG3Z6C2p72fUfZ4ziFCwJec2hzwwY4ikvaUL?= =?us-ascii?Q?C+I3XOAIgZkeZZ+6IFdkccHg52ecrbYhPAjGIOZuqGlS6Y1SgMS2bU1uVGcI?= =?us-ascii?Q?gOeqquI+CqCDoAAo+1PknXlbahfeZSK4Y3M1HtrcPv7Fb8D1stq8Vbl+SBV0?= =?us-ascii?Q?04uJTbj5SJfkxseweUoFUesrtKslZ6Ey8BP2qLDv0AHC7P2X6pFTVz8uhQ8C?= =?us-ascii?Q?kwx8ylaiDvrJgoLXvSMXqJY/oBWL50rEWeMo6lu0KJ5x7DA0BHW6OGmOF2a0?= =?us-ascii?Q?1XzvgBP3TtjLxzApCPfImXjilrF/VFMbVV51sjhb9Lt8XhiUXjSFsAtnYD6o?= =?us-ascii?Q?rJACpyUEjbluhOQAE4uyVpYomSyjM80FpotRXPgYfNdryVzkJRT3rwL4LWYi?= =?us-ascii?Q?64aMT3oZTYoPln5qZ6rMiW1+zQflT3cD5G9SinMBfgw3zHbXK0cthQoC+J8i?= =?us-ascii?Q?6hbdAgoBlyio2CRxkdPSaPPbuLNS9ZyLUEIczSBYo2Rd6+f6PC3yqDgVOdHQ?= =?us-ascii?Q?n154j2ZTTgKOrmffeZUAkIEMBmu0ccxESxaV8SHSXxCLJmk9wNCD+OPjYlkv?= =?us-ascii?Q?+dkUS9EVd2Z67SVVlxZ7w1sBq8VEi1JobN4gAxmnl4uVZVOz2W9nfkIJjcFF?= =?us-ascii?Q?RKs4KAFEmpaH/rea0II/+EGP5Ab+ZFRcRD3jSvHghWJCV8VBgwoCktdUIuhd?= =?us-ascii?Q?+rG2+bW6WYKU7MCHpPEEmNOEIjsMsWCImV6i6lRHyIlV6UfrqUJkT5Q7huzc?= =?us-ascii?Q?zu9SpPUfjRPou6ikb0HsEP6amWC/Lvhx90lD9Ml4MLLrZSFerg+I0xxQk+2L?= =?us-ascii?Q?5qrTdn0+fj6EOubgDvhZhrrFXDolJGueL+YYztgZ05qDi4kqN7p+Fp0IaKsD?= =?us-ascii?Q?XO/i3N9rpiGbKwDrTEiWq9lLZU2BlNLV/6p2m3jix8qzumfDJT2b2z7w5X2d?= =?us-ascii?Q?YhDlprRSueLL0OF6P/+LJhGc9dyFduU7ktaBdzEYbtfTEpHyHL6apw+Oaa7X?= =?us-ascii?Q?L6l+/D5WfYPbC6tnvqzy9sLb3o+lWDvUSy7EZ708F3pvpJ7SbAwLAsvef9go?= =?us-ascii?Q?Kh2Ueei8gY1oDQqML2XB4RmP4nAn2u56p9bJposKCN4xUzLBO9v6or53N2aI?= =?us-ascii?Q?tO2DcWHRDtBJO4GXhQPsyNZeH4qCROB6wOnUdrRXXsZi+p05nK2vaj6qn8KC?= =?us-ascii?Q?i/smzdjYVqk/L3chzDO9k9wj/wzxwBemlbuPKNa8CHDp5Rbar28czA/y07Ey?= =?us-ascii?Q?b4MXQFBGPS2cDohSzjPzQoqmUSAahUs9CysoRchGTxjmoaEhLo4lHgLCAOui?= =?us-ascii?Q?vZctZoGpxpvmTLSd9UCRST16jTe2/ivix5QiPv8/3885liygbnFASShUz9g+?= =?us-ascii?Q?oZbzOON7zev0veM3zbyIdDzz1GFUjUpXUWBiiA6CCyWeS0Tdo7MGdRbZUdLU?= =?us-ascii?Q?BRKjj/wHODA3t0YDei9w6zelTbC0pqzJYLgW+Yo3OBbxGDry36wk98OTTjQL?= =?us-ascii?Q?z3L9BpmDA6nVa/vx+4dT//Wsc+3R9FPczvJMlIvgN3uuRLXV1dE6Ca4FyRxL?= =?us-ascii?Q?/hR+omI/VDKb7OUbYY+9/WfRuIOg8cF5PD8xpNe0QCWR?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR21MB1767.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e1ab3de-d832-42a5-9f89-08da6ffe0fe0 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 18:30:20.4477 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h3rC7Ue4UoXkTd6Vj/YDx48q6fzr8Px+X2XB25GyHhC2ZnlwGehsXcDlIrKQHo11wuy6ET7Moi0ArgeclCyMLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR21MB3478 X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, KAM_LOTSOFHASH, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jul 2022 18:30:26 -0000 Hi Jan, Thank you for your reply. I did have you on the TO line in my latest patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596065.html That's the patch I need a review on. I'm looking forward to co-maintaining AutoFDO with you. Thanks, Eugene -----Original Message----- From: Jan Hubicka =20 Sent: Wednesday, July 27, 2022 12:27 AM To: David Edelsohn Cc: Eugene Rozenfeld ; Martin Liska ; Xinliang David Li ; gcc ; A= ndi Kleen ; Joseph Myers Subject: [EXTERNAL] Re: State of AutoFDO in GCC > On Tue, Jul 26, 2022 at 4:13 PM Eugene Rozenfeld via Gcc=20 > wrote: > > > > Hello GCC community. > > > > I started this thread on the state of AutoFDO in GCC more than a=20 > > year ago. Here is the first message in the thread:=20 > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgc > > c.gnu.org%2Fpipermail%2Fgcc%2F2021-April%2F235860.html&data=3D05%7 > > C01%7CEugene.Rozenfeld%40microsoft.com%7Cfe5184091a18487fd92d08da6fa > > 1619e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63794503618637077 > > 0%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTi > > I6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D9%2Bnv2ShWxKh88K% > > 2BsOeqPgQX3lOCJQ0lnF%2F7SUs4K4uI%3D&reserved=3D0 > > > > Since then I committed a number of patches to revive AutoFDO in GCC: > > > > Fix a typo in an AutoFDO error=20 > > string > 2F%2Fgcc.gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh%3D23691ddd3 > > aa3ffe55892b2bff54f9a15a89de2b4&data=3D05%7C01%7CEugene.Rozenfeld% > > 40microsoft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f988bf86f141a > > f91ab2d7cd011db47%7C1%7C0%7C637945036186370770%7CUnknown%7CTWFpbGZsb > > 3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 > > D%7C3000%7C%7C%7C&sdata=3DqkecfE9uH5gy91vILQQlCk9RpExqPZxO4q02wiN1 > > EFw%3D&reserved=3D0> Update gen_autofdo_event.py and=20 > > gcc-auto-profile. > l=3Dhttps%3A%2F%2Fgcc.gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh% > > 3D01d402c5e0ac1ddf5618bbe316b50067625fda46&data=3D05%7C01%7CEugene > > .Rozenfeld%40microsoft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f9 > > 88bf86f141af91ab2d7cd011db47%7C1%7C0%7C637945036186370770%7CUnknown% > > 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC > > JXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DE52qVFlfdfFGnW9yDsBNhh4k2ey8g > > 3aJEGzH40MuSOc%3D&reserved=3D0> Fixes for AutoFDO=20 > > tests > F%2Fgcc.gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh%3Df9ad3d5339 > > faaaed6e15a7b27d90fbc66eb72f37&data=3D05%7C01%7CEugene.Rozenfeld%4 > > 0microsoft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f988bf86f141af > > 91ab2d7cd011db47%7C1%7C0%7C637945036186370770%7CUnknown%7CTWFpbGZsb3 > > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D > > %7C3000%7C%7C%7C&sdata=3DXYlFoY3OTTXHp18O1v8BY47A17NyNPXvUWWYsVnbD > > 0U%3D&reserved=3D0> Fix indir-call-prof-2.c with=20 > > AutoFDO > %2F%2Fgcc.gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh%3D0ed093c7 > > c3f755bc1cd80e5186abeb2f5c50ee0c&data=3D05%7C01%7CEugene.Rozenfeld > > %40microsoft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f988bf86f141 > > af91ab2d7cd011db47%7C1%7C0%7C637945036186370770%7CUnknown%7CTWFpbGZs > > b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > > 3D%7C3000%7C%7C%7C&sdata=3DsLftY6hjvzSuE9ZgkGmXZLDpRMjlDo%2FEAyDyP > > CviY5Q%3D&reserved=3D0> Fixes for AutoFDO=20 > > testing > %2F%2Fgcc.gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh%3D9265b378 > > 531391498ec1727f67a45da72a6c07e9&data=3D05%7C01%7CEugene.Rozenfeld > > %40microsoft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f988bf86f141 > > af91ab2d7cd011db47%7C1%7C0%7C637945036186370770%7CUnknown%7CTWFpbGZs > > b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > > 3D%7C3000%7C%7C%7C&sdata=3DlXZ%2F%2FbcfYD%2BQyIiXMAaCxOujEAfDXSY1p > > 78kUb2md7w%3D&reserved=3D0> Fix indirect call inlining with=20 > > AutoFDO > %2F%2Fgcc.gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh%3D285aa689 > > 5d479bed8e72ad363290846645b6faa0&data=3D05%7C01%7CEugene.Rozenfeld > > %40microsoft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f988bf86f141 > > af91ab2d7cd011db47%7C1%7C0%7C637945036186370770%7CUnknown%7CTWFpbGZs > > b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > > 3D%7C3000%7C%7C%7C&sdata=3DypoF%2BZnEe3eC3Gat6%2FjUJLV2XiltdjJHe68 > > pue64fSU%3D&reserved=3D0> Improve AutoFDO count propagation=20 > > algorithm > 3A%2F%2Fgcc.gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh%3D3d9e67 > > 67939e9658260e2506e81ec32b37cba041&data=3D05%7C01%7CEugene.Rozenfe > > ld%40microsoft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f988bf86f1 > > 41af91ab2d7cd011db47%7C1%7C0%7C637945036186370770%7CUnknown%7CTWFpbG > > Zsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn > > 0%3D%7C3000%7C%7C%7C&sdata=3DIyKR391AJksu3p85Z5q5xS%2FT7i0IC%2B9oX > > Y3VKE49s58%3D&reserved=3D0> > > AutoFDO: don't set param_early_inliner_max_iterations to=20 > > 10. > 2Fgcc.gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh%3Dc17975d81aae > > d49ff759c20c68b31304a6953d58&data=3D05%7C01%7CEugene.Rozenfeld%40m > > icrosoft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f988bf86f141af91 > > ab2d7cd011db47%7C1%7C0%7C637945036186683243%7CUnknown%7CTWFpbGZsb3d8 > > eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 > > C3000%7C%7C%7C&sdata=3Dd%2Fj8IyRYVjCA1grtov7PNzhp4eRszLEflY21kKCN8 > > eo%3D&reserved=3D0> > > AutoFDO: Don't try to promote indirect calls that result in=20 > > recursive direct=20 > > calls > F%2Fgcc.gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh%3Dba125745d9 > > e9fe90a18a2af8701b3269c5fdd468&data=3D05%7C01%7CEugene.Rozenfeld%4 > > 0microsoft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f988bf86f141af > > 91ab2d7cd011db47%7C1%7C0%7C637945036186683243%7CUnknown%7CTWFpbGZsb3 > > d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D > > %7C3000%7C%7C%7C&sdata=3DL4bypORscLpmmhxnaAupzTWepno447nbMcPUGiah2 > > b0%3D&reserved=3D0> Fix profile count maintenance in vectorizer=20 > > peeling. > A%2F%2Fgcc.gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh%3D5af2202 > > 4f62f1f596a35d3c138d41d47d5697ca0&data=3D05%7C01%7CEugene.Rozenfel > > d%40microsoft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f988bf86f14 > > 1af91ab2d7cd011db47%7C1%7C0%7C637945036186683243%7CUnknown%7CTWFpbGZ > > sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > > %3D%7C3000%7C%7C%7C&sdata=3DLTaHWhkpp2wH%2FaqoJZQ%2Bvcj5o%2FKZ4kQP > > OstxpsLuOKI%3D&reserved=3D0> > > > > I also made a number of fixes and improvements to create_gcov tool in h= ttps://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.c= om%2Fgoogle%2Fautofdo&data=3D05%7C01%7CEugene.Rozenfeld%40microsoft.com= %7Cfe5184091a18487fd92d08da6fa1619e%7C72f988bf86f141af91ab2d7cd011db47%7C1%= 7C0%7C637945036186683243%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj= oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D6i14y0= lx0m%2FSaN2jw3DKykIun5XiKj17x5%2BBL%2BGkBd4%3D&reserved=3D0 . > > > > AutoFDO in GCC is in a much better shape now. > > > > I have a further set of patches that improve DWARF discriminator=20 > > support in GCC and enable AutoFDO to use discriminators. It's based on = commits in an old Google vendor branch as described in Andi's mail below bu= t uses a different approach for keeping track of per-instruction discrimina= tors. > > > > I submitted the first (and the biggest) of these patches almost 2=20 > > months ago on June 2:=20 > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgc > > c.gnu.org%2Fgit%2F%3Fp%3Dgcc.git%3Ba%3Dcommit%3Bh%3D5af22024f62f1f59 > > 6a35d3c138d41d47d5697ca0&data=3D05%7C01%7CEugene.Rozenfeld%40micro > > soft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f988bf86f141af91ab2d > > 7cd011db47%7C1%7C0%7C637945036186683243%7CUnknown%7CTWFpbGZsb3d8eyJW > > IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300 > > 0%7C%7C%7C&sdata=3DLTaHWhkpp2wH%2FaqoJZQ%2Bvcj5o%2FKZ4kQPOstxpsLuO > > KI%3D&reserved=3D0 but only got a review from Andi=20 > > (https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgc= c.gnu.org%2Fpipermail%2Fgcc-patches%2F2022-June%2F596549.html&data=3D05= %7C01%7CEugene.Rozenfeld%40microsoft.com%7Cfe5184091a18487fd92d08da6fa1619e= %7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637945036186683243%7CUnknown%= 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M= n0%3D%7C3000%7C%7C%7C&sdata=3DG2578gq1F7h5s8ussOZVZtERXNKkgQD%2FJOvJ0KB= 7ct8%3D&reserved=3D0) who is not allowed to approve patches for commit.= I pinged gcc-patches twice with no success. > > > > I would appreciate help in getting a review on this patch so that I can= get it committed and submit patches that depend on it. >=20 > Hi, Eugene >=20 > Thanks for your efforts to fix and improve AutoFDO in GCC. I believe=20 > that part of the difficulty with obtaining a review of the patches is=20 > that the original authors have dispersed and no one in the GCC=20 > community officially is the maintainer for the feature. Because you=20 > seem to be one of the primary users and developers, would you be=20 > interested to take on the responsibility of maintaining the=20 > AutoFDO-specific portions of the code, with guidance and mentorship=20 > from other GCC maintainers, especially the ones responsible for gcov=20 > and PDO? I missed the patches (it would help to add me to CC :) and will review the = FDO/profile facing parts. Since it also extends debug info generation and = front-ends I think we also need reviewer for that part. Having auto-FDO co-maintainer would be welcome. Honza >=20 > Thanks, David >=20 > > > > Thank you, > > > > Eugene > > > > -----Original Message----- > > From: Andi Kleen > > Sent: Monday, May 10, 2021 10:21 AM > > To: Joseph Myers > > Cc: Jan Hubicka ; gcc ; Eugene=20 > > Rozenfeld > > Subject: [EXTERNAL] Re: State of AutoFDO in GCC > > > > On Mon, May 10, 2021 at 04:55:50PM +0000, Joseph Myers wrote: > > > On Mon, 10 May 2021, Andi Kleen via Gcc wrote: > > > > > > > It's difficult to find now because it was a branch in the old=20 > > > > SVN that wasn't converted. Sadly the great git conversion was quite= lossy. > > > > > > All branches and tags, including deleted ones, were converted=20 > > > (under not-fetched-by-default refs in some cases); the git=20 > > > repository has everything that might plausibly be useful, omitting=20 > > > only a few things that would have been meaningless to convert,=20 > > > such as mistaken branch creations in the root of the repository and t= he SVN hooks directory. > > > Use "git ls-remote git://gcc.gnu.org/git/gcc.git" to see the full=20 > > > list of over 5000 refs available in the repository (or do a clone=20 > > > with --mirror to fetch them all). > > > > Okay thanks. I don't see them in any of the web interfaces, neither=20 > > on > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgc > > c.gnu.org%2Fgit%2Fgitweb.cgi%3Fp%3Dgcc.git&data=3D05%7C01%7CEugene > > .Rozenfeld%40microsoft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f9 > > 88bf86f141af91ab2d7cd011db47%7C1%7C0%7C637945036186683243%7CUnknown% > > 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC > > JXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DBC%2BdUNgy2eSrnK7dWA%2B1hj1my > > OhW7O94Mdcywbx1AI8%3D&reserved=3D0 > > nor on > > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgi > > thub.com%2Fgcc-mirror%2Fgcc&data=3D05%7C01%7CEugene.Rozenfeld%40mi > > crosoft.com%7Cfe5184091a18487fd92d08da6fa1619e%7C72f988bf86f141af91a > > b2d7cd011db47%7C1%7C0%7C637945036186683243%7CUnknown%7CTWFpbGZsb3d8e > > yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C > > 3000%7C%7C%7C&sdata=3DTcRqYfDpYTTRgh7y%2FxRmuAjLDrLDUMLwrnJsklD2mZ > > I%3D&reserved=3D0 > > but > > git fetch origin vendors/google/heads/gcc-4_8 does the trick for fetchi= ng the commits, but not the symbolic branches. > > > > Anyways with that it looks like the discriminator changes are: > > > > commit fd9de90d750e3588b1e5a218b28102b6c8bb8434 > > Author: Dehao Chen > > > Date: Thu Oct 10 14:39:31 2013 +0000 > > > > Use only lineno+discriminator (remove the callee function name) as = the key to represent callsite. Because each callsite will have its discrimi= nator if in the same line. > > > > 2013-10-10 Dehao Chen =20 > > > > > > > * gcc/auto-profile.c (get_function_instance_by_decl): Remov= e > > callee_name from callsite. > > (read_function_instance): Likewise. > > > > From-SVN: r203379 > > > > commit 3987da76affbfbe7195c0a16b33beedc649ec14f > > Author: Dehao Chen > > > Date: Tue Aug 27 16:46:49 2013 +0000 > > > > Refactor AutoFDO to: > > > > 1. Now that we have discriminator for inlined callsite, we do not n= eed special handling for callsite location any more. > > 2. If a source line is mapped to multiple BBs, only the first BB wi= ll be annotated. > > 3. Before actual annotation, mark everythin BB/edge as not annotate= d. > > > > 2013-08-27 Dehao Chen =20 > > > > > > > * gcc/auto-profile.c (location_set): New data structure. > > (get_count_info): Add new parameter. > > (get_combined_location): Remove unused parameter. > > (get_inline_stack): Remove unused parameter. > > (afdo_get_bb_count): Add new parameter. > > (afdo_annotate_cfg): Reset annotated flags. > > commit 1e6c4a7a8fb8e20545bb9f9032d3854f3f794c18 > > Author: Dehao Chen > > > Date: Thu Aug 22 17:20:29 2013 +0000 > > > > Set discriminator for call stmts within a same basic block. > > > > 2013-08-22 Dehao Chen =20 > > > > > > > * gcc/tree-cfg.c (assign_discriminators): assign discrimina= tor for > > call stmt in a same BB if it is mapped to a same line. > > > > commit b0be0175f4cf18fdd77bb013b181eead3a0a4773 > > Author: Dehao Chen > > > Date: Mon Aug 19 21:26:33 2013 +0000 > > > > Fix the discriminator assignment bug during hashing. > > > > 2013-08-19 Dehao Chen =20 > > > > > > > * tree-cfg.c (next_discriminator_for_locus): Fix discrimina= tor > > assignment bug. > > > > From-SVN: r201857 > > commit 9fa26998a63d4b22b637ed8702520819e408a694 > > Author: Dehao Chen > > > Date: Mon Aug 19 20:16:47 2013 +0000 > > > > Add discrminator for inlined callsites. > > > > 2013-08-19 Dehao Chen =20 > > (dehao@google.com) > > > > * include/dwarf2.def (DW_AT_GNU_discriminator): New attribu= te. > > * gcc/dwarf2out.c (add_call_src_coords_attributes): Emit di= scriminator > > attribute for inlined callsite. > > > > From-SVN: r201856 > > > > -Andi > >