From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11olkn2104.outbound.protection.outlook.com [40.92.20.104]) by sourceware.org (Postfix) with ESMTPS id D2934385E836 for ; Thu, 2 May 2024 23:13:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D2934385E836 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maskray.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=maskray.me ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D2934385E836 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.92.20.104 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1714691627; cv=pass; b=gWaFJtnx9g+laf3/cCiF0H8d7ffOTxDs6DCfNDScXazY9vUbBzBramcLEb4jJxFvHPoybDcioKSvBDlH6MxaKL7uahqgVJpvnQ4IlDTqHoqPY4l6msBJZf7wR9JoKnD+lKfePUy7ZVcRFIHOCVXx6NHKKHB/POazU03AUkU2gAw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1714691627; c=relaxed/simple; bh=dwPw/2qE4tc8+9axlpZAVKBuPfM852ZZh/uWpZqajp0=; h=From:Date:Message-ID:Subject:To:MIME-Version; b=PeUyrigcSdvoIHYVuDb9wV3NQw/wyhjBbjo+sCn+ILSP1n5UTI+uQlOr9hW2p5WvbBsJpcFtIm5S9JP0jg0jvkm5R9V8s96+rb+aBrDYv0oPhs09nLleDisNgOCVgBs8tkXFWK2lt48nWdkU9UK4zcWgLZ2cHx2v3iqwqDBz5q8= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PE78tcoIPSDdz51vGf5SiVYI9XRSGykpT5301YjMnsbJE+yplIER9V4f9+h9sJB60iLWFmn7Y0EjMEJLuBVHLigKd+xSxKELdea6FNtjQxvOpPwlkxDZpKkjEqo+YCL4Jgu6+q26vkebuu4QowRWhA/UtJtDChKfT8pK5vAUFzP1pzVDDIAVethXhe2W427y3irmwLkkJOWB7QaQ+3VsJfCOcwdxtl/F1G17teEvwUuKpHsU2/98YvR5vX9dtjVsFK4M53Pph4VKu4ap4pZ8pgIrZz+PteMhkQZw2iWiob+IW1qozIGgGT9m5ZlSvsnlbBIEPP2OKoOCC3IjzxDfgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mRQpNMrTBFI0YZ8Et/4+EisAYQfy5WC7Ae1Kbd5gemE=; b=PtpwMJnz1LMieFNu92X9agbBU7Bw9Vqk7oRSGkuZFbH3GbDcdHnCvLWbIGheuTyHqfWukBNOgAXHHKGXzMjezQmA5UJFsmSbaLw9dtEz0leu4g2u+SfoqRAdtkuHW1WexiO2q25AZL/RXxYodvst5Jba5Khb2kkkg/cUghwcWGJWcaqetZspAkCHjsjwBKjQRhk0DPgbYK5qJ1jsIfjscUpR5fvM1kbA4JGuYtqNrBeibpBIFjYoFz4UyGAbDM/nms8nQnU8ppTvCWU1MBe1pZ0AGYieGdcu5XmhnSZeLwT8UByZSo64cdFp47CfmvOjU3anirYbmehBM6aijBFgNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) by SA3PR12MB7973.namprd12.prod.outlook.com (2603:10b6:806:305::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.30; Thu, 2 May 2024 23:13:44 +0000 Received: from DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::3f49:9f92:3fcd:e374]) by DS7PR12MB5765.namprd12.prod.outlook.com ([fe80::3f49:9f92:3fcd:e374%3]) with mapi id 15.20.7544.029; Thu, 2 May 2024 23:13:43 +0000 X-Forwarded-Encrypted: i=1; AJvYcCWPU9u7hckdXTkSuwiYRAg5wXrBUXCaHxVLJ7PJqTo94pfiJR94cwkmkQ1SYxoW83Ld+CbnYIwttWyGjZ1k+f8= X-Gm-Message-State: AOJu0YwAWH2vFQeX8NeqEmX/Jscjf6ixZ+TFHGhUHSTd0EwsX56yS4Tt EAUUrVqzCXE0ZLFgGhP2NkrBeqjU8bTGd93t4Lt8eRCGjfY2/q4/xLO3LRIcvtlXG9ZXltCK+6D ygNsk2tuGmSiIn6EAXoIbxU82Trk= X-Google-Smtp-Source: AGHT+IFWHP2KgbNnpHfnlKUElrwt/qs3XV34GOzQaxe6WBpdFELiaqCeiRYMEiXCL7HCeJQjU3RZt8tv2pdpsE9KQFM= X-Received: by 2002:a25:204:0:b0:de6:4ff:3155 with SMTP id 4-20020a250204000000b00de604ff3155mr1407323ybc.16.1714691133203; Thu, 02 May 2024 16:05:33 -0700 (PDT) References: <20240417232725.GC25080@gnu.wildebeest.org> <20240418173726.GD9069@redhat.com> <87v849qudy.fsf@tromey.com> <87wmooep76.fsf@tromey.com> <0347e05a-94c6-4ecc-aa8f-cc90358a813d@gmail.com> <20240501202008.GA6469@gnu.wildebeest.org> <874jbh45l8.fsf@tromey.com> <64d0e314-f4e9-4c63-90dd-67a05749e12e@simark.ca> <9a7111c2-d570-4d26-8fe9-f34834ae1eab@palves.net> In-Reply-To: <9a7111c2-d570-4d26-8fe9-f34834ae1eab@palves.net> From: Fangrui Song Date: Thu, 2 May 2024 16:05:21 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Updated Sourceware infrastructure plans To: Pedro Alves Cc: Simon Marchi , Overseers mailing list , Mark Wielaard , Tom Tromey , Jeff Law , Joseph Myers , Jonathan Wakely , libc-alpha@sourceware.org, Jason Merrill , gcc@gcc.gnu.org, gdb@sourceware.org, binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-TMN: [h/sxw8V3MtLI2hhtoRlI7F64LLB6kdtg] X-ClientProxiedBy: BN1PR10CA0028.namprd10.prod.outlook.com (2603:10b6:408:e0::33) To DS7PR12MB5765.namprd12.prod.outlook.com (2603:10b6:8:74::19) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5765:EE_|SA3PR12MB7973:EE_ X-MS-Office365-Filtering-Correlation-Id: 31141e35-391c-4c8e-9a38-08dc6afd82fd X-Microsoft-Antispam: BCL:0;ARA:14566002|461199019|1602099003|56899024|3412199016|440099019; X-Microsoft-Antispam-Message-Info: S/TZs90qvdCb48Klwku1Sghnwkfx534crw2Nj6ltYtyItuI5BJ638HFpgEP3sEmQaml036YrJU31hl65TD6H1JZx6OSDIFn69Fra87KZoXMDnk7AgGsP4TqqhDY1lp9u62ZQOGRxRXegz6Eegkk1yBlU5lLZAf4+pf6GbwzdvNHEyIQkfYyzoLHvKKqI04HulNthhkW5+06fPowRHn8uqAjgi9kKkxnG6BCZCGTcdDkABTbonKa0lWAI9S6yKasDVuXHrMqhhHunemdSPPG1BFjpPSbYV2pD/w7oQ5G7R+sECBbJWvN5XXvYX5sXjQA9D9vBiypBu3lax9MRkYjtPqSMi7mT7uW3eOU9IPJdJNt8bEOw5jxgOU9b72GKUDYXmE7L4W//DKM1MnTGlT8D5bI/M5tJa/5Dj7vI1AttIUViOLB++LpPcFW0x3DQ+y/2SHSPrSsJpfDDJJWyEf3krN4ZjqZ2UlC2qHC82e9OMrqbLRvpRNTh40ejVQVYSMCgfrs/vYWXK/6rNJWonBAj0tEUUxBKYDpYt03sRMguMoGhpjuOzmgoRMCCig9z9UUJ+ldRuYFK/bgDdoG4idHhWC65WRt7CnvjIDCnqswK090gZwtK3EyCdvcnxkS4hJlsVpoyQdhtSzCLUy7BPmh90g2Thqh6fhhDTV7i1n0TvtI= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OE9BQ1dWUStXMU1WbUd1Nng2K0R3dXBTZk9CUFdjdkRQTXZhR2JkaXRlT29m?= =?utf-8?B?bFg3N3VlWUM0UUIzZ09iOVZvSFlUTlQzTUVOa1lFcEtHdGc1TFdpMGo5MTNm?= =?utf-8?B?ZXRwQ1RuMHNaUWM1Si8vZTdSazZxRE1Lc21PbTNPQjh3ZlJyWmVpWkdYenVD?= =?utf-8?B?RWRtQjYrMFcycDB3MDNjc09pSDY3ck9HRFR3c3BpZi9HVit0YWlneW96WmZB?= =?utf-8?B?a1ZMc1huM1FSZEhkR3FnQWVVWWF6SGZ3VkhDM0szYWxOSmN4eW85WllNWXFH?= =?utf-8?B?ZEJwVm5WUHFXSEYyeWwyc3hURlpMVm5RRk1ZMDFwUG5nNjZ1NzIyeW5yZ1o4?= =?utf-8?B?VE9YTzFlQ1N0QUZpMzNMM04zUEdmMTdWOEwwZ2xJSElWMmZZb09kdmxrRi9o?= =?utf-8?B?dTlHTnlJNGg3VjUxQ1B2aWJFNUR2aHQ1YUdkaGdKTlArSHRGaGtHZ05VbmtO?= =?utf-8?B?blFZS01SVWhZTGZDLzBkVGh0ZHFTczJnVmRCSVdFenozenBidUk0T3NXaFFB?= =?utf-8?B?SkEzMW92SlUzcmV3VVlnMnUxZU9Ma21LZXpLTCs5bFgyN3diMVFtZDdWVlZW?= =?utf-8?B?eDFtMCtGMWsxTUFHRUdjMW1UVk10MmN0aEVtU3RVVk5CekF5dE1LR1VQMW05?= =?utf-8?B?UjlWWm5haklGNHB2cC8yT3VsSzBhVEhTeHh3R2x2em9mRGlPUWFuS3JVeklP?= =?utf-8?B?T3dvSE85LzFSeEEvTmNFUXdCQmg4ZlR3Mk55bWhDaUlqelR1SE5LZHpNWVov?= =?utf-8?B?QVRWS0dyUGFCRmlZWmVsQVlYZ0kyVlpDck04RlRVeW1POGlBMG1Ua2tkT2Va?= =?utf-8?B?RHVCWWU0VmlYNG9rNHJBN045Nko5U2dIclZaVnd6STdaMEtCekNVRnVYM1p1?= =?utf-8?B?MEpoSzZQaEU4bkp6SWk1elFYNFY4TWhWeXB5TjBrcU5pdytIcUxDRk5SN3lH?= =?utf-8?B?cUkrWDR1M1BoSDZhKzlqVGh0M09kS2xmMXU2OFF0TDVPOW9YMVB3MlcwQTN4?= =?utf-8?B?NldEN2VzSGdybm9rTllrem51OE1xVFBPSUorSFE1QWZWNEhzU25qOE00WlZF?= =?utf-8?B?VGtjWHFXNFJRZFArT05IVlJiN2dZazJSYnV0QU9JMzhlanhMd0tWK0I1aGIw?= =?utf-8?B?TUx6MlVtSkNIdVN2am1IemwrOGZUK0RvUVBBRzRBRzdITWo2cjlZRDJobVdn?= =?utf-8?B?WER1aDBrRG9Yd0pxMHFiNEJZd0Q3WnhwdkdSeGxMWU9XQjRBNlFDVWpRYUhD?= =?utf-8?B?VGNJRHVmclRQRElZYytRUitWNUYwOHFrdWwzSFZqRmtiZVZxd1lnU3JuZkpK?= =?utf-8?B?RFBuM2tCUWFzdmEzbEFhejhBR3Z2Uzh4am9qVm5tNVRlV0JVbmRrNEcwbk13?= =?utf-8?B?M056bG04K0Q4V3o1VmtsMVNIUldERkVnVWZGNG5DUi9rcUo4VDcrZUxnNU1O?= =?utf-8?B?Q0U2OExiRzhzNXR1eGFxUU56U1I1QkhTdmFyZWJBMXF3dVp0anBRVDNmdld6?= =?utf-8?B?WWk5d0s2RFBNU0YyNVpGKzFoenppY3ZEdGFRSU5WQTlBNXNJRVZHOXkrQ2tP?= =?utf-8?B?K1hvK1JrN3FYSThmL0U4dGtFZm1PWHdpYXlIQ1JEUnJRWmwwV09QWW1PVWdo?= =?utf-8?B?b0RuY1hrTWRGYjVrRWFyYlBTcjhPU0E9PQ==?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-5183d.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 31141e35-391c-4c8e-9a38-08dc6afd82fd X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5765.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 23:13:43.8638 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7973 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 2, 2024 at 8:35=E2=80=AFAM Pedro Alves wrote= : > > On 2024-05-01 22:04, Simon Marchi wrote: > > The Change-Id trailer works very well for Gerrit: once you have the hoo= k > > installed you basically never have to think about it again, and Gerrit > > is able to track patch versions perfectly accurately. A while ago, I > > asked patchwork developers if they would be open to support something > > like that to track patches, and they said they wouldn't be against it > > (provided it's not mandatory) [1]. But somebody would have to implemen= t > > it. > > > > Simon > > > > [1] https://github.com/getpatchwork/patchwork/issues/327 > > +1000. It's mind boggling to me that people would accept Gerrit, which > means that they'd accept Change-Id:, but then they wouldn't accept > Change-Id: with a different system... :-) > Gerrit uses "Change-Id:" as stable identifiers to track patches. https://gregoryszorc.com/blog/2020/01/07/problems-with-pull-requests-and-ho= w-to-fix-them/ has some analysis how they are much better than the alternative smart way. Perhaps URLs as stable identifiers will work better. If a reader wants to find relevant discussions, they can just click the link in many browsers, terminals, and editors. Currently, searching for discussions about a specific commit requires searching its title on https://inbox.sourceware.org/gcc-patches/ . For older patches, I might even need to dig through https://gcc.gnu.org/pipermail/gcc-patches/YYYY-MMMM/ archives. I agree with Jeff that principal reviewers will drive improvement to the code review process. I am sharing two code review services LLVM has used. --- Between 2012 and Sep 2023, LLVM had relied on its self-hosted Phabricator instance for code review. Fetching a patch to your local branch was as simple as `arc patch D12345`. Similarly, creating or updating a patch involved `arc diff`. I believe other code review services provide similar command line functiona= lity, --- In September 2023, LLVM transitioned to GitHub for code review. I really dislike its code review service (however, this is a large step forward than email based code review). From https://maskray.me/blog/2023-09-09-reflections-on-llvm-switch-to-github-pul= l-requests > On the other hand, GitHub structures the concept of pull requests around = branches and enforces a branch-centric workflow. A pull request centers on = the difference (commits) between the base branch and the feature branch. Gi= tHub does not employ a stable identifier for commit tracking. If commits ar= e rebased, reordered, or combined, GitHub can easily become confused. > > When you force-push a branch after a rebase, the user interface displays = a line such as "force-pushed the BB branch from X to Y". Clicking the "comp= are" button in GitHub presents something like git diff X..Y, which includes= unrelated commits. Ideally, GitHub would show the difference between the t= wo patch files, as Phabricator does, but it only displays the difference be= tween the two head commits. These unrelated in-between commits might be acc= eptable for projects with lower commit frequency but can be challenging for= a project with a code frequency of 100+ commits every day. > > The fidelity of preserving inline comments after a force push has always = been a weakness. The comments may be presented as "outdated". In the past, = there was a notorious "lost inline comment" problem. Nowadays, the situatio= n has improved, but some users still report that inline comments may occasi= onally become misplaced. Thankfully, getcord/spr comes to a rescue. User branches allow me to create/update a patch using `spr diff` like `arc diff` for Phabricator.